Backport of Rename hcp-metrics-collector to consul-telemetry-collector into release/1.15.x#17386
Closed
hc-github-team-consul-core wants to merge 1 commit intorelease/1.15.xfrom
Closed
Conversation
7dccf73 to
0395d14
Compare
0395d14 to
7dccf73
Compare
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
github-team-consul-core-pr-approver
approved these changes
May 16, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
4 tasks
Contributor
|
Manual backport PR opened #17412 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17327 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@Achooo
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
We originally named the collector service name as hcp-metrics-collector. Rename the service name to follow the intended project name.
Also renamed the
bind_socket_dirconfig key to remove thehcpreference. The collector can be used without HCP so it made sense to generalize the nameTesting & Reproduction steps
bin/consul agent -devconsul services register web.json{ "service": { "name": "web", "port": 9191, "connect": { "sidecar_service": { "proxy": { "config": { "envoy_telemetry_collector_bind_socket_dir": "/Users/ashvitha.sridharan/tmp/" } } } } }}```
consul services register collector.json{ "service":{ "name": "consul-telemetry-collector", "port": 9090, "connect": { "sidecar_service": { } } } }./bin/consul connect envoy -sidecar-for web -- -l debug./bin/consul connect envoy -admin-bind localhost:19001 -sidecar-for consul-telemetry-collector -- -l debugLinks
PR Checklist
Overview of commits