Remove ability to specify external addresses in GenerateToken endpoint#14930
Merged
ndhanushkodi merged 5 commits intomainfrom Oct 19, 2022
Merged
Remove ability to specify external addresses in GenerateToken endpoint#14930ndhanushkodi merged 5 commits intomainfrom
ndhanushkodi merged 5 commits intomainfrom
Conversation
ndhanushkodi
force-pushed
the
nd/peering-remove-server-external-addr
branch
from
01f4514 to
db04ff3
Compare
freddygv
approved these changes
Oct 13, 2022
Contributor
freddygv
left a comment
freddygv
left a comment
There was a problem hiding this comment.
Mostly LGTM, left one question about some additional docs that may need to be updated
website/content/api-docs/peering.mdx
Outdated
Contributor
There was a problem hiding this comment.
I think there may be some additional docs to update, the ones from this PR:
https://github.com/hashicorp/consul/pull/14191/files
../cluster-peering/k8s.mdx and ../k8s/helm.mdx
Contributor
Author
There was a problem hiding this comment.
Yup! I was thinking to update those as a separate docs PR since the K8s side PR for making/testing mesh gateways work is not yet merged.
Contributor
There was a problem hiding this comment.
OK then you can go ahead and merge this
ndhanushkodi
force-pushed
the
nd/peering-remove-server-external-addr
branch
from
7e89cc7 to
b18d61a
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Consul 1.13, we allowed setting external addresses for the server in the generate token endpoint, so when external load balancers were configured in front of the servers, those LB addresses could be used to dial the servers. With support for mesh gateways for peering establishment between servers, this is no longer needed, since the mesh gateways can be given wan addresses.
Links
This is a subtask of https://hashicorp.atlassian.net/browse/NET-1050
PR Checklist