Update generate token endpoint to take external addresses#13844
Merged
ndhanushkodi merged 1 commit intomainfrom Jul 21, 2022
Merged
Update generate token endpoint to take external addresses#13844ndhanushkodi merged 1 commit intomainfrom
ndhanushkodi merged 1 commit intomainfrom
Conversation
github-actions
bot
added
pr/dependencies
ndhanushkodi
added
theme/cluster-peering
ndhanushkodi
force-pushed
the
peering/gen-token-ext-addr
branch
from
5ad62ac to
9a3b9fa
Compare
ndhanushkodi
force-pushed
the
peering/gen-token-ext-addr
branch
from
9a3b9fa to
663e375
Compare
This was referenced Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update generate token endpoint (rpc, http, and api module)
If ServerExternalAddresses are set, it will override any addresses gotten from the "consul" service, and be used in the token instead, and dialed by the dialer. This allows for setting up a load balancer for example, in front of the consul servers.
(Addresses comments from https://github.com/hashicorp/consul-enterprise/pull/2363, and 2363 will get closed.)
PR Checklist