Brings back parameter ServerExternalAddresses in GenerateToken endpoint#15215
Closed
ndhanushkodi wants to merge 1 commit intomainfrom
Closed
Brings back parameter ServerExternalAddresses in GenerateToken endpoint#15215ndhanushkodi wants to merge 1 commit intomainfrom
ndhanushkodi wants to merge 1 commit intomainfrom
Conversation
github-actions
bot
added
theme/api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "Remove ability to specify external addresses in GenerateToken endpoint (#14930)"
This reverts commit 5e15677.
Originally ServerExternalAddresses were added to support peering across networks in k8s before peering over mesh gateways for the control plane was supported. Support for that parameter was reverted since it was no longer needed for k8s (where mesh gateways are now the required approach for control plane traffic for peering), but bringing it back because it's useful for managed deployments where deploying mesh gateways is currently out of scope.
Links
https://hashicorp.atlassian.net/browse/NET-1229
PR Checklist