peering: prevent peering in same partition#13851
Merged
Conversation
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
acpana
added
pr/no-changelog
Contributor
|
Hey Alex, server addresses are not specific to a partition, they're specific to a datacenter. Checking whether server addresses match would prevent users from peering two different partitions in the same Consul datacenter. Another wrinkle is that addresses embedded in a token may not be the same ones that come from Could the peer ID help instead? |
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
acpana
force-pushed
the
acpana/peername-illegal-2
branch
from
f79ed3f to
8689b7c
Compare
Contributor
Author
|
thanks for the guidance @freddygv ! how is this? |
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
mkeeler
approved these changes
Jul 25, 2022
Member
mkeeler
left a comment
mkeeler
left a comment
There was a problem hiding this comment.
LGTM.
Food for thought
Should we allow peering with any partition within the same cluster. We can already export services across partitions and it seems less than desirable to duplicate those within memdb.
kisunji
suggested changes
Jul 25, 2022
kisunji
reviewed
Jul 25, 2022
kisunji
reviewed
Jul 25, 2022
kisunji
reviewed
Jul 25, 2022
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
kisunji
reviewed
Jul 25, 2022
Co-authored-by: Chris S. Kim <ckim@hashicorp.com>
kisunji
reviewed
Jul 25, 2022
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
…ul into acpana/peername-illegal-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to prevent a
peeringfrom being created in the same partition (ENT) or cluster (OSS).We do this by looking for an intersection (any) between the server addresses encoded in the token and those of the current cluster's.