Skip to content

Backport of [docs] update doc headers into stable-website#13563

Merged
kschoche merged 2 commits intostable-websitefrom
backport/update_helm_docs_june21/initially-rare-lioness
Jun 23, 2022
Merged

Backport of [docs] update doc headers into stable-website#13563
kschoche merged 2 commits intostable-websitefrom
backport/update_helm_docs_june21/initially-rare-lioness

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #13527 to be assessed for backporting due to the inclusion of the label type/docs-cherrypick.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


Description

Describe why you're making this change, in plain English.
Use anchor links for table of contents in helm k8s docs.

Due to functionality we have which auto-generates anchors for code snippets which are list items. connectInject exists higher up the page as a list item, and so an anchor is generated for it with the id #connectinject. Because the heading we are trying to link to is further down the page, it gets the -1 suffix to ensure uniqueness, use anchor links instead.

Testing & Reproduction steps

  • In the case of bugs, describe how to replicate
  • If any manual tests were done, document the steps and the conditions to replicate
  • Call out any important/ relevant unit tests, e2e tests or integration tests you have added or are adding

Links

Include any links here that might be helpful for people reviewing your PR (Tickets, GH issues, API docs, external benchmarks, tools docs, etc). If there are none, feel free to delete this section.

Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner June 22, 2022 20:56
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/update_helm_docs_june21/initially-rare-lioness branch from 0889e36 to 49a2e24 Compare June 22, 2022 20:56
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jun 22, 2022
* update helm docs to have correct headers
@kschoche kschoche merged commit 9d240dd into stable-website Jun 23, 2022
@kschoche kschoche deleted the backport/update_helm_docs_june21/initially-rare-lioness branch June 23, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants