Conversation
kschoche
added
type/docs
2 tasks
kschoche
added
the
pr/no-changelog
david-yu
approved these changes
Jun 21, 2022
… into update_helm_docs_june21
This was referenced Jun 22, 2022
im2nguyen
pushed a commit
that referenced
this pull request
Jun 23, 2022
* update helm docs to have correct headers
im2nguyen
pushed a commit
that referenced
this pull request
Jun 23, 2022
* update helm docs to have correct headers
kschoche
added a commit
that referenced
this pull request
Jun 23, 2022
kschoche
added a commit
that referenced
this pull request
Jun 23, 2022
eculver
pushed a commit
that referenced
this pull request
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe why you're making this change, in plain English.
Use anchor links for table of contents in helm k8s docs.
Due to functionality we have which auto-generates anchors for code snippets which are list items. connectInject exists higher up the page as a list item, and so an anchor is generated for it with the id #connectinject. Because the heading we are trying to link to is further down the page, it gets the -1 suffix to ensure uniqueness, use anchor links instead.
Testing & Reproduction steps
Links
Include any links here that might be helpful for people reviewing your PR (Tickets, GH issues, API docs, external benchmarks, tools docs, etc). If there are none, feel free to delete this section.
Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.
PR Checklist