Merged
Conversation
Small update to remove the hardcoded `-dev` suffix from dev_tags, which is causing tags to be in the format `1.12.0-dev-dev` instead of just `1.12.0-dev`. I'll clean up the old tags before making the dockerhub repo public, which will be available https://hub.docker.com/r/hashicorppreview/consul
github-actions
bot
added
the
theme/contributing
mdeggies
added
pr/no-changelog
Contributor
|
After merging, confirm that you see linked PRs AND check that them for CI errors. |
Contributor
|
After merging, confirm that you see linked PRs AND check that them for CI errors. |
3 similar comments
Contributor
|
After merging, confirm that you see linked PRs AND check that them for CI errors. |
Contributor
|
After merging, confirm that you see linked PRs AND check that them for CI errors. |
Contributor
|
After merging, confirm that you see linked PRs AND check that them for CI errors. |
mdeggies
requested review from
a team,
kpenfound and
modrake
and removed request for
a team
eculver
approved these changes
May 24, 2022
Contributor
eculver
left a comment
eculver
left a comment
There was a problem hiding this comment.
Aha! I noticed this recently but hadn't gotten around to fixing it. Thanks!
Member
Author
|
Thanks! I noticed this right after merging the last one, but took awhile to get the PR up 🙈 this should fix it |
This was referenced May 24, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small update to remove the hardcoded
-devsuffix from dev_tags, which is causing tags to be in the format1.12.0-dev-devinstead of just1.12.0-dev. I'll clean up the old tags before making the dockerhub repo public, which will be available https://hub.docker.com/r/hashicorppreview/consul.dev_tags were first introduced in #13084