Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

Add robust set of dev tags for release + main branches, PRs#178

Closed
nathancoleman wants to merge 2 commits intomainfrom
docker-dev-tags
Closed

Add robust set of dev tags for release + main branches, PRs#178
nathancoleman wants to merge 2 commits intomainfrom
docker-dev-tags

Conversation

@nathancoleman
Copy link
Copy Markdown
Member

@nathancoleman nathancoleman commented Apr 28, 2022

Changes proposed in this PR:

For release/** branch:

  • No changes, still just publish to consul-api-gateway:<version>

For main branch:

  • a mutable tag, consul-api-gateway:latest that gets updated for every commit
  • an immutable-ish tag, consul-api-gateway:<commit-sha> that points at each unique commit's build

For pull requests:

  • a mutable tag, consul-api-gateway:pr-<number> that gets updated for every commit in the PR
  • an immutable-ish tag, consul-api-gateway:<commit-sha> that points at each unique PR commit's build

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@mikemorris
Copy link
Copy Markdown
Contributor

@nathancoleman
Copy link
Copy Markdown
Member Author

Closing for now since CRT processes don't currently run for PR branches and would require some changes to do so

@nathancoleman nathancoleman deleted the docker-dev-tags branch June 6, 2022 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants