Skip to content

Backport of [CI-only] Update tagging for dev_tags into release/1.8.x#13208

Closed
hc-github-team-consul-core wants to merge 2 commits intorelease/1.8.xfrom
backport/update-dev_tags-tagging/formally-working-anchovy
Closed

Backport of [CI-only] Update tagging for dev_tags into release/1.8.x#13208
hc-github-team-consul-core wants to merge 2 commits intorelease/1.8.xfrom
backport/update-dev_tags-tagging/formally-working-anchovy

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #13199 to be assessed for backporting due to the inclusion of the label backport/1.8.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


Description

Small update to remove the hardcoded -dev suffix from dev_tags, which is causing tags to be in the format 1.12.0-dev-dev instead of just 1.12.0-dev. I'll clean up the old tags before making the dockerhub repo public, which will be available https://hub.docker.com/r/hashicorppreview/consul.

dev_tags were first introduced in #13084

@vercel
Copy link
Copy Markdown

vercel bot commented May 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
consul ❌ Failed (Inspect) May 24, 2022 at 11:24PM (UTC)
consul-ui-staging ❌ Failed (Inspect) May 24, 2022 at 11:24PM (UTC)

@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented May 24, 2022

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • mdeggies
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@eculver
Copy link
Copy Markdown
Contributor

eculver commented May 24, 2022

1.8 is EOL now so I think we can just close this.

@mdeggies
Copy link
Copy Markdown
Member

Thank you as always @eculver !!

@mdeggies mdeggies closed this May 25, 2022
@mdeggies mdeggies deleted the backport/update-dev_tags-tagging/formally-working-anchovy branch May 25, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants