Skip to content

fix(controller): v2 pod controller errors for acl deletion#3172

Merged
DanStough merged 2 commits intomainfrom
dans/NET-6298/v2-token-cleanup-errors
Nov 7, 2023
Merged

fix(controller): v2 pod controller errors for acl deletion#3172
DanStough merged 2 commits intomainfrom
dans/NET-6298/v2-token-cleanup-errors

Conversation

@DanStough
Copy link
Copy Markdown
Contributor

Changes proposed in this PR:

  • Don't error out if a token is missing metadata.
  • Make sure dataplane is injected with the correct metadata so that the ACL token is created with metadata on login.
  • Explicitly call stop when in the init container when re-direction is enabled.

How I've tested this PR: manual K8S testing plus unit tests.

How I expect reviewers to test this PR: 👁️ 👃 👁️

Checklist:

@DanStough DanStough added the backport/1.3.x This release branch is no longer active. label Nov 3, 2023
@DanStough DanStough force-pushed the dans/NET-6298/v2-token-cleanup-errors branch from 3cb435f to 5a08469 Compare November 3, 2023 21:28
Copy link
Copy Markdown
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@DanStough DanStough force-pushed the dans/NET-6298/v2-token-cleanup-errors branch from 5a08469 to 8f23c90 Compare November 7, 2023 16:17
@DanStough DanStough enabled auto-merge (squash) November 7, 2023 16:28
@DanStough DanStough merged commit cd79533 into main Nov 7, 2023
@DanStough DanStough deleted the dans/NET-6298/v2-token-cleanup-errors branch November 7, 2023 16:51
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
* fix(controller): v2 pod controller errors for acl deletion

* test: fix tests for unsupported L7 TPs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.3.x This release branch is no longer active.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants