Retry searchDirectory if Google doesn't respond
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreda
approved these changes
Mar 17, 2023
anuragprafulla
referenced
this pull request
in razorpay/hermes
Jun 27, 2023
* Update people-select.ts * Add fetch to tsconfig * Fix type errors * Change retry syntax to for-loop * Add FetchService type, rename variables * Add documentation; Switch to restartableTask * Test retry function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds retry logic to
PeopleSelect'ssearchDirectorytask to address reports of occasional 504 timeouts when querying Google Collaborators.