Remove memoization of search field width. #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me. |
pfiller
added a commit
that referenced
this pull request
Jul 17, 2013
Remove memoization of search field width.
pfiller
added a commit
that referenced
this pull request
Jul 17, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenearley @stof @koenpunt
This addresses #1352 and #1167, but does not entirely fix them. As long as we don't have a window resize method, fields with widths will always run the risk of being behind the actual container size.
Performance of jQuery's outerWidth method was the original reason for adding memoization, but it does't seem to be a big enough problem to keep at all costs.