Change search match style #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's probably easier to look at the actual commits on this one. The diff is huge because I just swapped the location of a large block of CSS. |
|
👊 |
|
This is great. I'm assuming it will play nice with the new optgroup search. |
Yeah, the timing is not coincidental. |
pfiller
added a commit
that referenced
this pull request
Jul 17, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mlettini @starzonmyarmz @kenearley @stof @koenpunt
This is a relatively simple change. Rather than use a background color change to indicate a search match, we're now going to use an underline. This change allows search indication to happen even when the result is highlighted. I also just like it more.
This PR also includes a fix for an issue introduced by the SASS conversion by flipping the single/multiple style order.