Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When multiple Chosen is using percentage width, search field scaling needs adjusting. #1167

Closed
pfiller opened this issue Apr 26, 2013 · 1 comment
Closed

When multiple Chosen is using percentage width, search field scaling needs adjusting. #1167

pfiller opened this issue Apr 26, 2013 · 1 comment
Labels
Bug

Comments

@pfiller
Copy link
Contributor

pfiller commented Apr 26, 2013

I need to add a fiddle demonstrating this, but I want to get it recorded before I forget.

Reproduction steps:

  1. Set up a chosen using % width: $().chosen({ width: '75%' })
  2. Change the width of chzn-container in inspector to a smaller percentage
  3. Enter a long string in the search field and notice it's allowed to grow larger than the container.
@pfiller pfiller mentioned this issue Apr 26, 2013
Closed
@pfiller pfiller mentioned this issue Jul 16, 2013
Closed
pfiller added a commit that referenced this issue Jul 16, 2013
@pfiller
Remove memoization of search field width.
e5833ed 
Addresses #1352 and #1167, but may not fix them. Performance of
jQuery's outerWidth method was the original reason for adding
memoization, but it does't seem to be a big enough problem to keep
at all costs.
@pfiller pfiller mentioned this issue Jul 16, 2013
Merged
jrossgowan-pulsemining pushed a commit to PulseMiningSystems/chosen that referenced this issue Nov 19, 2013
@pfiller @jrossgowan-pulsemining
Remove memoization of search field width.
7dd746d 
Addresses harvesthq#1352 and harvesthq#1167, but may not fix them. Performance of
jQuery's outerWidth method was the original reason for adding
memoization, but it does't seem to be a big enough problem to keep
at all costs.
@pfiller
Copy link
Contributor Author

pfiller commented Jun 2, 2016

I can't recreate this anymore. Maybe it wasn't ever a thing. Maybe something else fixed it. Who knows.

@pfiller pfiller closed this as completed Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pfiller