Add support for Chrome Apps and WebExtensions

[lidel]

Stream detection via stream instanceof Stream does not work correctly in browser contexts such as Chrome Apps or WebExtensions in browsers exposing chrome.sockets, especially when different stream polyfils are used and mixed together.

This change replaces instanceof Stream checks with feature-detection of stream contract, enabling Hapi to be used in browserified form in Chrome Apps and other browser environments.

cc ipfs/ipfs-companion#716

[hueniverse]

First, I am not sure I want to support this use case. Can you give me an example where doing so would make sense? What kind of app would you be building with it?

Second, experience tells me this is not the only thing stopping it from working properly. We've gone through this with joi and other modules that required a lot of changes to work properly.

[lidel]

Real live example: js-ipfs in Brave browser (ipfs/ipfs-companion#716)

js-ipfs is using Hapi to expose HTTP2IPFS Gateway. Brave whitelisted our browser extension to have access to chrome.sockets and we are able to start HTTP2IPFS Gateway from within WebExtension context, without installing any additional software.

We tested it in practice and it works as expected (ipfs/ipfs-companion#664 (comment)). We use chrome-net and http-node to polyfill calls to net and http expected by Hapi.

The only remaining issue with Hapi was the Stream detection, and change from this PR solved that (we use code form this PR).

Stream-related entries from test/response.js pass, but I'm happy to add any additional tests you feel are necessary.

[hueniverse]

Thanks for the background. I hope to get to it this week and let you know if/how I can support it.

[lidel]

Anything I can do to help with evaluating this?

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.