Skip to content

Add support for Chrome Apps and WebExtensions #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hueniverse merged 1 commit into from
Sep 13, 2019
Merged

Add support for Chrome Apps and WebExtensions #3946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ exports = module.exports = internals.Response = class {
this.variety = 'buffer';
this._contentType = 'application/octet-stream';
}
else if (source instanceof Stream) {
else if (Streams.isReadableStream(source)) {
this.variety = 'stream';
this._contentType = 'application/octet-stream';
}
Expand Down Expand Up @@ -529,7 +529,7 @@ exports = module.exports = internals.Response = class {

// Stream source

if (source instanceof Stream) {
if (Streams.isStream(source)) {
if (typeof source._read !== 'function') {
throw Boom.badImplementation('Stream must have a readable interface');
}
Expand Down Expand Up @@ -607,7 +607,7 @@ exports = module.exports = internals.Response = class {
}

const stream = this._payload || this.source;
if (stream instanceof Stream) {
if (Streams.isReadableStream(stream)) {
internals.Response.drain(stream);
}
}
Expand Down
14 changes: 14 additions & 0 deletions lib/streams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,20 @@ const internals = {
team: Symbol('team')
};

exports.isStream = function (stream) {

return stream !== null &&
typeof stream === 'object' &&
typeof stream.pipe === 'function';
};

exports.isReadableStream = function (stream) {

return exports.isStream(stream) &&
stream.readable !== false &&
typeof stream._read === 'function' &&
typeof stream._readableState === 'object';
};

exports.drain = function (stream) {

Expand Down