fix: streaming HTTP APIs of js-ipfs in Brave#794
Merged
Conversation
This switches to async iterator version of ipfs.add (introduced to js-ipfs in ipfs/js-ipfs#2517) and ensures Node streams are replaced by deterministic version of readable-stream Closes #757
Member
Author
|
Tests pass, merging this fix to unblock other PRs |
lidel
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
ipfs.catintroduced to js-ipfs in chore: converts remaining file api methods to async iterators js-ipfs#2517 and ensures Node streams are replaced by deterministic version ofreadable-stream/api/v0/addand closes Brave: regression in embedded /api/v0/add #757