Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] ControllerDict prevented before_simulation_step on child controllers #613

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

RoboNuke
Copy link
Contributor

In the BaseAgent class, before_simulation_step calls it's controller object's before_simulation_step. When that controller is of type DictController or its subclass CombinedController the controller inherits baseController's before_simulation_step, which is an empty function. When the agent calls a DictController's before_simulation_step it always calls the empty function. If anyone writes a custom controller requiring before_simulation_step and their robot requires a DictController or it's children, then they will be unable to call the custom controller's before_simulation_step. In this pull I added a function to DictController to fix this issue.

@StoneT2000 StoneT2000 changed the title Fixed: ControllerDict prevented before_simulation_step on child controllers [BugFix] ControllerDict prevented before_simulation_step on child controllers Oct 10, 2024
@StoneT2000
Copy link
Member

thanks!

@StoneT2000 StoneT2000 merged commit 578a6cd into haosulab:main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants