Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add G1 robot #405

Merged
merged 5 commits into from
Jul 17, 2024
Merged

[Feature] add G1 robot #405

merged 5 commits into from
Jul 17, 2024

Conversation

matheecs
Copy link

@matheecs matheecs commented Jul 4, 2024

No description provided.

@StoneT2000
Copy link
Member

Thank you for your contribution in adding the new G1 robot! I will review this as soon as I can. Most likely though we might want to move the robot assets to under our organization and document any changes made to the original URDF but the rest should be fine.

@StoneT2000 StoneT2000 self-requested a review July 4, 2024 21:17
Copy link
Member

@StoneT2000 StoneT2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code looks mostly good. There are a few requests before I can finally merge this in.

For one, the G1 URDF is good but it is too complicated and not suitable for RL work (it runs too slowly). Is there a simplified G1 robot URDF? You can check out the H1 robot URDF we have here: https://github.com/haosulab/ManiSkill-UnitreeH1/tree/main/urdf

A simplified URDF is necessary to make simulation run much faster (fewer collision shapes and faster solving).

It is okay if a simplified G1 URDF is not available. If it is not available, then the only other change requested here is to remove the G1 stand task you added and the example ppo script added to the readme.

mani_skill/utils/download_asset.py Outdated Show resolved Hide resolved
@matheecs
Copy link
Author

matheecs commented Jul 16, 2024

I created a simplified URDF, g1_simplified.urdf, to improve simulation speed. The training demo looks like this:

12.mp4

Note: Please pull the latest update from the original repository.

@StoneT2000
Copy link
Member

StoneT2000 commented Jul 16, 2024

Maybe a bit too simplified. Certainly runs fine but since the simplification removes everything but meshes for the feet / legs, can you rename unitree_g1_simplified to unitree_g1_simplified_legs? Same for the URDF file name to make it clear. I think some users may find it confusing why the simplified model can fall through the floor a bit.

After that then happy to merge.

@matheecs
Copy link
Author

I renamed unitree_g1_simplified to unitree_g1_simplified_legs and updated the URDF name. Thanks.

Note: Please pull the latest update from the original repository.

@StoneT2000
Copy link
Member

lgtm, thanks for your contribution!

@StoneT2000 StoneT2000 changed the title add G1 robot [Feature] add G1 robot Jul 17, 2024
@StoneT2000 StoneT2000 merged commit 73fa607 into haosulab:main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants