Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSE 276F Submission] PlaceSphere-v1 #379

Merged
merged 10 commits into from
Jun 14, 2024
Merged

Conversation

astonastonaston
Copy link
Contributor

@astonastonaston astonastonaston commented Jun 12, 2024

The task involves grasping a sphere and placing that on top of a little bin. The task is solvable via ppo in 5000_0000 epochs.

Training command: python ppo.py --env_id="PlaceSphere-v1" --num_envs=1024 --update_epochs=8 --num_minibatches=32 --total_timesteps=50_000_000

Evaluation command: python ppo.py --env_id="PlaceSphere-v1" --evaluate --checkpoint=/path_to_final_ckpt.pt --num_eval_envs=1 --num-eval-steps=1000 --seed=2

Evaluation results:
eval_success_rate=0.8478260869565217

@astonastonaston astonastonaston changed the title [CSE 276F Submission] PlaceSphere [CSE 276F Submission] PlaceSphere-v1 Jun 12, 2024
@StoneT2000 StoneT2000 self-assigned this Jun 13, 2024
@StoneT2000
Copy link
Member

Work looks good. Just resolve conflicts with main and see my comments. Can confirm RL works as well.

@astonastonaston
Copy link
Contributor Author

Conflicts resolved. I re-structured a bit and hopefully I didn't make their RollBall docs wrong.

@StoneT2000
Copy link
Member

Conflicts resolved. I re-structured a bit and hopefully I didn't make their RollBall docs wrong.

Still missing fixes for the 2 reviewed parts. see comments above

@astonastonaston
Copy link
Contributor Author

astonastonaston commented Jun 14, 2024

Conflicts resolved. I re-structured a bit and hopefully I didn't make their RollBall docs wrong.

Still missing fixes for the 2 reviewed parts. see comments above

I can't see any comment or required change in the code... Could you specify where they are?

@StoneT2000 StoneT2000 self-requested a review June 14, 2024 05:09
mani_skill/envs/tasks/tabletop/place_sphere.py Outdated Show resolved Hide resolved
mani_skill/envs/tasks/tabletop/place_sphere.py Outdated Show resolved Hide resolved
@astonastonaston
Copy link
Contributor Author

Okay now the 2 parts are fixed

@StoneT2000 StoneT2000 self-requested a review June 14, 2024 07:15
@StoneT2000 StoneT2000 merged commit 999ec86 into haosulab:main Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants