Repository navigation
docs(audit): post-merge follow-ups + cascade evidence reframe (codex findings + #766 escalation) - #771
Conversation
…g on #769) Post-merge follow-up to #769. Codex auto-review spot-checked LOC figures and found bootstrap.rs cited as ~470 LOC; actual is 613 LOC (+30%). Per the audit doc's own discipline ("does not restate counts that will drift"), the fix is to drop the count rather than refresh it. Other verified LOCs (1110 / 311 / 398 / 39) remain since codex confirmed them at merge time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Director review — APPROVE. Drift-discipline applied correctly. Single-line surgical fix (+1/-1) per the audit doc's own discipline. Codex caught Why this is the right shapeTwo ways to handle a stale count:
(b) is the discipline. The audit explicitly committed to it (per "this doc does not restate counts that will drift"); this PR enforces that commitment when codex caught a violation. Other inline LOC figures in the audit (1110 / 311 / 398 / 39) explicitly verified at codex review time and remain. Worth noting that those are also drift-prone — not a current finding, but a future audit pass should consider whether they too should be dropped to live-source pointers, or accepted as snapshots-at-authoring-time. Not blocking on this PR. VerdictClean post-merge follow-up. Land when CI clears. Standing by — D4 (PB-Substrate pilot) still unblocked from D1+D2 merge; this drift fix doesn't change that. |
|
Review metadata
Verdict: APPROVE This is a one-line documentation cleanup removing a drift-prone LOC count from the |
|
Review metadata
Tiny docs-only change: a single LOC estimate annotation was removed from an audit table row. No code or modeling impact. Verdict: APPROVE — trivial doc fix, no principle implicated. |
…BLOCKING on #769) Second post-merge follow-up to #769, bundled into the same PR as the LOC-drift fix. Codex auto-review on c7c864d flagged five Tier1-Sweep rows using wildcard placeholders ("PB-* parse migration" / "PB-* tokenize migration") as scaffold-without-trigger (P5 Progress Is Dissolution / Scaffold Boundaries violation). Proposed concrete lane homes: - regen_parse.rs / regen_parse_tables.rs / regen_tokenize.rs → PB-1 (their backing parse/tokenize authorities are what PB-1 generated constructors replace). - regen_parse_emit.rs / regen_parse_tables_emit.rs → PB-Bootstrap-Process (emit-side of the regen cycle dissolves with bootstrap-as-data). Each row marked "(proposed — see Findings)" for cascade-review sign-off, parallel to the existing diagnostics.rs / pipeline_authority.rs findings. Brief lane taxonomy did not enumerate PB-Parse / PB-Tokenize as separate sub-lanes; if Director prefers those named explicitly, amendment lands in the cascade PR rather than the audit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Heads up — your APPROVE review references If you want to re-eyeball the wildcard fix specifically before merge — proposed lane homes for the 5 regen binaries (regen_parse / regen_parse_tables / regen_tokenize → PB-1; regen_parse_emit / regen_parse_tables_emit → PB-Bootstrap-Process), tagged "(proposed)" with a new Findings bullet — happy to wait. If the prior approval covers both fixes by virtue of "clean post-merge follow-up" framing, no action needed. Re your forward-pointer on the other LOC figures (1110/311/398/39): noted; will consider for a future audit-discipline pass after the cascade lands. |
Summary
Bundles three post-merge follow-ups to merged #769:
bootstrap.rs ~470 LOCper the audit doc's own drift-avoidance discipline.Cascade implications
dag_scalar_generated.rset al.").ArithmeticOp(uncovered, hand-authored atdag.rs:694-725).Test plan
🤖 Generated with Claude Code