Repository navigation
docs(audit): 34-file SG-0 census audit for Zero-Floor program (file → why-hand-authored → PB-lane mapping) - #769
Conversation
… why-hand-authored → PB-lane mapping) Pre-promotion Deliverable 1 for the Pure Bootstrap to Zero design doc (docs/design-pure-bootstrap-zero.md, PROPOSAL). Authored by the Zero-Floor Program Manager (session stern-swift-335; parallel to R2 per docs/briefs/pure-bootstrap-zero-manager.md). Walks the live EXPECTED_HAND_AUTHORED_NON_TEST array (34 entries on main) and assigns each file to a PB-* migration lane with rationale for why it is currently hand-authored. Surfaces two findings flagged for cascade-review: - Live count is 34, not 35 as the brief snapshot states; refresh recommended at cascade-merge time. - diagnostics.rs and pipeline_authority.rs had no lane home in the brief taxonomy; proposes PB-Substrate and PB-Bootstrap-Process homes respectively. On the strength of substrate.dag's evaluability probe (398 LOC, TERMINAL-marked types mirroring dag.rs runtime surface), commits to PB-Substrate as the first prototyped lane closure (Pre-promotion Deliverable 4) per Director Q2 contingency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Director review — APPROVE. Pre-promotion Deliverable 1 lands clean. Audit doc at What's right
VerdictClean Pre-promotion Deliverable 1. CI 1/3 green so far; expect the rest to pass on docs-only diff. This unblocks Deliverables 2 (PB-1 brief amendment) and 4 (first prototyped lane closure on PB-Substrate). Deliverable 3 (TESTING.md rewrite) remains Director-call on authoring per design doc. Standing by for the next deliverable; you can dispatch in either order since 2 and 4 are independent of each other (modulo manager bandwidth). |
|
Approval received, thanks. CI status: Will hold PB-Substrate pilot (Deliverable 4) execution start until #769 + #770 merge to avoid rebase churn against the |
|
Review metadata
Pure docs addition — one new file, I spot-checked the factual claims against the tree:
Findings
Verdict: APPROVE_WITH_COMMENTS — docs-only, factually well-grounded, covers the full 34-entry census with lane mapping. The one concrete nit is the Exploratory (optional)
|
|
Review metadata
Findings
Verdict: REQUEST_CHANGES. The audit is otherwise coherent, but the wildcard lane entries need explicit named lane homes or an acknowledged proposed-lane/sign-off path before this works as a durable SG-0 census deliverable. |
…BLOCKING on #769) Second post-merge follow-up to #769, bundled into the same PR as the LOC-drift fix. Codex auto-review on c7c864d flagged five Tier1-Sweep rows using wildcard placeholders ("PB-* parse migration" / "PB-* tokenize migration") as scaffold-without-trigger (P5 Progress Is Dissolution / Scaffold Boundaries violation). Proposed concrete lane homes: - regen_parse.rs / regen_parse_tables.rs / regen_tokenize.rs → PB-1 (their backing parse/tokenize authorities are what PB-1 generated constructors replace). - regen_parse_emit.rs / regen_parse_tables_emit.rs → PB-Bootstrap-Process (emit-side of the regen cycle dissolves with bootstrap-as-data). Each row marked "(proposed — see Findings)" for cascade-review sign-off, parallel to the existing diagnostics.rs / pipeline_authority.rs findings. Brief lane taxonomy did not enumerate PB-Parse / PB-Tokenize as separate sub-lanes; if Director prefers those named explicitly, amendment lands in the cascade PR rather than the audit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… placeholders) (#771) * docs(audit): drop drifted LOC count on bootstrap.rs row (codex finding on #769) Post-merge follow-up to #769. Codex auto-review spot-checked LOC figures and found bootstrap.rs cited as ~470 LOC; actual is 613 LOC (+30%). Per the audit doc's own discipline ("does not restate counts that will drift"), the fix is to drop the count rather than refresh it. Other verified LOCs (1110 / 311 / 398 / 39) remain since codex confirmed them at merge time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(audit): replace PB-* wildcards with proposed named lanes (codex BLOCKING on #769) Second post-merge follow-up to #769, bundled into the same PR as the LOC-drift fix. Codex auto-review on c7c864d flagged five Tier1-Sweep rows using wildcard placeholders ("PB-* parse migration" / "PB-* tokenize migration") as scaffold-without-trigger (P5 Progress Is Dissolution / Scaffold Boundaries violation). Proposed concrete lane homes: - regen_parse.rs / regen_parse_tables.rs / regen_tokenize.rs → PB-1 (their backing parse/tokenize authorities are what PB-1 generated constructors replace). - regen_parse_emit.rs / regen_parse_tables_emit.rs → PB-Bootstrap-Process (emit-side of the regen cycle dissolves with bootstrap-as-data). Each row marked "(proposed — see Findings)" for cascade-review sign-off, parallel to the existing diagnostics.rs / pipeline_authority.rs findings. Brief lane taxonomy did not enumerate PB-Parse / PB-Tokenize as separate sub-lanes; if Director prefers those named explicitly, amendment lands in the cascade PR rather than the audit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…eframe per #766 escalation) Third post-merge follow-up to #769, bundled into the same PR as the LOC-drift fix and wildcard-placeholder fix. Director-signed-off remediation per #766 escalation thread. Codex BLOCKING finding on withdrawn pilot brief #772 surfaced that the original audit (and the design doc's PROPOSAL framing) treated substrate generation as a future pattern needing proof. Direct verification establishes: - 26 *_generated.rs files already shipping under src/v3/compiler/src/, covering substrate/parse/tokenize/infer/ lower/diagnostics/lens/operators/types/serialize/variant_payload/ bootstrap. - dag.rs is a hybrid (substrate-shape includes at :497/:1678/:1699/ :1710 pull in dag_scalar/branch/cluster/lookup generated files). - substrate.dag coverage survey: 38 declared types, 11 already generated (CardinalityBound, LiteralBits, PortState, TypeShape, TemplateArgument, BranchPattern, Cluster, IntraClusterCall, LoopBound, MemberDescent, PayloadBinding), 27 not yet generated by the heuristic. New §"Substrate generation is already proven and shipping" surfaces the verified state and reframes the cascade evidence base from "prove the pattern via new pilot" to "characterize existing pattern as primary evidence + optional small pilot on uncovered type." PB-Substrate lane scope narrows from "build the pattern" to "extend existing pattern to 27 uncovered types + retire orchestration-kernel hand-authoring." Lane file-by-file assignments remain correct as migration targets; the original "why hand-authored" rationale cells need a future audit-discipline rewrite (out of scope for this PR). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…proven (Director-approved per #766 escalation) (#775) * docs(audit): substrate generation already proven (Director-approved reframe per #766 escalation) Third post-merge follow-up to #769, bundled into the same PR as the LOC-drift fix and wildcard-placeholder fix. Director-signed-off remediation per #766 escalation thread. Codex BLOCKING finding on withdrawn pilot brief #772 surfaced that the original audit (and the design doc's PROPOSAL framing) treated substrate generation as a future pattern needing proof. Direct verification establishes: - 26 *_generated.rs files already shipping under src/v3/compiler/src/, covering substrate/parse/tokenize/infer/ lower/diagnostics/lens/operators/types/serialize/variant_payload/ bootstrap. - dag.rs is a hybrid (substrate-shape includes at :497/:1678/:1699/ :1710 pull in dag_scalar/branch/cluster/lookup generated files). - substrate.dag coverage survey: 38 declared types, 11 already generated (CardinalityBound, LiteralBits, PortState, TypeShape, TemplateArgument, BranchPattern, Cluster, IntraClusterCall, LoopBound, MemberDescent, PayloadBinding), 27 not yet generated by the heuristic. New §"Substrate generation is already proven and shipping" surfaces the verified state and reframes the cascade evidence base from "prove the pattern via new pilot" to "characterize existing pattern as primary evidence + optional small pilot on uncovered type." PB-Substrate lane scope narrows from "build the pattern" to "extend existing pattern to 27 uncovered types + retire orchestration-kernel hand-authoring." Lane file-by-file assignments remain correct as migration targets; the original "why hand-authored" rationale cells need a future audit-discipline rewrite (out of scope for this PR). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(audit): correct generated-file count from 26 to 23 (codex finding on #775) Codex auto-review on #775 caught the count: 23 *_generated.rs files under src/v3/compiler/src/, not 26. Verified directly (matches build.rs REGEN_OUTPUTS enumeration). Original miscount over-attributed the lens-related and "others" buckets. Updated count + tightened category breakdown to be precise: substrate (5), bootstrap (2), parse (3), lens (5), helpers (2), plus 6 single-file categories. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
docs/design-pure-bootstrap-zero.md(PROPOSAL). Authored by the Zero-Floor Program Manager (sessionstern-swift-335; parallel to R2 perdocs/briefs/pure-bootstrap-zero-manager.md).docs/design-pure-bootstrap-zero-audit.mdwalks the liveEXPECTED_HAND_AUTHORED_NON_TESTarray (34 entries) and maps each file → why-currently-hand-authored → PB-* migration lane.Two findings flagged for cascade review
diagnostics.rs→ PB-Substrate (header marks "DEFERRED DISSOLUTION" pointing at v3-modeling-analysis §CompilerDiagnostic 5-field target;std/diagnostics.dagexists as 39-LOC stub).pipeline_authority.rs→ PB-Bootstrap-Process (Rust-side reader ofPipelineStageBindingdata; dissolves intobootstrap.dagworkflow when that lane lands).Lane distribution (34 files)
Substantive migration design concentrated in 16 files (47%); PB-Tier1-Sweep retires mechanically as backings land.
First prototyped lane pick (Director Q2 resolution)
substrate.dagevaluability probe: 398 LOC, TERMINAL-marked types mirroringdag.rsruntime enum surface. On that strength, Zero-Floor Manager commits to PB-Substrate as the first prototyped lane closure (Pre-promotion Deliverable 4) —dag.rs/dag/ports.rs/dag/effects.rsgenerated fromsubstrate.dagwith cementing test. Fallback to PB-1-a continuation if execution surfaces blockers, per Director's contingency note.Test plan
🤖 Generated with Claude Code