Skip to content

docs(audit): disambiguate 23 *_generated.rs glob vs 24 REGEN_OUTPUTS entries (codex follow-up on merged #775) - #777

Merged
briansrls merged 1 commit into
mainfrom
fix/audit-23-vs-24-disambiguation
Apr 25, 2026
Merged

briansrls merged 1 commit into
mainfrom
fix/audit-23-vs-24-disambiguation

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Summary

Post-merge follow-up to #775. Codex NON-BLOCKING auto-review on `089fd835` caught a precision issue: 23 `_generated.rs` glob matches vs 24 `REGEN_OUTPUTS` entries. The extra is `bootstrap_generated_without_parse_surface.rs` which does not match the `_generated.rs` suffix glob.

Reworded so the audit's "live state" claim is unambiguous and the two counts (glob match vs REGEN_OUTPUTS enumeration) are both surfaced.

Test plan

  • Doc-only diff. No code surface.

🤖 Generated with Claude Code

…775)

Codex NON-BLOCKING auto-review caught: 23 *_generated.rs glob matches
vs 24 REGEN_OUTPUTS entries. The extra is
bootstrap_generated_without_parse_surface.rs which does not match the
suffix glob. Reworded to surface both numbers explicitly so the
audit's "live state" claim is unambiguous.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls
briansrls merged commit 198e57c into main Apr 25, 2026
3 checks passed
@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: codex / codex-default
  • Commit: 4f12a0b6 · Trigger: schedule
  • Thinking: 62s wall

Verdict: APPROVE — docs-only correction is accurate: *_generated.rs glob finds 23 files, while src/v3/compiler/build.rs REGEN_OUTPUTS enumerates 24 including bootstrap_generated_without_parse_surface.rs. No invariant, coding, or testing violations observed.

@briansrls

Copy link
Copy Markdown
Contributor Author

Director review — APPROVE. Clean disambiguation per drift discipline.

Surgical fix (+4/-2): clarifies 23 *_generated.rs files (suffix glob) vs 24 REGEN_OUTPUTS entries (adds bootstrap_generated_without_parse_surface.rs which doesn't match the simple suffix glob). Codex caught the inconsistency between counts cited in the same audit section.

Why this is the right shape

Same drift discipline as #771's ~470 LOC → unspecified fix on bootstrap.rs. Audit doc is the cascade evidence base; numeric assertions need to be precise + defensible against follow-up reviewers. The "23 glob / 24 REGEN_OUTPUTS" disambiguation forecloses a future "but the count is off by one" finding without committing to either count as wrong.

Verdict: clean follow-up. Land when CI clears.

Standing by.

briansrls added a commit that referenced this pull request Apr 25, 2026
… gap (post-#780 closure of openai-pro finding) (#781)

Closes the discipline loop on openai-pro REQUEST_CHANGES surfaced
during PB-Substrate pilot v2 (#780). Worker dismissed the finding
inline as non-blocking on the strength of substrate.dag:130-160
already carrying rich per-type 🟡 SCAFFOLD annotations for the
operator-types slice. That dismissal is correct for #780 (no
information loss) but does not address the structural gap:
regen_runtime_mirrors.py propagates no annotations from substrate.dag
to the generated Rust mirror, regardless of whether substrate-side
annotations exist.

Manager call (a) per #780 thread: book the gap as tracked-debt
rather than expand pilot scope retroactively. This entry names the
dissolution trigger (PB-Substrate proper execution, on the first
slice whose rationale lives only in the retired hand-Rust block) and
the closure condition (every substrate type's authoring rationale
reachable from the generated Rust mirror). Either propagate
rationale into substrate.dag first, or extend the generator —
whichever lands first carries the closure.

Same scaffold/debt discipline pattern as #779's rationale-cell
rewrite trigger and #777's count disambiguation.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls
briansrls deleted the fix/audit-23-vs-24-disambiguation branch June 1, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant