Repository navigation
fix(test): restore imports stripped from real_ingest_test.dag by #6848 - #6944
Merged
Merged
Conversation
gunbai-bot
Bot
changed the title
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
#6944 independently restored the same imports (plus two more) that this branch had fixed. Per nimble-owl-658, the import half is now redundant - what's worth keeping is the dissolution-trigger note DESIGN §6 requires for this scaffold: the restored imports paper over resolve_transitively_with_seen's import-line-walk pool-pull weakness, and come out once pool-pull becomes reference-driven.
briansrls
added a commit
that referenced
this pull request
Jul 20, 2026
briansrls
pushed a commit
that referenced
this pull request
Jul 20, 2026
briansrls
added a commit
that referenced
this pull request
Jul 20, 2026
briansrls
pushed a commit
that referenced
this pull request
Jul 20, 2026
briansrls
added a commit
that referenced
this pull request
Jul 20, 2026
…ports (#6943) * WIP: main RED: sccache serves zero-byte probe_bin * WIP: main RED: sccache serves zero-byte probe_bin * Reduce to dissolution-trigger note only; imports match #6944 exactly #6944 independently restored the same imports (plus two more) that this branch had fixed. Per nimble-owl-658, the import half is now redundant - what's worth keeping is the dissolution-trigger note DESIGN §6 requires for this scaffold: the restored imports paper over resolve_transitively_with_seen's import-line-walk pool-pull weakness, and come out once pool-pull becomes reference-driven. * WIP: main RED: sccache serves zero-byte probe_bin * WIP: main RED: sccache serves zero-byte probe_bin * Revert accidental cli_run.rs WIP from this branch The #6939 typed_module_content_key adoption work landed here via auto-commit while in progress and is unrelated to this PR's scope (review 40323 on #6943). Restores cli_run.rs to the state approved in a05bce7; that work continues on a separate branch/PR. --------- Co-authored-by: Brian Searls <briansearls1@gmail.com>
briansrls
added a commit
that referenced
this pull request
Jul 20, 2026
…orts restored after #6848) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#6848's namespace-wave import strip removed 13 import lines from
src/v2/test/claim/program_assembly/real_ingest_test.dagwithout replacement, leaving every symbol thesource_root_ingest_gatecompiles against unresolved. This was an over-strip: sibling consumers (module_binding_host_consistency_test.dag,compiler_closure_emit_from_ingest_test.dag) still carry explicit imports for the same host-manifest and program-assembly bindings under the landed regime.Restores the deleted imports in this one file only — no resolver changes, no tree-wide import restoration.
Diagnosis
1837b39f49: sole failuresource_root_ingest_gate_passes(Bool false).dagcompile was errors inreal_ingest_test.dagonlygit diff c87d1b0d33^ c87d1b0d33 -- real_ingest_test.dagshows 1:1 mapping from deleted import lines to unresolved symbolsTest plan
claim_batch --weton the threereal_ingest_test.dagwitnesses (manifest emit + claims): all PASSclaim_batch --wet --entry src/v2/workflow/source_root_ingest_gate.dag --function source_root_ingest_gate_passes: PASS (EXIT 0, ~710s wall; peak RSS ~2.4 GiB)3578097043, im-rc -> im: Arc-backed persistent carriers (step 1 of Arc share), with perf receipt #6929 im-rc→im) — no conflicts