Skip to content

Document dissolution trigger for #6944's restored real_ingest_test imports - #6943

Merged
briansrls merged 7 commits into
mainfrom
session/snappy-wolf-323
Jul 20, 2026
Merged

briansrls merged 7 commits into
mainfrom
session/snappy-wolf-323

Conversation

@briansrls

@briansrls briansrls commented Jul 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Main-red was misdiagnosed in the originating brief as sccache serving a zero-byte cached probe_bin. That log line is a passing negative-control test (witness_zero_byte_artifact_rejected_by_execution in dag/tools/build_step_transport.dag). The real failure, ~17 minutes later in the run log, was a whole-tree typecheck break: namespace wave 1: containment-tree resolution — layered census + name-derived loader (salvage) #6848 landed src/v2/test/claim/program_assembly/real_ingest_test.dag referencing several symbols without importing them, cascading into the batch-4 gate source_root_ingest_gate_passes.
  • That import fix has since landed independently via fix(test): restore imports stripped from real_ingest_test.dag by #6848 #6944 (which restores the same imports, plus v2.std.diagnostic/v2.std.logic). This PR no longer carries the import diff — it is reduced to just the one thing fix(test): restore imports stripped from real_ingest_test.dag by #6848 #6944 didn't add: a DESIGN §6 dissolution-trigger note.
  • The restored imports are a scaffold, not a permanent fix: v1's dependency-pool pull (resolve_transitively_with_seen in src/v1/stage0/src/main.rs) walks import-line text to build the compiled set, so a same-tree provider with no import edge silently drops out of the corpus even when it's otherwise reachable. That's the actual defect class namespace wave 1: containment-tree resolution — layered census + name-derived loader (salvage) #6848 tripped over. The added data real_ingest_test_import_restoration_note names the mechanism plainly, says the imports are temporary, and gives the dissolve-at condition (pool-pull becomes reference-driven / consumer-reachability-based instead of import-line-walk-based) — so the imports don't sit there indistinguishable from ordinary ones with nobody knowing to remove them later.
  • No changes to the sccache/CARGO_BUILD_JOBS/RUSTC_WRAPPER fallback lane — that lane was never actually implicated.

Test plan

  • claim_batch --wet run of source_root_ingest_gate_passes against the real gate transport (which overlays real fixture-derived manifest data, not the stub): PASS (645371ms).
  • Diffed the file against fix(test): restore imports stripped from real_ingest_test.dag by #6848 #6944's committed version (a2ab0e0ed8) — imports are byte-identical; the only content addition is the dissolution-trigger data string.
  • No secrets staged.

Brian Searls added 4 commits July 20, 2026 18:57
# Conflicts:
#	src/v2/test/claim/program_assembly/real_ingest_test.dag
#6944 independently restored the same imports (plus two more) that this
branch had fixed. Per nimble-owl-658, the import half is now redundant
- what's worth keeping is the dissolution-trigger note DESIGN §6
requires for this scaffold: the restored imports paper over
resolve_transitively_with_seen's import-line-walk pool-pull weakness,
and come out once pool-pull becomes reference-driven.
@gunbai-bot gunbai-bot Bot changed the title main RED: sccache serves zero-byte probe_bin Document dissolution trigger for #6944's restored real_ingest_test imports Jul 20, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 20, 2026 19:57
@cursor

cursor Bot commented Jul 20, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Brian Searls added 2 commits July 20, 2026 20:10
The #6939 typed_module_content_key adoption work landed here via
auto-commit while in progress and is unrelated to this PR's scope
(review 40323 on #6943). Restores cli_run.rs to the state approved
in a05bce7; that work continues on a separate branch/PR.
@gunbai-bot

gunbai-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Fixed in 265939f. review 40323 was correct: two auto-commits (c367f64, 30bb5a6) landed in-progress #6939-adoption WIP onto this branch, mixed into what was supposed to be the dissolution-note-only diff — including a broken call to a method that doesn't exist in the tree, and comments claiming coverage that wasn't actually implemented. Reverted cli_run.rs to the exact state approved in a05bce7; the PR now touches only real_ingest_test.dag (one added data line). The #6939 adoption continues on a separate branch/PR, not here.

— sent from snappy-wolf-323

@briansrls
briansrls merged commit be9631e into main Jul 20, 2026
2 checks passed
@briansrls
briansrls deleted the session/snappy-wolf-323 branch July 20, 2026 20:36
briansrls added a commit that referenced this pull request Jul 20, 2026
…orts restored after #6848)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant