Repository navigation
Document dissolution trigger for #6944's restored real_ingest_test imports - #6943
Merged
Merged
Conversation
added 4 commits
July 20, 2026 18:57
# Conflicts: # src/v2/test/claim/program_assembly/real_ingest_test.dag
#6944 independently restored the same imports (plus two more) that this branch had fixed. Per nimble-owl-658, the import half is now redundant - what's worth keeping is the dissolution-trigger note DESIGN §6 requires for this scaffold: the restored imports paper over resolve_transitively_with_seen's import-line-walk pool-pull weakness, and come out once pool-pull becomes reference-driven.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
added 2 commits
July 20, 2026 20:10
Contributor
|
Fixed in 265939f. review 40323 was correct: two auto-commits (c367f64, 30bb5a6) landed in-progress #6939-adoption WIP onto this branch, mixed into what was supposed to be the dissolution-note-only diff — including a broken call to a method that doesn't exist in the tree, and comments claiming coverage that wasn't actually implemented. Reverted cli_run.rs to the exact state approved in a05bce7; the PR now touches only real_ingest_test.dag (one added — sent from snappy-wolf-323 |
briansrls
added a commit
that referenced
this pull request
Jul 20, 2026
…orts restored after #6848) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
probe_bin. That log line is a passing negative-control test (witness_zero_byte_artifact_rejected_by_executionindag/tools/build_step_transport.dag). The real failure, ~17 minutes later in the run log, was a whole-tree typecheck break: namespace wave 1: containment-tree resolution — layered census + name-derived loader (salvage) #6848 landedsrc/v2/test/claim/program_assembly/real_ingest_test.dagreferencing several symbols without importing them, cascading into the batch-4 gatesource_root_ingest_gate_passes.v2.std.diagnostic/v2.std.logic). This PR no longer carries the import diff — it is reduced to just the one thing fix(test): restore imports stripped from real_ingest_test.dag by #6848 #6944 didn't add: a DESIGN §6 dissolution-trigger note.resolve_transitively_with_seeninsrc/v1/stage0/src/main.rs) walks import-line text to build the compiled set, so a same-tree provider with no import edge silently drops out of the corpus even when it's otherwise reachable. That's the actual defect class namespace wave 1: containment-tree resolution — layered census + name-derived loader (salvage) #6848 tripped over. The addeddata real_ingest_test_import_restoration_notenames the mechanism plainly, says the imports are temporary, and gives the dissolve-at condition (pool-pull becomes reference-driven / consumer-reachability-based instead of import-line-walk-based) — so the imports don't sit there indistinguishable from ordinary ones with nobody knowing to remove them later.Test plan
claim_batch --wetrun ofsource_root_ingest_gate_passesagainst the real gate transport (which overlays real fixture-derived manifest data, not the stub): PASS (645371ms).a2ab0e0ed8) — imports are byte-identical; the only content addition is the dissolution-triggerdatastring.