Repository navigation
typed_module_content_key: add import term for stripped modules - #6939
Closed
gunbai-bot[bot] wants to merge 10 commits into
Closed
gunbai-bot[bot] wants to merge 10 commits into
gunbai-bot[bot] wants to merge 10 commits into
Conversation
cargo fmt --all --check reds on the single-line signature.
The debug prints and repro tests confirmed the std.access/std.effects scheduling failure is a real cycle in the reference-derived edge graph (both land in the Kahn catch-all batch despite a direct edge), not a closure-membership or ordering gap fixable locally. Escalating per the original brief's condition on touching shared census layering.
briansrls
marked this pull request as ready for review
July 20, 2026 19:25
briansrls
added a commit
that referenced
this pull request
Jul 20, 2026
…ports (#6943) * WIP: main RED: sccache serves zero-byte probe_bin * WIP: main RED: sccache serves zero-byte probe_bin * Reduce to dissolution-trigger note only; imports match #6944 exactly #6944 independently restored the same imports (plus two more) that this branch had fixed. Per nimble-owl-658, the import half is now redundant - what's worth keeping is the dissolution-trigger note DESIGN §6 requires for this scaffold: the restored imports paper over resolve_transitively_with_seen's import-line-walk pool-pull weakness, and come out once pool-pull becomes reference-driven. * WIP: main RED: sccache serves zero-byte probe_bin * WIP: main RED: sccache serves zero-byte probe_bin * Revert accidental cli_run.rs WIP from this branch The #6939 typed_module_content_key adoption work landed here via auto-commit while in progress and is unrelated to this PR's scope (review 40323 on #6943). Restores cli_run.rs to the state approved in a05bce7; that work continues on a separate branch/PR. --------- Co-authored-by: Brian Searls <briansearls1@gmail.com>
Contributor
Author
|
Closing per operator decision: owner session (neat-hawk-85) is archived, the branch conflicts with main, and the namespace lane has moved underneath it since 2026-07-20. If the typed_module_content_key import-term-for-stripped-modules content is still needed, it re-derives cheaply on current main — routing that call to nimble-owl per operator. — sent from sharp-bee-290 |
briansrls
added a commit
that referenced
this pull request
Jul 22, 2026
… re-derive) Stripped modules resolve providers via bare-name census, not declared imports; keying only on resolved_imports let a provider export-surface change serve stale typed results. Derive reference-only deps from selection_adjacency − adjacency, gate on closure membership, schedule them before dependents, and witness with reference_derived_interface_term_recomputes_stripped_dependent. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task done
briansrls
added a commit
that referenced
this pull request
Jul 22, 2026
… re-derive) (#7062) * typed-cache: fold reference-derived import term into content key (#6939 re-derive) Stripped modules resolve providers via bare-name census, not declared imports; keying only on resolved_imports let a provider export-surface change serve stale typed results. Derive reference-only deps from selection_adjacency − adjacency, gate on closure membership, schedule them before dependents, and witness with reference_derived_interface_term_recomputes_stripped_dependent. Co-authored-by: Cursor <cursoragent@cursor.com> * typed-cache: fix reference-derived schedule ordering for regen CI Regen failed because stripped modules in the import+reference schedule cycle residue (291-module antichain on ci_floor_plan) could not satisfy reference-derived interface-hash prerequisites before keying. Match schedule edges and key lookups at repo-path grain, defer within-batch ordering gaps for declared imports, and skip the reference-derived key term only for cycle-residue slots (pre-PR behavior there; acyclic closures including the RED fixture keep the new term). Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Brian Searls <briansrls@gunb.ai> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
neat-hawk-85.Pushing to
session/neat-hawk-85advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan