Repository navigation
fix(grammar): unify forward row selection onto one parameterized fold - #6837
Merged
Merged
Conversation
Extract grammar_relation_row_forward_select(rules, row_matches) as the single None/One/Many authority; repoint token-spine ingest and production-identity body-producer consumers as thin predicate call sites. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
force-pushed
the
session/cool-gull-618-forward-select-lift
branch
from
July 18, 2026 04:11
3a9c9e2 to
2ee41b1
Compare
gunbai-bot
Bot
changed the title
Contributor
|
Review 39473 — Findings: None acknowledged; no code changes required. Verified on CI floor green on run 29630152054 (build + ci pass). — sent from cool-gull-618 |
Contributor
|
Review 39476 — APPROVE acknowledged; no code changes required. Confirmed on — sent from cool-gull-618 |
briansrls
added a commit
that referenced
this pull request
Jul 18, 2026
Squash-rebase onto current main: preserve integrated strip tree + flip (e0a1019), overlay #6738 artifact-store + #6837 grammar forward-fold landings. Re-strip overlapped .dag files except main-landing substrate (grammar, fleet_intent, realization_measurement, ci_layer_roots, v1 complexity cluster) kept with imports for plan-resolve green. Restore host_build_cache_provision + body_producer_forward dropped by stale tree. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jul 18, 2026
Squash-rebase onto current main: preserve integrated strip tree + flip (e0a1019), overlay #6738 artifact-store + #6837 grammar forward-fold landings. Re-strip overlapped .dag files except main-landing substrate (grammar, fleet_intent, realization_measurement, ci_layer_roots, v1 complexity cluster) kept with imports for plan-resolve green. Restore host_build_cache_provision + body_producer_forward dropped by stale tree. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jul 18, 2026
Squash-rebase onto current main: preserve integrated strip tree + flip (e0a1019), overlay #6738 artifact-store + #6837 grammar forward-fold landings. Re-strip overlapped .dag files except main-landing substrate (grammar, fleet_intent, realization_measurement, ci_layer_roots, v1 complexity cluster) kept with imports for plan-resolve green. Restore host_build_cache_provision + body_producer_forward dropped by stale tree. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jul 18, 2026
#6611 #6612 #6613 #6622 into one draft integration branch/PR on main; atomic Wave-1 landing target; close/supersede individual strip PRs; hold draft until G1+(c) then single rebase+merge (#6640) * Wave-1 namespace import strip rebased on main @ d3ffafd (#6640). Squash-rebase onto current main: preserve integrated strip tree + flip (e0a1019), overlay #6738 artifact-store + #6837 grammar forward-fold landings. Re-strip overlapped .dag files except main-landing substrate (grammar, fleet_intent, realization_measurement, ci_layer_roots, v1 complexity cluster) kept with imports for plan-resolve green. Restore host_build_cache_provision + body_producer_forward dropped by stale tree. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(#6640): restore body-lowering authorities after import strip Rebase conflict resolution regressed loop/cost substrate symbols and bash_command_fold onto deleted extdeps.languages.bash.program. Surgical restore on stripped node.dag (content_hash stays in node_content_hash): - loop_carrier_binder_target + carrier_edges<=1 conformance wall - edge_contributes_to_cost_fold (cost lens C1 authority) - loop_edge_contributes_to_iteration_fold excludes ^loop_carrier_edge - bash_command_fold/orchestration emit tests back on bash_build path Addresses review 39510. Plan resolve green; compile-clean tail unchanged. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(#6640): review 39532 — AuthScheme, Atom discipline, ContentHash - credential_chain: drop String scheme param; pass Bearer variant to build_token - node.dag: restore atom_connective_edge_discipline wall + Hash = ContentHash - node_content_hash: route through std.content_hash atom/combine primitives Addresses review 39532 substrate findings from rebase regression. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: Namespace integration branch: collapse strip PRs #6603 #6600 #6607 #6610 * WIP: Namespace integration branch: collapse strip PRs #6603 #6600 #6607 #6610 * WIP: Namespace integration branch: collapse strip PRs #6603 #6600 #6607 #6610 * WIP: Namespace integration branch: collapse strip PRs #6603 #6600 #6607 #6610 * fix(#6640): review 39553 — restore deploy invoke name, runner slot enforcement Revert accidental gunbc_ci_deploy_run_script rename to gunbc_ci_deploy_invoke. Restore runner_slot_enforcement_from_unit_read and per-slot committed bridge; re-ground fixture_expected_cap on allocation authority and restore per-slot discriminating witnesses dropped by import strip. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(#6640): review 39553 — restore deploy release-bins witnesses Re-enroll witness_deploy_invoke_does_not_rebuild_release_bins and witness_ci_yml_deploy_job_consumes_release_bins_artifact dropped by import-strip diff. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Brian Searls <briansrls@gunb.ai> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repays the §3 debt from #6830:
grammar_relation_row_forward_select(rules, row_matches)is now the single None/One/Many fold inv2.std.grammar. Both consumers are thin predicate call sites:grammar_relation_row_forward_token_spine_selectiongrammar_relation_row_forward_production_selectionDeleted bespoke fold bodies (
*_token_spine_select_step,*_surface_identity_select_step).Test plan
gunbc compileingest + body_producer_forward closures — 0 diagnostics