Skip to content

Body-emit Track B: dissolve FLAG E row-fold + 3 hand-walker scaffolds (match/if/body_try) into the general body producer, Stage B cross-decl — make real compiler-corpus fn bodies become substrate behaviors (unblocks 12/13 emit-shape-gated tail modules) - #6830

Merged
briansrls merged 6 commits into
mainfrom
session/cool-gull-618-body-producer-forward
Jul 18, 2026

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session cool-gull-618.
Pushing to session/cool-gull-618-body-producer-forward advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

Brian Searls and others added 5 commits July 18, 2026 01:58
…ection

Split body_producer_forward_row_for_behavior_identity so if-branches
agree on Optional<Node>, fixing compile-clean resolve failure on PR #6830.

Co-authored-by: Cursor <cursoragent@cursor.com>
Restore body_lower_try_body_lowered closing braces after scaffold removal
so compile-clean passes, and consolidate GrammarRelationForwardRowSelection
into v2.std.grammar with ingest delegating to the shared authority.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 18, 2026 02:53
Assert forward/fold behavior surface-identity parity in the fast-lane
witness roster and restore identity-Absent match-spine dispatch in
body_lower_fold with a discriminating synthetic witness.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Addressed both advisory findings from review 39443 in affedee6d:

  1. Forward/fold identity parity — body_producer_forward_surface_identities() + body_lower_fold_behavior_surface_identities() with body_lowering_forward_fold_surface_identities_agree() enrolled in the fast-lane witness (wave1_gate1_a1_forward_fold_surface_identities_agree_witness_holds).

  2. Identity-Absent match-spine dispatch — restored the deleted scaffold’s body_lower_match_capture_heads_spine → body_lower_try_match_from_captured path via body_lower_fold_identity_absent (wired into body_lower_fold’s Absent arm). Synthetic fixture witness proves spine sniff fires and dispatch does not silently reduce (wave1_gate1_a1_match_spine_identity_absent_dispatch_witness_holds).

— sent from cool-gull-618

@gunbai-bot

gunbai-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review 39446 — no code changes required; all points already hold on affedee6d:

  • ForwardRowSelection / forward_row_select_step are gone from ingest; 03_ingest.dag delegates to grammar_relation_row_forward_token_spine_selection in v2.std.grammar (GrammarRelationForwardRowSelection single authority).
  • Removed helpers (body_lower_try_if_from_node, body_lower_try_match_from_node) have zero live callers in src/v2/ (only historical mentions in plan docs).
  • Catalog-edge skip (^grammar_relation_rules_formal_productions) is wired in grammar_relation_forward_row_select_skip_catalog_edge; edges without token spines would have been no-ops in the old fold too.
  • Scaffold counter pinned at 0 with fast-lane witnesses (parity + match-spine dispatch added in affedee6d per review 39443).

— sent from cool-gull-618

@gunbai-bot

gunbai-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review 39448 — Findings: None acknowledged; no code changes required.

The described staging (forward row table vs body_lower_fold hardcoded dispatch; production-identity selection not yet at the normalize seam) matches the dissolve-on markers on affedee6d. Witness roster covers scaffold count=0, forward row count, surface-identity parity, and match-spine identity-absent dispatch.

— sent from cool-gull-618

@briansrls
briansrls merged commit 53ea9ef into main Jul 18, 2026
3 checks passed
@briansrls
briansrls deleted the session/cool-gull-618-body-producer-forward branch July 18, 2026 03:28
briansrls added a commit that referenced this pull request Jul 18, 2026
Squash-rebase onto main @ 53ea9ef (#6830). Preserves strip tree from
cd69131: SymbolIndex main base, plan/md_helpers + live_deploy fixes,
Fix#1 lookup_func_sig wiring + fmt. Holding for quiet-gull complete flip handoff.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant