Skip to content

Namespace PR-5b: corpus import strip src/v2/workflow + src/v2/extdeps (delete import lines; bare refs stay; disjoint from 5a; regen if needed; dag_compile_clean_gate) - #6600

Closed
briansrls wants to merge 5 commits into
mainfrom
session/quiet-bear-77

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session quiet-bear-77.
Pushing to session/quiet-bear-77 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 14, 2026 16:58
@gunbai-bot

gunbai-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Addressed the REQUEST_CHANGES scaffold finding in 991bf3852 (builds on 62892d8ac):

  • CLI_RUN_NAMESPACE_IMPORT_SYNTHESIS_SCAFFOLD_MARKER (cli_run_namespace_import_synthesis) with §7 block listing delete-when scope (~430 LOC), receipt (rg cli_run_namespace_import_synthesis), and dissolve trigger ^migrate_when_namespace_only_resolution_lands tied to namespace-resolution-design.md terminal step 5.
  • Planning-doc cross-reference under PR-5b import-line strip (interim host bridge) in that design note.
  • Witness constant test namespace_import_synthesis_scaffold_marker_is_declared alongside the other CLI_RUN_*_SCAFFOLD_MARKER checks.

The bridge is interim hand-Rust (origin/main import replay + bare-export closure for module-graph facts / inert-lens hygiene), not token synthesis — the false-positive extdeps.diagnostic.edac { diagnostic } path was rejected in favor of main replay.

— sent from quiet-bear-77

@gunbai-bot

gunbai-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Finding 1 — restore_stripped_imports_from_main fail-open (BLOCKING): valid, fixed in 00bcf6267.

git show spawn failure or non-success now returns Err with a typed located diagnostic (namespace import restore: … §5 fail-closed) instead of silently returning import-free content. Propagates through augment_sources_with_synthesized_namespace_imports → load_sources_for_entry_with_index. Witness: restore_stripped_imports_from_main_refuses_missing_origin_main_object.

Finding 2 — strip is cosmetic / spec-without-execution: partially valid framing, addressed with witnesses.

PR-5b intent is on-disk import deletion as the forward migration artifact; compile-time main replay is an interim seed-retained bridge (scaffold + namespace-resolution-design.md PR-5b section), not namespace-only resolution itself — that lands at ^migrate_when_namespace_only_resolution_lands.

Discriminating consumers (RED if restore removed while on-disk stays stripped):

  • stripped_workflow_extdeps_on_disk_have_no_import_lines — asserts bash.dag / ci_floor_plan.dag have zero import lines on disk
  • load_sources_restores_stripped_imports_in_memory_not_on_disk — on-disk stripped, in-memory restored
  • ci_floor_plan_closure_includes_stripped_import_targets — bare-ref module-graph closure without import lines
  • restore_stripped_imports_from_main_replays_bash_imports

Finding 3 — select_homonym_export_homes heuristic: valid as interim policy, not a silent arm.

This is import-scoped homonym disambiguation until containment lookup replaces it; behavior is locked by homonym_export_homes_* tests (v2.test exclusion, v2.std preference, std-layer for dag importers). Documented under CLI_RUN_NAMESPACE_IMPORT_SYNTHESIS_SCAFFOLD_MARKER; dissolves with namespace-only resolution — not a production fallback that widens on failure.

— sent from quiet-bear-77

@gunbai-bot
gunbai-bot Bot force-pushed the session/quiet-bear-77 branch from 92d5b79 to d761565 Compare July 14, 2026 17:39
@gunbai-bot
gunbai-bot Bot marked this pull request as draft July 14, 2026 17:41
@gunbai-bot
gunbai-bot Bot force-pushed the session/quiet-bear-77 branch 4 times, most recently from 6b2eb88 to a736521 Compare July 14, 2026 20:34
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 14, 2026 21:43
Brian Searls and others added 4 commits July 14, 2026 21:44
Host bridge restores stripped import blocks from origin/main at load,
module-graph scan, and resolve (fail-closed). Expand synthesized import
targets into resolve closure; scrub false-positive module-line diffs for
affected-set attribution. Rebased onto main (scope: workflow/extdeps strip
+ cli_run bridge only).

Co-authored-by: Cursor <cursoragent@cursor.com>
Merge 21da4af dropped Srv3InstallDiagnosticObserve and
OsInstallActuatorToolchainEnsure HostEffect match arms added by main

Co-authored-by: Cursor <cursoragent@cursor.com>
#6587/#6625, breaking compile-clean on the non-exhaustive match.
@gunbai-bot
gunbai-bot Bot marked this pull request as draft July 14, 2026 21:47
@gunbai-bot
gunbai-bot Bot force-pushed the session/quiet-bear-77 branch from a9c757e to 6d60927 Compare July 14, 2026 21:50
@briansrls
briansrls marked this pull request as ready for review July 14, 2026 22:11
@gunbai-bot

gunbai-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Superseded by integration collapse PR #6640 (session/still-owl-689, work item adhoc-2ace4fe2-aad). Strip diff folded into single Wave-1 landing branch; individual lane PR closed per coordinator ruling.

@gunbai-bot

gunbai-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Superseded by integration PR #6640 (session/still-owl-689). Strip content collapsed into atomic Wave-1 landing target; hold draft until G1+(c). — still-owl-689

briansrls added a commit that referenced this pull request Jul 15, 2026
…nt main.

Re-apply atomic strip from collapsed PRs #6603 #6600 #6607 #6610 #6611
#6612 #6613 #6622 after remote branch was reset to main. Includes G1
symbol_index resolve, global_bare census expansion, and stage0 bootstrap
sync. CI floor expected-red until Wave-0 (c) homonym qualify lands.

Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls added a commit that referenced this pull request Jul 15, 2026
…nt main.

Re-apply atomic strip from collapsed PRs #6603 #6600 #6607 #6610 #6611
symbol_index resolve, global_bare census expansion, and stage0 bootstrap
sync. CI floor expected-red until Wave-0 (c) homonym qualify lands.

Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls added a commit that referenced this pull request Jul 15, 2026
…nt main.

Re-apply atomic strip from collapsed PRs #6603 #6600 #6607 #6610 #6611
symbol_index resolve, global_bare census expansion, and stage0 bootstrap
sync. CI floor expected-red until Wave-0 (c) homonym qualify lands.

Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls added a commit that referenced this pull request Jul 15, 2026
…nt main.

Re-apply atomic strip from collapsed PRs #6603 #6600 #6607 #6610 #6611
symbol_index resolve, global_bare census expansion, and stage0 bootstrap
sync. CI floor expected-red until Wave-0 (c) homonym qualify lands.

Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls added a commit that referenced this pull request Jul 15, 2026
…nt main.

Re-apply atomic strip from collapsed PRs #6603 #6600 #6607 #6610 #6611
symbol_index resolve, global_bare census expansion, and stage0 bootstrap
sync. CI floor expected-red until Wave-0 (c) homonym qualify lands.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant