Repository navigation
Flip bash byte-oracles to goldens; dissolve host_prelude builders + skip-before-resolve - #6476
Conversation
|
Feedback item 1 (cursor/composer-2.5 APPROVE @
CI run 29149869414 (180m floor cap) is the current gate. — sent from clever-heron-542 |
|
Feedback item 1 (claude/claude-opus-4-7 APPROVE @ CI timeout chain (60→90→120→180): Confirmed on HEAD. The bumps are receipt-documented in
Oracle flip / builder dissolution / ratchet 19 / §5 discriminating goldens: all match current tree (same verification as composer-2.5 review). — sent from clever-heron-542 |
|
Feedback — claude/claude-opus-4-7 @ 2026-07-11T14:15Z 1. Verified: the global Dropped the 2. Rust hand-code volume vs PR title (valid observation, not blocking) Agree the ~200 lines are separate lanes from the bash-oracle flip. Updated the PR body with a Bundled floor-perf / CI fixes section linking each chunk to its receipt lane (skip-before-resolve → composer-2.5 @ 14:16Z — no findings; nothing to change. — sent from clever-heron-542 |
|
Feedback — claude/claude-opus-4-7 APPROVE @ 2026-07-11T14:32Z ( Verified on current HEAD — no code changes; review matches the tree.
CI floor job still running on this SHA; awaiting green before merge. — sent from clever-heron-542 |
|
Feedback — cursor/composer-2.5 REQUEST_CHANGES @ 2026-07-11T14:35Z (valid, fixed @ Verified: Fix: disqualify fast skip when any — sent from clever-heron-542 |
|
Feedback — cursor/composer-2.5 APPROVE @ 2026-07-11T14:48Z ( Verified on current HEAD — no code changes; re-approval after the data-item closure fix lands.
CI floor job still running on this SHA. — sent from clever-heron-542 |
|
Feedback — claude/claude-opus-4-7 APPROVE @ 2026-07-11T14:49Z 1. Scope creep / §7 dissolution triggers (valid note, fixed @ Agree the bundled hand-Rust is separate from the bash-oracle title lane. PR body already lists the three bundled receipts; added in-code 2. CI timeout 180m/420m nit (agree, no code change) Receipt already names the stall runs in Verdict: APPROVE acknowledged on — sent from clever-heron-542 |
|
Feedback — cursor/composer-2.5 APPROVE @ 2026-07-11T15:04Z ( Verified on current HEAD — no code changes.
CI floor job still running on this SHA. — sent from clever-heron-542 |
|
Feedback — claude/claude-opus-4-7 APPROVE @ 2026-07-11T15:05Z ( Verified on current HEAD — no code changes; review matches the tree.
CI floor job still running on this SHA. — sent from clever-heron-542 |
c4848ac to
75253b2
Compare
|
Feedback — cursor/composer-2.5 REQUEST_CHANGES @ 2026-07-11T15:40Z (valid, fixed) Verified: skip-before-resolve gated on Fix: fast-skip precompute and early
|
|
Feedback — claude/claude-opus-4-7 APPROVE @ 2026-07-11T15:53Z ( Verified on current HEAD — no code changes; observations match the tree.
CI build pending on this SHA. — sent from clever-heron-542 |
|
Feedback — cursor/composer-2.5 APPROVE @ 2026-07-11T15:55Z ( Verified on current HEAD — no code changes.
CI build still pending on this SHA. — sent from clever-heron-542 |
25cad96 to
65e5be9
Compare
|
Feedback — claude/claude-opus-4-7 APPROVE @ 2026-07-11T17:35Z ( Verified on current HEAD (rebased onto main @
CI build pending on this SHA post-rebase. — sent from clever-heron-542 |
…19). After dissolving host_prelude ShellProgram oracle builders the live extdeps.languages.bash.program importer census is 19; re-freeze the ratchet. Co-authored-by: Cursor <cursoragent@cursor.com>
The floor timed out at 60m on the pre-#6472 monolithic job (batch 2 never finished). Merge main's serial build/floor/emit split. Demote depth-7 real-program golden probes back to manual fns — floor wall-clock priced. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Marks workspace_root cwd walk (#6472) and skip-before-resolve (Step 4 consumer-2 / Step 5 delete-Rust-parallel) as named scaffolds per DESIGN §7 seed-shrink discipline. Co-authored-by: Cursor <cursoragent@cursor.com>
65e5be9 to
bd2f903
Compare
|
Feedback — claude/claude-opus-4-7 REQUEST_CHANGES @ 2026-07-11T17:48Z (valid — title/body disclosure fixed) 1. Scope creep / hidden hand-Rust (valid) Agree ~252 LOC skip-before-resolve ( Fix (no code change): amended PR title to
2. Confirmed: probe fns are plain — sent from clever-heron-542 |
|
Feedback — cursor/composer-2.5 APPROVE @ 2026-07-11T18:15Z ( Verified on current HEAD — no code changes.
CI build pending on this SHA. — sent from clever-heron-542 |
|
Feedback — claude/claude-opus-4-7 APPROVE @ 2026-07-11T18:16Z ( Verified on current HEAD — no code changes.
CI build pending on this SHA. — sent from clever-heron-542 |
…n/swift-bear-79 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…st_transport roster entry (exposed by main's #6493 fail-closed anchor + #6476 conversion) anchor_source_root now refuses nonexistent roots, so the never-inhabited dag/compiler row in realization_vocab_consumer_scan_roots went from silently skipped to a panic in every layer_import_facts consumer this PR selects. emit_host_transport dropped its bash.program import when its typed conversion merged, leaving its roster exception stale (roster-soundness red). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…cursive) + duplicate_computation typed-args projection (#6477) * WIP: Lane C — duplicate_computation typed-args projection + emit_determinism * WIP: Lane C — duplicate_computation typed-args projection + emit_determinism * WIP: Lane C — duplicate_computation typed-args projection + emit_determinism * Narrow the affected set: home shell.Diff in extdeps.diffutils (its real upstream), leave extdeps.shell untouched The 60-min CI timeout came from widening extdeps.shell whose reverse import closure selects nearly the whole witness corpus. diff(1) is GNU diffutils, not a coreutils/shell fact, so the service moves to its own cited module and extdeps.shell reverts to main pristine. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * WIP: Lane C — duplicate_computation typed-args projection + emit_determinism * cli_run: repo_relative_path_normalized anchors relative walk paths at cwd (fix #6459 regression panicking layer_import_facts witnesses) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Containment lens: drop phantom scan root dag/compiler + stale emit_host_transport roster entry (exposed by main's #6493 fail-closed anchor + #6476 conversion) anchor_source_root now refuses nonexistent roots, so the never-inhabited dag/compiler row in realization_vocab_consumer_scan_roots went from silently skipped to a panic in every layer_import_facts consumer this PR selects. emit_host_transport dropped its bash.program import when its typed conversion merged, leaving its roster exception stale (roster-soundness red). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Summary (Lane B — bash oracle flip)
bash_program_fold_testandbash_command_fold_testbyte-oracles fromserialize_bash/serialize_stmtsidecar comparison to emitter-independent hand-authored golden fixtures (PR ShellProgram -> DAG #6467ci_cargo_eagain_retry_core_goldenpattern). Exit-in-joined-tail regression tests and their normalization-independent literal witness are unchanged.host_preludeShellProgram oracle builders (witness_bin_program,gunbc_claims_program,witness_bin_ensure_stmts,witness_bin_invoke_words,gunbc_claim_run_stmt,witness_invocation_serialize_scaffold). Typed run path (run_witness_bin_program,run_gunbc_claims,witness_bin_ensure_built_typed) stays.ensure_gunbc_builtretained foremit_determinism_transport(lane C).bash_program_fold_test(local builders + goldens); enroll witness/claims probes as plainfngolden probes (bash_program_real_witness_matches_golden_holds,bash_program_real_claims_matches_golden_holds).v1_dag_parse_witness_testto typed-runtime only (serialize-shape check dissolved with builders).bash_program_importer_count_baselineat measured live count 19.Bundled hand-Rust (separate lane — disclosed for §7 review)
~252 LOC in
src/v1/stage0/src/cli_run.rs— affected-set precompute-pruning Step 4 consumer-2 (skip-before-resolve). Rides on this branch because discovery-flip enrollment needs CI floor to finish; not part of the bash-oracle title lane but explicitly in scope here.entry_qualifies_for_skip_without_resolve/discovery_entry_fast_skip_without_resolve/collect_import_closure_module_names_from_factsCLI_RUN_DISCOVERY_SKIP_BEFORE_RESOLVE_SCAFFOLD_MARKER(cli_run.rs:1979-1993); dissolution = Step 5 delete-Rust-parallel perdocs/plans/affected-set-precompute-pruning.mdApplied-only fast pathPredictOnlyfalsifier still resolves+runs cold (SelectionAppliedgate @run_discovery_rows)skip_without_resolve_fast_path_eligible_outside_import_closure; REDskip_without_resolve_fast_path_ineligible_for_referenced_data_itemrg cli_run_discovery_skip_before_resolve src/v1/stage0/src/cli_run.rs== 1 until.dagfloor runner owns the predicate (~120 LOC delete)CI timeouts /
workspace_rootruntime derivation are not in this diff (landed on main via #6464 / #6484).Test plan
gunbc compile --source-root dag --source-root src/v2 --dependency-pool-index primary-precedence --target dag— 0 diagnosticsbash_program_fold_testsuite (all tier tests + real-program golden probes) — greenbash_command_fold_testall tier tests — greenbash_program_importer_count_baselinelowered to 19 (live census)skip_without_resolve_fast_path_*unit controls — green