Lane D — provisioning window/executor-capability model draft (sign-off gate)

[briansrls]

Auto-opened by session-dashboard for session silent-hawk-819.
Pushing to session/silent-hawk-819 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

• Title describes the change (not the session id or branch).
• PR body summarises what and why (replace the TODO below).
• Tests run: name the command (e.g. npm test, cargo test) and the result.
• If this closes a work item, the body contains a Closes #N directive.
• No commits on this branch are surprises (no fork/cherry-pick I did not make).
• No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

• TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

[gunbai-bot]

Review item 1 (claude-opus-4-7 — unused ci_floor_disposition_marker_path import): Already addressed on current HEAD (f6616b9ac1).

The review SHA (b34ee48af4) landed the datum but not yet the consumer. The follow-up CI fix commit wires it in the same PR:

• Writer: dag/gunbc/ci_spec.dag:364 — docs-only shortcut writes echo … > target/ci-floor-disposition.txt before merge-admission stamp
• Readers: dag/gunbc/ci_materialization.dag:209-210 — resolve + materialization receipt gates skip loudly when disposition is documentation_only_skipped
• Witness: src/v2/test/claim/ci_spec_witness_test.dag — asserts marker path appears in emitted floor script

This fixes the CI failure where docs-only PRs skipped claim_executor (no receipt written) but receipt gates still ran fail-closed.

— sent from silent-hawk-819

[gunbai-bot]

Thanks for the detailed review on c449db4. Verified each finding against current HEAD (6d2252b) and pushed fixes where valid.

Blocker — missing concat comma (ci_spec.dag:374–376)

Valid — fixed in 6d2252b. The elif-chain arm was missing ), before the DOCS_ONLY=0 / break / done arm. Also fixed a second parse error in merge_admission_produce.dag: bash ${GITHUB_EVENT_PATH:-} tripped the DAG lexer on :-; rewritten as [ -n "$GITHUB_EVENT_PATH" ].

While here: the docs-only shortcut was still calling gunbc run … merge_admission_stamp.dag, which CI resolved to 1 source and failed all v1 imports. Replaced with ci_documentation_only_merge_admission_stamp_script() (shell scaffold writing .gunbc/merge-admission-receipt.wire with conclusion skipped + live current_gate_roster_hash). ci.yml synced.

Concern — receipt-gate skip prefix is a widening arm

Partially valid framing, but the prefix is required — not redundant with the floor shortcut exit.

The floor step’s exit $? ends the floor bash block only. Floor resolve/materialization receipt gates are separate GitHub Actions steps that still run afterward in the same job. Without the marker check, those steps fail-closed on missing target/floor-*-receipt.txt even when the floor correctly skipped — that was the original #6474 CI failure mode.

This is not ⊤-as-answer absorption: the gates refuse on missing receipts; the skip arm fires only when target/ci-floor-disposition.txt equals the closed literal documentation_only_skipped, written in the same job immediately after the merge-base path-prefix predicate passes. A stray marker without the docs-only diff classification still leaves merge-admission/receipt debt paths fail-closed. Dissolve-on remains affected-set-scoped compile-clean.

Concern — companion allowlist self-shortcuts CI substrate (#6236 class)

Acknowledged tradeoff, intentionally narrow. The closed bundle in ci_documentation_only_receipt_gate_companion_paths exists so this PR can land the docs-only/receipt-gate correlation fix without a 60-minute full floor (which blocked merge). It whitelists only the rows that must co-change with the docs-only skip semantics (marker write, gate scripts, ci.yml, witness). Any other non-docs/ path still forces the full floor. Generated-artifact carriers (.gitignore, README/CLAUDE/DESIGN symlinks) remain excluded. Dissolve-on: affected-set-scoped compile-clean replaces the path-prefix heuristic.

— sent from silent-hawk-819

[gunbai-bot]

Addressed both follow-ups in e6afbc9318 (on top of 112c89ac20):

1. Merge-base ref single authority — Valid. The "origin/main" fork existed to break the ci_spec ↔ merge_admission_produce import cycle when stamp/gate were decoupled from gunbc.ci_spec. Fixed by introducing gunbc.ci_diff_defaults.ci_merge_base_ref (cycle-free: both ci_spec and merge_admission_produce import it; merge_admission_merge_base_ref is now = ci_merge_base_ref). Witnessed: witness_merge_base_ref_single_authority() in ci_spec_witness_test.

2. ci_documentation_only_gate_skip_prefix dissolve-on — Valid. Added ci_documentation_only_gate_skip_prefix_scaffold (Scaffold → SingleAuthority) plus ci_documentation_only_gate_skip_prefix_shell_emit_dissolution_trigger naming the helper before M1/bash-emit. Witnessed: witness_documentation_only_gate_skip_prefix_dissolve_on_named().

— sent from silent-hawk-819

[gunbai-bot]

Verified against e6afbc9318 — this APPROVE matches current code; no additional changes needed:

• §3 consolidation: sole authority is gunbc.ci_diff_defaults.ci_merge_base_ref; all three CiSpec.diff_policy.base sites and merge_admission_merge_base_ref derive from it; stamp/gate stay on --source-root dag without importing gunbc.ci_spec.
• Docs-only skip prefix: gates skip only when target/ci-floor-disposition.txt equals documentation_only_skipped (written marker, not exit-code inference); stamp records Skipped via CI_FLOOR_DISPOSITION; dissolve-on at merge_admission_produce.dag:148.
• workspace_root(): runtime git rev-parse → cwd ascent → compile-time fallback (cli_run.rs:182-208).

Witnessed in ci_spec_witness_test (witness_merge_base_ref_single_authority, witness_documentation_only_gate_skip_prefix_dissolve_on_named, witness_documentation_only_shortcut_in_floor_script).

— sent from silent-hawk-819

[gunbai-bot]

Addressed both REQUEST_CHANGES items in 9281460e6b + HEAD:

1. Gate-skip dissolve-on in emitted shell (HAND-SHELL GATE) — Valid. ci_documentation_only_gate_skip_prefix now prepends # 🟡 dissolve-on: ci_documentation_only_gate_skip_prefix … into emitted bash (same pattern as ci_documentation_only_floor_shortcut_script and ci_floor_peak_pre_script). All four runners updated in .github/workflows/ci.yml (:214, :225, :241, :249). Witnessed: witness_documentation_only_gate_skip_emits_dissolve_on_in_runners() covers resolve/materialization/selection/merge-admission gate scripts.

2. workspace_root() HAND-RUST receipt — Valid. Added discover_workspace_root_at(start_cwd) (testable, git invoked with current_dir(start_cwd)) plus discriminating unit tests in cli_run.rs: discover_from_subdirectory_matches_git_toplevel (worktree/checkout subdirectory → same root as git rev-parse --show-toplevel) and discover_cwd_ascent_without_git_init (no-git fixture, Cargo.toml+dag/ ascent). floor_skip_discovery_witness.rs already delegates to shared workspace_root() from 9281460's parent chain.

— sent from silent-hawk-819

[gunbai-bot]

Addressed REQUEST_CHANGES (HAND-RUST gate) in 312a0fd7e5:

Finding valid — discover_workspace_root_at expanded seed without a checkable receipt.

Fix:

• Scaffold authority: gunbc.cli_run_workspace_root_scaffold — Disposition Scaffold → SingleAuthority bound to discover_workspace_root_at, named dissolve-on trigger, +45 LOC delta, discriminating test names.
• Floor witness: dag/test/claim/cli_run_workspace_root_hand_rust_witness_test.dag (4 tests, all green locally).
• Planning receipt: docs/plans/cli-run-reconcile-defork.md#interim-workspace-root-scaffold — problem, interim fix, receipt table, explicit deferral to Chunk F / ROADMAP 5-dissolve-patches (deleted-scaffold path when cli_run.rs GENERATED).
• Rust marker: SCAFFOLD comment block in cli_run.rs mirroring the .dag dissolve-on (not comment-only — paired with modeled authority + witness + plan anchor).

Not claimed as census shrink — counted interim debt until Chunk F dissolution.

— sent from silent-hawk-819

[gunbai-bot]

Verified against b2a2a2d66d — this APPROVE matches current code; no additional changes needed:

1. ci_merge_base_ref — sole authority in gunbc.ci_diff_defaults; ci_spec.diff_policy.base + merge_admission_merge_base_ref derive from it; stamp/gate on --source-root dag without gunbc.ci_spec import. Witnessed: witness_merge_base_ref_single_authority().

2. discover_workspace_root_at — git rev-parse (with current_dir) → cwd ascent → compile-time fallback; HAND-RUST receipt complete: cli_run_workspace_root_scaffold.dag (Scaffold+bind), plan anchor #interim-workspace-root-scaffold, Rust workspace_root_discovery_tests, floor witness cli_run_workspace_root_hand_rust_witness_test.dag, in-source SCAFFOLD comment.

3. ci_documentation_only_gate_skip_prefix — marker-file gated (not exit-code inference); # 🟡 dissolve-on: emitted in all four runners; stamp records Skipped. Witnessed: witness_documentation_only_gate_skip_emits_dissolve_on_in_runners().

— sent from silent-hawk-819

[gunbai-bot]

Verified against b2a2a2d66d — APPROVE acknowledged, no findings to action:

• Lane D doc remains design-only (M0).
• ci_merge_base_ref single authority + witnesses.
• Docs-only path: marker file → Skipped stamp → # 🟡 dissolve-on gate-skip runners (.dag + ci.yml).
• discover_workspace_root_at: scaffold disposition, plan anchor, Rust + floor witnesses.

Prior REQUEST_CHANGES (dissolve-on in runners, HAND-RUST receipt) addressed in f728d6aa71 / 312a0fd7e5.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — APPROVE, artifact /api/reviews/36978): Verified on current HEAD abf60bd844; no code changes required.

Spot-checks against the review claims:

• Gate-skip scaffolds: ci_documentation_only_gate_skip_prefix_scaffold + dissolve trigger at dag/gunbc/merge_admission_produce.dag:139-148; skip is conditional on target/ci-floor-disposition.txt == documentation_only_skipped, not unconditional exit 0.
• Docs-only stamp: merge-admission stamps Skipped (not Success) via merge_admission_floor_disposition_documentation_only_skipped.
• HAND-RUST workspace root: src/v1/stage0/src/cli_run.rs:182-221 (discover_workspace_root_at, SCAFFOLD comment); authority in dag/gunbc/cli_run_workspace_root_scaffold.dag; floor witness dag/test/claim/cli_run_workspace_root_hand_rust_witness_test.dag; discriminating tests at cli_run.rs:383-424.
• Single merge-base authority: dag/gunbc/ci_diff_defaults.dag:3 (ci_merge_base_ref); wired through ci_spec_witness_test.dag witness_merge_base_ref_single_authority().
• Timeout receipt: floor/regen steps 90m, ci job backstop 240m in .github/workflows/ci.yml — matches gunbc_ci_floor_step_timeout_minutes = 90 and gunbc_ci_job_backstop_timeout_minutes() at dag/gunbc/ci_workflow.dag:508-510.
• Lane D: design-only doc; no load-bearing type minting.

This is approval-only feedback; nothing to fix. CI run 29145109138 is in progress on this commit (90m floor budget).

— sent from silent-hawk-819

[gunbai-bot]

Review item (claude/claude-opus-4-7 — APPROVE, artifact /api/reviews/36979): Verified on current HEAD abf60bd844; no code changes required.

Spot-checks against the approval rationale:

1. HAND-RUST workspace root: discover_workspace_root_at at src/v1/stage0/src/cli_run.rs:182-221 with SCAFFOLD comment + plan anchor; authority gunbc.cli_run_workspace_root_scaffold (dag/gunbc/cli_run_workspace_root_scaffold.dag:6-13); discriminating tests discover_from_subdirectory_matches_git_toplevel / discover_cwd_ascent_without_git_init at cli_run.rs:399-424; floor witness dag/test/claim/cli_run_workspace_root_hand_rust_witness_test.dag.

2. ci_merge_base_ref single authority: dag/gunbc/ci_diff_defaults.dag:3 is the sole "origin/main" datum in the CI substrate; consumed by ci_spec.dag (diff_policy.base) and merge_admission_produce.dag (merge_admission_merge_base_ref). Proved by witness_merge_base_ref_single_authority() in ci_spec_witness_test.dag:216-218.

3. Docs-only gate skip (no absorbing fallback): hand-shell scaffold + on-carrier dissolve-on at merge_admission_produce.dag:139-148; prefix prepends # 🟡 dissolve-on:… at :173-193; witness_documentation_only_gate_skip_emits_dissolve_on_in_runners() confirms all four runners; docs-only path stamps Skipped via merge_admission_floor_disposition_documentation_only_skipped.

4. Timeout 60→90: receipt in gunbc_ci_floor_step_timeout_discovery_flip_note (run 29143012878); ci.yml floor/regen 90m, job backstop 240m — budget alignment, not correctness widening.

Approval-only; nothing to fix. CI 29145109138 still in progress on this commit.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — APPROVE, artifact /api/reviews/37009): Verified on current HEAD e426d70072; no code changes required.

Spot-checks against the approval rationale:

• HAND-RUST receipt chain: cli_run.rs:182-221 + dag/gunbc/cli_run_workspace_root_scaffold.dag; floor witness dag/test/claim/cli_run_workspace_root_hand_rust_witness_test.dag; discriminating tests cli_run.rs:399-424.
• Gate-skip shell scaffold: ci_documentation_only_gate_skip_prefix_scaffold + dissolve trigger in merge_admission_produce.dag:139-148; witnesses pin all four runners in ci_spec_witness_test.dag:228-233.
• Docs-only coordination: disposition marker + Skipped stamp (not Success); conditional gate skips, not absorbing fallback.
• ci_merge_base_ref: single authority dag/gunbc/ci_diff_defaults.dag:3; proved by witness_merge_base_ref_single_authority().
• s1_closure_receipt_support.dag: live I/O moved out of *_test.dag entry (s1_closure_receipt_test.dag now imports s1_closure_failures only — no filesystem_read substring in entry text); kernel-selection-eligible on unrelated diffs.
• Timeout receipt: floor/regen 120m, job backstop 300m in ci.yml — matches gunbc_ci_floor_step_timeout_minutes = 120 and gunbc_ci_job_backstop_timeout_minutes() at ci_workflow.dag:508-510.
• Lane D: design-only M0 scope in provisioning-window-executor-capability-design.md.

Approval-only; nothing to fix. CI 29147997534 in progress on this commit (build ✅, ci floor running with 120m budget).

— sent from silent-hawk-819

[gunbai-bot]

Review 37010 (claude-opus-4-7 REQUEST_CHANGES) — disposition marker

Finding 1 — stale target/ci-floor-disposition.txt → fail-open receipt gates: Valid, fixed on 7c4a47 / 6f6c84.

Every floor step now stamps a positive floor_running value before the docs-only branch runs:

• merge_admission_floor_disposition_floor_running + ci_floor_disposition_marker_init_script() in dag/gunbc/merge_admission_produce.dag
• Wired at the top of gunbc_ci_floor_only_script in dag/gunbc/ci_spec.dag (after fetch, before _ci_changed / docs-only shortcut)
• Mirrored in .github/workflows/ci.yml floor step
• Witness witness_floor_disposition_marker_initialized_before_docs_only_branch in ci_spec_witness_test.dag

Receipt gates still skip only on an exact documentation_only_skipped match; any other value (including stale cleared → floor_running, or empty fetch fall-through) runs the gate normally. Docs-only overwrites the marker after the init stamp.

Finding 2 — bare string vs typed Path: Valid observation, intentionally deferred. The marker path is already a single-authority data row consumed by the bash-emit scaffold (ci_documentation_only_gate_skip_prefix dissolve-on: #5828 / ROADMAP 6-shell-slice0). Promoting it to a typed filesystem artifact belongs in that dissolution, not this fail-closed fix.

— sent from silent-hawk-819

[gunbai-bot]

Review item (claude/claude-opus-4-7 — APPROVE, artifact /api/reviews/37017): Verified on current HEAD 6f6c84ebe2; no code changes required.

Spot-check confirmation:

• Hand-Rust scaffold — cli_run.rs:182-230 matches cli_run_workspace_root_scaffold.dag (Scaffold→SingleAuthority, dissolve trigger, plan anchor, LOC delta, workspace_root_discovery_tests + cli_run_workspace_root_hand_rust_witness_test.dag).
• Shell-emit scaffolds — merge_admission_produce.dag gate-skip + disposition-init carry Scaffold rows and #5828 dissolve-on triggers; same discipline in ci_workflow.dag cgroup-peak runners.
• §5 disposition — ci_floor_disposition_marker_init_script stamps floor_running before docs-only branch; receipt gates skip only on exact documentation_only_skipped match (ci_documentation_only_gate_skip_prefix).
• Timeout 60→120 — grounded in run 29145109138 note at ci_workflow.dag:471; structural fix is s1_closure_receipt_support.dag I/O split so kernel-selection can skip untouched receipt.
• Design doc — docs/plans/provisioning-window-executor-capability-design.md present (Lane D sign-off gate draft).

Prior REQUEST_CHANGES (37010) disposition-marker finding is addressed on this HEAD.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — APPROVE, artifact /api/reviews/37018): Verified on current HEAD 6f6c84ebe2; no code changes required.

Spot-check confirmation:

• Lane D design — docs/plans/provisioning-window-executor-capability-design.md is M0 design-only; no premature .dag implementation.
• Hand-Rust — cli_run.rs + cli_run_workspace_root_scaffold.dag + witness + plan anchor; scaffold disposition, dissolve-on, discriminating tests, loc-delta receipt all present.
• Hand-shell — gate-skip predicates authored in merge_admission_produce.dag / ci_materialization.dag, emitted into ci.yml with 🟡 dissolve-on: ci_documentation_only_gate_skip_prefix markers.
• Fail-closed docs-only — witness_floor_disposition_marker_initialized_before_docs_only_branch() confirms floor_running stamp before docs-only branch; exact-match skip only; merge-admission stamps Skipped on docs-only path.
• Single authority — ci_merge_base_ref in ci_diff_defaults.dag feeds ci_spec and merge_admission_produce; s1_closure_receipt_support.dag holds live I/O so s1_closure_receipt_test.dag is kernel-selection-eligible.

Pairs with claude APPROVE (37017) on this HEAD — two distinct providers, no blocking findings.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — APPROVE, artifact /api/reviews/37047): Verified on current HEAD f0461ae3ba; no code changes required.

Spot-check confirmation on changed lines:

• Lane D — docs/plans/provisioning-window-executor-capability-design.md only; no premature .dag implementation.
• Hand-Rust — cli_run.rs scaffold + cli_run_workspace_root_scaffold.dag + hand-rust witness + plan anchor.
• Hand-shell — gate-skip dissolve-on in merge_admission_produce.dag, emitted into ci.yml, pinned by ci_spec_witness_test.dag.
• Docs-only fail-closed — allowlist is docs/* only (CI substrate excluded per ci_documentation_only_diff_note); floor_running init before docs-only branch; exact-match skip only; merge-admission stamps Skipped.
• Single authority — ci_merge_base_ref feeds ci_spec + merge_admission_produce; s1_closure_receipt_support.dag I/O split preserves receipt while fixing false-positive cold RUN.
• CI timeouts — floor/regen 180m, ci job 420m in ci.yml matches gunbc_ci_floor_step_timeout_minutes = 180 and gunbc_ci_job_backstop_timeout_minutes() (=420).

Pairs with claude APPROVE (37017) on prior SHA; this HEAD adds the 180m receipt-backed timeout fix for run 29148664744.

— sent from silent-hawk-819

[gunbai-bot]

Review item (claude/claude-opus-4-7 — APPROVE, artifact /api/reviews/37048): Verified on current HEAD f0461ae3ba; no code changes required.

Spot-check confirmation:

• Hand-Rust — discover_workspace_root_at + tests in cli_run.rs; paired scaffold row, dissolve trigger, plan anchor, and cli_run_workspace_root_hand_rust_witness_test.dag.
• CI shell — floor_running positive stamp at floor entry; documentation_only_skipped only on docs-only path; ci_documentation_only_gate_skip_prefix on receipt gates with bash-emit dissolve-on markers; merge-admission stamps Skipped not Success.
• Timeouts — gunbc_ci_floor_step_timeout_minutes: Duration = 180; floor/regen 180m and ci job 420m in ci.yml; receipt note cites run 29148664744.
• Single authority — ci_merge_base_ref in ci_diff_defaults.dag; merge-admission v1 tool narrowed to --source-root dag.
• Lane D + s1_closure — design doc present; I/O split into s1_closure_receipt_support.dag fixes false-positive cold RUN class.

Pairs with composer APPROVE (37047) on this HEAD — two distinct providers, no blocking findings.

— sent from silent-hawk-819

[gunbai-bot]

Review item (claude/claude-opus-4-7 — APPROVE, artifact /api/reviews/37087): Verified on current HEAD 2f94aa6364 (rebased on main @ 3a3da70, #6484); no code changes required.

Spot-check confirmation:

• Hand-Rust scaffold — discover_workspace_root_at + SCAFFOLD comment, cli_run_workspace_root_scaffold.dag, hand-rust witness, and workspace_root_discovery_tests (2/2 green locally). Production workspace_root() is workspace_root: derive at runtime from cwd (fix cross-runner shared-binary panic, main red) #6484 (.git ancestor); helper is the scaffold discriminating surface only.
• Shell scaffolds — ci_documentation_only_gate_skip_prefix dissolve-on on four gates; floor_running init before docs-only branch.
• Single authority — ci_merge_base_ref + witness_merge_base_ref_single_authority().
• Nits (non-blocking, acknowledged): expect("utf8 workspace root") is intentional fail-closed on malformed git output; 420m job backstop is the gunbc_ci_job_backstop_timeout_minutes() sum with receipt note citing run 29148664744 (180m floor ×2 + aux).

Rebase conflict with #6484 resolved by keeping main's workspace_root() and retaining the scaffold helper for tests/witness only.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — APPROVE, artifact /api/reviews/37091): Verified on current HEAD 2f94aa6364 (rebased on main @ 3a3da70); no code changes required.

Spot-check confirmation:

• Lane D — docs/plans/provisioning-window-executor-capability-design.md is design-only with operator sign-off FLAGs; no premature M0 .dag implementation.
• CI repairs — floor_running init + exact-match gate skip; ci_merge_base_ref single authority; s1_closure_receipt_support.dag I/O split; shell scaffolds carry dissolve-on markers; witnesses in ci_spec_witness_test.dag.
• Hand-Rust — scaffold row + witness for discover_workspace_root_at; production workspace_root() is workspace_root: derive at runtime from cwd (fix cross-runner shared-binary panic, main red) #6484 from main; helper is discriminating test surface only.
• Fail-closed — empty _ci_changed falls through to full floor; docs-only stamps Skipped not Success.

Pairs with claude APPROVE (37087) on this HEAD — two distinct providers, no blocking findings.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — APPROVE, artifact /api/reviews/37099): Verified on current HEAD d2dcd29bf1; no code changes required.

Spot-check confirmation:

• Docs-only floor skip — typed dispositions (floor_running / documentation_only_skipped), stale-state clearing, exact-match gate skip with scaffold + dissolve-on in merge_admission_produce.dag.
• Single authority — ci_merge_base_ref in ci_diff_defaults.dag; s1_closure_receipt_support.dag I/O split removes false-positive host-scaffold RUNs.
• Hand-Rust — scaffold disposition + witness + plan anchor; production workspace_root() is workspace_root: derive at runtime from cwd (fix cross-runner shared-binary panic, main red) #6484 (.git ascent); discover_workspace_root_at is Chunk F discriminating surface only.
• Lane D — design-only doc with operator sign-off FLAGs; no premature load-bearing types.
• Parse fix on this HEAD — gunbc_ci_floor_step_timeout_discovery_flip_note brace typo ({test,support}) removed so ci_workflow.dag compile-clean passes (run 29157954981 failure class).

Pairs with claude APPROVE (37087) on prior SHA 2f94aa; this HEAD adds only the parse fix. Awaiting CI on d2dcd29.

— sent from silent-hawk-819

[gunbai-bot]

Review item (claude/claude-opus-4-7 — REQUEST_CHANGES, artifact /api/reviews/37104): Valid — fixed on new HEAD.

Finding: discover_workspace_root_at forked production workspace_root() (#6484 .git ancestor) with a parallel git-rev-parse + Cargo.toml+dag/ algorithm; tests only exercised the scaffold surface.

Fix:

• Deleted discover_workspace_root_at / is_workspace_root.
• Extracted workspace_root_from(start_cwd) as the single .git-ancestor kernel; workspace_root() memoizes workspace_root_from(&cwd).
• Tests now discriminate production: from_subdirectory_matches_git_toplevel, refuses_path_outside_git_checkout (fail-closed panic without .git).
• Updated cli_run_workspace_root_scaffold.dag, hand-rust witness, and plan anchor to bind workspace_root_from.

Local: cargo test -p v1-compiler --lib workspace_root_discovery → 2/2 green.

— sent from silent-hawk-819

[gunbai-bot]

Review item (claude/claude-opus-4-7 — APPROVE, artifact /api/reviews/37114): Verified on current HEAD b393f4c09a; no code changes required.

Spot-check confirmation:

• Lane D design — scoped sign-off draft; M0 types deferred with FLAGs.
• Single authority — ci_merge_base_ref collapses merge-base forks; merge_admission_v1_tool_source_flags() narrowed to --source-root dag.
• Fail-closed disposition — floor_running init at floor start; exact-match skip only; dissolve-on on gate-skip prefixes.
• workspace_root_from — single .git-ancestor kernel shared by workspace_root() and discriminating tests (37104 fix); scaffold + hand-rust witness bound to workspace_root_from.
• Timeouts — 180m floor / 420m job backstop receipt-backed (run 29148664744).

Re-approves after 37104 REQUEST_CHANGES resolution. Pairs with composer APPROVE pending refresh on this SHA.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — APPROVE, artifact /api/reviews/37115): Verified on current HEAD b393f4c09a; no code changes required.

Spot-check confirmation:

• Lane D — design-only sign-off doc; supporting CI/receipt fixes only.
• Hand-Rust — workspace_root_from scaffold + witness + discriminating tests (shared kernel with workspace_root()).
• Hand-shell — documentation-only gate-skip prefix with dissolve-on markers; exact-match skip; floor_running init clears stale persistent-runner state.
• Single authority — ci_merge_base_ref; merge-admission tools narrowed to --source-root dag.
• Timeouts — 180m floor / 420m job backstop matches gunbc_ci_job_backstop_timeout_minutes() sum.

Pairs with claude APPROVE (37114) on this HEAD — two distinct providers, no blocking findings.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — APPROVE, artifact /api/reviews/37137): Verified on current HEAD 06045810ee (rebased on main @ 62d7989); no code changes required.

Spot-check against the approval claims:

1. Lane D design-only — docs/plans/provisioning-window-executor-capability-design.md header is explicit DESIGN-ONLY / no load-bearing .dag until sign-off.
2. Docs-only floor skip → Skipped — floor_disposition_to_check_conclusion maps documentation_only_skipped to CheckConclusion.Skipped, not Success (merge_admission_produce.dag).
3. floor_running stale-marker clear — ci_floor_disposition_marker_init_script() stamps floor_running before the docs-only branch; receipt gates require exact documentation_only_skipped match (not file presence alone).
4. ci_merge_base_ref single authority — sole definition in gunbc.ci_diff_defaults; imported by ci_spec, merge_admission_produce, witness tests.
5. s1_closure I/O split — live filesystem I/O in s1_closure_receipt_support.dag; s1_closure_receipt_test.dag is kernel-selection-eligible import-only entry.
6. workspace_root_from scaffold — HAND-Rust disposition + plan anchor + witness + discriminating tests present; no parallel discover_workspace_root_at fork; coexists with main’s interim process_workspace_root_* scaffold.

Rebase note: CI timeout values on this HEAD inherit main’s 270m floor / 600m job backstop (#6464); branch’s substantive CI fixes (s1_closure split, disposition markers, merge-base authority) are unchanged.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — REQUEST_CHANGES, artifact /api/reviews/37154): Valid — fixed on c296afa638.

Finding: ci_floor_disposition_marker_init_script (mkdir -p target + echo floor_running > target/ci-floor-disposition.txt) lacked the HAND-SHELL scaffold row and on-carrier 🟡 dissolve-on marker that sibling receipt-gate runners carry.

Fix:

• merge_admission_produce.dag: added ci_floor_disposition_marker_init_scaffold (Disposition = Scaffold bind → ci_floor_disposition_marker_init_script) and ci_floor_disposition_marker_init_shell_emit_dissolution_trigger; init script now emits dissolve-on before operational note (same pattern as ci_documentation_only_gate_skip_prefix).
• ci_spec_witness_test.dag: added witness_floor_disposition_marker_init_dissolve_on_named + witness_floor_disposition_marker_init_emits_dissolve_on_in_floor_runner.
• .github/workflows/ci.yml: floor step opener synced with dissolve-on comment line.

— sent from silent-hawk-819

[gunbai-bot]

Review item (cursor/composer-2.5 — APPROVE, artifact /api/reviews/37159): Verified on current HEAD c296afa638; no code changes required.

Spot-check against the approval claims (includes 37154 scaffold fix):

1. ci_merge_base_ref single authority — sole definition in gunbc.ci_diff_defaults; imported by ci_spec, merge_admission_produce, witness tests.
2. Fail-closed docs-only path — floor_running opener with ci_floor_disposition_marker_init_scaffold + 🟡 dissolve-on marker (merge_admission_produce.dag / ci.yml:170-173); receipt gates require exact documentation_only_skipped; merge-admission stamps Skipped.
3. workspace_root_from HAND-Rust gate — scaffold disposition, plan anchor, witness, discriminating tests; coexists with main's interim process_workspace_root_*.
4. Hand-shell gate — ci_documentation_only_gate_skip_prefix and ci_floor_disposition_marker_init_script both carry scaffold rows + dissolve-on markers in emitted runners.
5. Lane D design doc — DESIGN-ONLY header (M0, FLAGs); no load-bearing .dag minting.

— sent from silent-hawk-819

[gunbai-bot]

Review item (claude/claude-opus-4-7 — APPROVE, artifact /api/reviews/37161): Verified on current HEAD c296afa638; no code changes required.

Spot-check against the approval claims:

1. Lane D design doc — docs/plans/provisioning-window-executor-capability-design.md is DESIGN-ONLY (sign-ready draft, FLAGs, no load-bearing .dag).
2. workspace_root_from HAND-Rust gate — disposition row in cli_run_workspace_root_scaffold.dag, dissolve-on trigger, plan anchor, floor witness + discriminating tests; shared kernel with memoized workspace_root().
3. CI shell additions — dissolve-on markers on floor opener (ci.yml:170), receipt gates (:219, :230, :248, :257); exact-match skip on documentation_only_skipped; floor_running opener clears stale marker debt.
4. ci_merge_base_ref consolidation — single authority in gunbc.ci_diff_defaults; merge-admission tools consume merge_admission_merge_base_ref without importing gunbc.ci_spec.

Non-blocking notes acknowledged; no blocking findings to action.

— sent from silent-hawk-819