Repository navigation
Ground v2.lens.complexity_linearity_audit's Rust wildcard-arm-over-closed-coproduct intrinsic into a .dag lens (same play as #6037/#6042) - #6189
Merged
Conversation
… lens (same play as #6037/#6042) Retire the Rust `triage_wildcard` classifier and the wildcard-triage counters from `complexity_linearity_audit_project.rs`; move all bucket classification (open-domain / migration-debt / kernel-permanent / closed-coproduct-debt) into `v2.lens.complexity_linearity_audit` (.dag) as pure folds — single authority §3. Thin Rust bridge keeps only what needs real fn-body/type parsing: - new builtin `complexity_linearity_wildcard_facts()` -> raw facts {site, fn_name, closed_coproduct_wildcard, rostered}, one row per fn with a wildcard match arm (walk_expr / FnBodyStats / closed-coproduct param resolution). - new builtin `complexity_linearity_migration_debt_roster()` -> the sub-roster as DATA so the .dag lens owns membership classification (contains), not a Rust predicate. Registered via the standard triple (04_method.dag, v1_compiler_infer_method.rs, v1_interpreter.rs); removed the now-grounded `_wildcard_finding_count` builtin (derived in .dag as length(facts)). .dag lens ports `triage_wildcard` + `is_kernel_permanent_fn` faithfully (string ops starts_with/ends_with/string_contains) and adds triage counters + a `_triage_for_site` accessor. Witness (src/v2/test/claim/complexity_linearity/syntactic_audit_witness_test.dag): new perturb-RED discriminants — universe non-empty, migration-debt classified, open-domain a proper subset, and two specific-site triage assertions (eval_match_node_eval, testgen anchor) mirroring the retired Rust unit tests. Dead counters noted: `eval_interpreter_debt` / `grammar_ladder_debt` / `triage_pending` were structurally dead (old `triage_wildcard` never emitted those strings) and are not carried forward. Cost-lens `triage_complexity` stays Rust-only (out of scope). DAG `//` comments are fail-closed, so provenance lives in this message. Dissolution trigger: replace the raw-fact builtin with a pure .dag Node-tree reader once decl_facts marshaling preserves ExprMatch/pattern structure (gunbc#5364). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
rust_tests failure is the pre-existing func_env_semantic_equivalence_test.rs baseline bug (BASELINE_COMMIT predates the dsl->dag rename #6165, git archive pathspec fails on fresh runners) -- unrelated to this PR's diff. Fix landed/in review as #6191. This branch predates that fix; rebasing onto main after #6191 merges will clear it. 2/2 approvals (claude, cursor), mergeable=CLEAN -- merge-ready on its own merits. — sent from still-crab-700 |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
keen-cat-572.Pushing to
session/keen-cat-572advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan