Repository navigation
Fix func_env_semantic_equivalence_test.rs: bump baseline commit past dsl->dag rename - #6191
Merged
Merged
Conversation
Contributor
Author
|
Investigated the failing/pending checks:
No code change needed here. Given — sent from proud-eagle-315 |
6 tasks
2 of 4 tasks
briansrls
added a commit
that referenced
this pull request
Jul 3, 2026
…est module (1300 LOC, 24 tests) then delete v1 module (#6197) * WIP: Test-migration: author floor witness for v1 interp_recorded_fixture_test * Test-migration: floor witness for v1 interp_recorded_fixture (24 tests) via witness bin + shell transport; delete v1 module The recorded-fixture record -> hermetic-replay -> fail-closed lifecycle (DESIGN §5 determinism / safety axis) is a runtime host-effect mechanism, not pure logic, so a bare .dag test fn would be §5 spec-without-execution. Executing coverage lives in the interp_recorded_fixture_witness host bin (23 hermetic checks; the #[ignore] wet-only jsonplaceholder test is dropped), driven by the floor through a shell transport behind test fn interp_recorded_fixture_keystone_holds. Verified green-by-execution locally: all 23 checks pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Merge origin/main into session/keen-wolf-893: resolve host_prelude + Cargo.toml conflicts with infer_semantics witness (#6196); pick up func_env BASELINE_COMMIT fix (#6191) Both sibling test-migration witnesses (infer_semantics + interp_recorded_fixture) coexist: additive ensure_*_built fns in host_prelude.dag and additive [[bin]] entries in stage0 Cargo.toml. --------- Co-authored-by: Brian Searls <briansrls@gunb.ai> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BASELINE_COMMIT(db559b42814) predated the dsl->dag rename (rename dsl -> dag #6165), sogit archive db559b42814 dag src/v1fails with a pathspec error on any fresh clone (the tree at that commit hasdsl/, notdag/). A warm main runner hid this behind a cachedtarget/func_env_semantic_baseline_corpusdir.BASELINE_COMMITtoaeb1739ec5c(current main HEAD at time of fix, post-rename).func_env_semantic_baseline.jsonfixture viacapture_func_env_semantic_oraclerun against that commit's tree (dag+src/v1source roots).Test plan
cargo run --release -p v1-compiler --bin capture_func_env_semantic_oracleagainst the new baseline tree to recapture fingerprints.cargo test --release -p v1-compiler-tests func_env_whole_corpus_semantic_oracle_matches_pre_change_baselineon a fresh, shallow (--depth=1) remote clone with no cached baseline corpus dir — passed (1 passed; 0 failed), confirming thegit archivepathspec failure is fixed and the recaptured fixture matches.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com