Skip to content

Fix func_env_semantic_equivalence_test.rs: bump baseline commit past dsl->dag rename - #6191

Merged
briansrls merged 2 commits into
mainfrom
session/proud-eagle-315
Jul 3, 2026
Merged

briansrls merged 2 commits into
mainfrom
session/proud-eagle-315

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • BASELINE_COMMIT (db559b42814) predated the dsl->dag rename (rename dsl -> dag #6165), so git archive db559b42814 dag src/v1 fails with a pathspec error on any fresh clone (the tree at that commit has dsl/, not dag/). A warm main runner hid this behind a cached target/func_env_semantic_baseline_corpus dir.
  • Bump BASELINE_COMMIT to aeb1739ec5c (current main HEAD at time of fix, post-rename).
  • Recapture the func_env_semantic_baseline.json fixture via capture_func_env_semantic_oracle run against that commit's tree (dag + src/v1 source roots).
  • Update the doc comments in both the test and the capture binary to no longer hardcode the stale commit/rename narrative.

Test plan

  • cargo run --release -p v1-compiler --bin capture_func_env_semantic_oracle against the new baseline tree to recapture fingerprints.
  • cargo test --release -p v1-compiler-tests func_env_whole_corpus_semantic_oracle_matches_pre_change_baseline on a fresh, shallow (--depth=1) remote clone with no cached baseline corpus dir — passed (1 passed; 0 failed), confirming the git archive pathspec failure is fixed and the recaptured fixture matches.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

briansrls and others added 2 commits July 3, 2026 02:30
BASELINE_COMMIT (aeb1739) predates neither the dsl->dag rename
(#6165) — recapture the whole_corpus_semantic_oracle_snapshot fixture
against that commit's tree so the corpus/diagnostic/emit-graph
fingerprints match.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@gunbai-bot gunbai-bot Bot changed the title Fix func_env_semantic_equivalence_test.rs: BASELINE_COMMIT db559b42814 predates dsl->dag rename (#6165), git archive fails on fresh clone. Bump to a stable post-rename main commit, recapture whole_corpus_semantic_oracle_snapshot baseline fixture, verify on a FRESH clone (no cached target/func_env_se Fix func_env_semantic_equivalence_test.rs: bump baseline commit past dsl->dag rename Jul 3, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 3, 2026 02:37
@gunbai-bot

gunbai-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Investigated the failing/pending checks:

  • `deploy_dashboard_srv1` shows as `fail` in some summaries, but that's a stale entry from an earlier, superseded run (`28634604317`) that got auto-cancelled when the next push triggered a new run — it's not a real failure on the current HEAD.
  • `rust_tests` passed on the current run (`28634722261`), 5m18s — this is the check that actually exercises the fix (func_env_whole_corpus_semantic_oracle_matches_pre_change_baseline).
  • `ci` (the .dag witnesses + gates workflow) hit the job's 30-minute hard timeout and got cancelled while stuck inside batch-1 host-effects (claim_executor batch 1, a sh -c ... host-effect step), before ever reaching this PR's diff surface. Cross-checked gh run list --branch main --workflow ci: the last several pushes to main itself are also in_progress/cancelled at the same stage — this is the pre-existing "main CI timeout-blind to batch-2 witnesses" issue, not something this diff introduced (this PR touches only two .rs files and a JSON fixture, no .dag sources).

No code change needed here. Given main itself doesn't reliably clear the ci job's 30-min window right now, I won't be able to get a green ci check on this PR either — flagging that as a pre-existing infra gap rather than blocking this fix on it.

— sent from proud-eagle-315

@briansrls
briansrls merged commit ec61250 into main Jul 3, 2026
2 of 6 checks passed
@briansrls
briansrls deleted the session/proud-eagle-315 branch July 3, 2026 03:49
briansrls added a commit that referenced this pull request Jul 3, 2026
…Cargo.toml conflicts with infer_semantics witness (#6196); pick up func_env BASELINE_COMMIT fix (#6191)

Both sibling test-migration witnesses (infer_semantics + interp_recorded_fixture)
coexist: additive ensure_*_built fns in host_prelude.dag and additive [[bin]]
entries in stage0 Cargo.toml.
briansrls added a commit that referenced this pull request Jul 3, 2026
…est module (1300 LOC, 24 tests) then delete v1 module (#6197)

* WIP: Test-migration: author floor witness for v1 interp_recorded_fixture_test

* Test-migration: floor witness for v1 interp_recorded_fixture (24 tests) via witness bin + shell transport; delete v1 module

The recorded-fixture record -> hermetic-replay -> fail-closed lifecycle (DESIGN
§5 determinism / safety axis) is a runtime host-effect mechanism, not pure logic,
so a bare .dag test fn would be §5 spec-without-execution. Executing coverage
lives in the interp_recorded_fixture_witness host bin (23 hermetic checks; the
#[ignore] wet-only jsonplaceholder test is dropped), driven by the floor through
a shell transport behind test fn interp_recorded_fixture_keystone_holds. Verified
green-by-execution locally: all 23 checks pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Merge origin/main into session/keen-wolf-893: resolve host_prelude + Cargo.toml conflicts with infer_semantics witness (#6196); pick up func_env BASELINE_COMMIT fix (#6191)

Both sibling test-migration witnesses (infer_semantics + interp_recorded_fixture)
coexist: additive ensure_*_built fns in host_prelude.dag and additive [[bin]]
entries in stage0 Cargo.toml.

---------

Co-authored-by: Brian Searls <briansrls@gunb.ai>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant