Repository navigation
5-test-migration (10): map_lookup_dual_dispatch — 4 checks to floor witnesses, module shrunk to 2 residuals - #6150
Merged
Conversation
(cherry picked from commit e1340d038091c8fad78cc4d8c7bf76d623640609)
This reverts commit 798bf56.
…ses, module shrunk to 2 residuals New dsl/test/claim/map_lookup_dual_dispatch_witness_test.dag carries the three lookup-surface checks + std.graph adjacency smoke as marker-discovered test fns. Perturb receipt at the live realization layer: raw_map_lookup (v1_interpreter.rs:6256, the dual-dispatch chokepoint) forced to always miss reds all four witnesses (also proving the routing claim). Residuals: the source-scan bypass wall (pinned harness) and the #[ignore]d empty-list inference case (pre-existing bug, bucket=inference). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 task done
briansrls
added a commit
that referenced
this pull request
Jul 3, 2026
Six rows were listing modules as full-debt after they had already partially or fully migrated (per #6140/#6142/#6143/#6145/#6147/#6150/#6153): render_repeat, cron_tag, money_carrier_cost_witness are fully deleted from src/v1/tests/src/lib.rs (removed from table); fn_as_value_test, witness_option_bridge_test, map_lookup_dual_dispatch_test, coproduct_reflection_conformance_test shrunk to small pinned residuals (LOC/test counts corrected against current main). Co-authored-by: Brian Searls <briansrls@gmail.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tenth PR of the 5-test-migration lane. This slice closes only the map_lookup_dual_dispatch module; the lane node stays open.
What
dsl/test/claim/map_lookup_dual_dispatch_witness_test.dag: four marker-discoveredtest fns — the three map-lookup surfaces (m |> get(k),m[k]index sugar,lookup(m,k)builtin) and thestd.graphadjacency-view smoke that consumesmap_getend-to-end.src/v1/tests/src/map_lookup_dual_dispatch_test.rs175→~75 LOC, 6→2 tests.Residuals (documented in module header)
map_lookup_operations_do_not_probe_value_map_outside_chokepoint: scansv1_interpreter.rsfor forbidden nativeValue::Mapprobe patterns — a pinned-harness fact, dissolves with the v1 interpreter.map_get_function_returns_optional_for_empty_list_hit: already#[ignore]d on a pre-existing empty-list-literal inference bug (bucket=inference, surfaced by Widen the rust gate by construction (§1): invert the hand-picked 3-filter allowlist (29 of 792 green tests) → run-all-unless-#[ignore]d-with-written-reason; add CI-coverage-completeness so a new test is covered by default (fail-closed); measure CI-time impact before committing the full set #5427); migrates when the bug is fixed and the witness can land green.Receipts (green-by-execution + perturb→red, layer justified)
claim_batch --entry dsl/test/claim/map_lookup_dual_dispatch_witness_test.dag --functions <all 4>→ 4/4 PASS.raw_map_lookup,v1_interpreter.rs:6256) — no.dagbody exists to perturb. A temporary Rust commit forcing it to always miss reds all four witnesses (exit 1), which simultaneously proves the routing claim the v1 tests asserted (every surface goes through the chokepoint). Perturb commit reverted in-branch.cargo clippy -p v1-compiler-tests --all-targets -- -D warningsgreen at head.🤖 Generated with Claude Code