Repository navigation
Dsl roadmap - #47
Merged
Merged
Dsl roadmap#47
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 340c7b95c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced May 7, 2026
briansrls
added a commit
that referenced
this pull request
May 10, 2026
Address review: name the dissolution receipt (ROADMAP Active deferrals, docs/db-history/db-20.md, design-db20 stage-2e lens) in rustdoc and inline comments; add TODO(DB-20) for replacing whole-program thread::scope greps. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
May 10, 2026
Addresses exploratory review note: singleton map was a trivial one-step iteration; cons(1, singleton(2)) keeps the structural proxy meaningful if parallel scheduling ever gates on iteration count. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
May 10, 2026
briansrls
added a commit
that referenced
this pull request
May 10, 2026
Addresses review: idx==1 broke if suite claim order changed; match on gate #47 name keeps semantics stable while zip still locks runner order. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
May 10, 2026
) * feat(v3): wire R3 gate #47 sequential fallback emit witness Gate auto_loop_parallelism_unproven_falls_back_sequential now uses LensOutputEquals + emit_rust structural witness (no std::thread::scope), matching the gate #43 bind-parallelism pattern. Fixture claim exercises a single-bind map program; other loop claims stay fail-closed on the placeholder lens. Co-authored-by: Cursor <cursoragent@cursor.com> * docs(v3): cite ROADMAP DB-20 deferral for R3 #43/#47 emit witnesses Address review: name the dissolution receipt (ROADMAP Active deferrals, docs/db-history/db-20.md, design-db20 stage-2e lens) in rustdoc and inline comments; add TODO(DB-20) for replacing whole-program thread::scope greps. Co-authored-by: Cursor <cursoragent@cursor.com> * test(v3): two-element map corpus for gate #47 sequential witness Addresses exploratory review note: singleton map was a trivial one-step iteration; cons(1, singleton(2)) keeps the structural proxy meaningful if parallel scheduling ever gates on iteration count. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: R3 gate #47: auto loop parallelism unproven falls back sequential * test(v3): key second-batch expectations by claim name, not index Addresses review: idx==1 broke if suite claim order changed; match on gate #47 name keeps semantics stable while zip still locks runner order. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 10, 2026
briansrls
added a commit
that referenced
this pull request
May 10, 2026
- Land r3_fc_lane2_loop_witness + compile_to_dag hook, lens_apply program_under_test path, fixture witness lines, ROADMAP/SG-0 P5 receipts. - Fold in main #2535 second-batch surface: drop superseded emit-rust witness dispatch for gates #47–#48 and `r3_loop_dependence_sequential_emit_witness` helper; gate #48 uses the same pending-lens + magic-comment path as #46/#47. - Integration test docs: spell out author attestation vs composed lenses (api-review). Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
May 10, 2026
- r3_fc_lane2_loop_witness + compile_to_dag / parse-surface hooks; native auto_loop_parallelism_pending_lens when program_under_test is Some. - Second-batch .dag: magic-comment staging for all three auto-loop claims; drop superseded emit-rust witness dispatch for #47–#48 and r3_loop_dependence_sequential_emit_witness (superseded by substrate read). - ROADMAP P5 carve-out, SG-0 (b) append, census, brief note; integration test documents author attestation vs composed lenses. - Gate #48 program file aligned to staged witness source. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
May 10, 2026
- r3_fc_lane2_loop_witness + compile_to_dag / parse-surface hooks; native auto_loop_parallelism_pending_lens when program_under_test is Some. - Second-batch .dag: magic-comment staging for all three auto-loop claims; drop superseded emit-rust witness dispatch for #47–#48 and r3_loop_dependence_sequential_emit_witness (superseded by substrate read). - ROADMAP P5 carve-out, SG-0 (b) append, census, brief note; integration test documents author attestation vs composed lenses. - Gate #48 program file aligned to staged witness source. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
May 10, 2026
* feat(v3): R3 second-batch staged lane2 witness (gates #46–#48) - r3_fc_lane2_loop_witness + compile_to_dag / parse-surface hooks; native auto_loop_parallelism_pending_lens when program_under_test is Some. - Second-batch .dag: magic-comment staging for all three auto-loop claims; drop superseded emit-rust witness dispatch for #47–#48 and r3_loop_dependence_sequential_emit_witness (superseded by substrate read). - ROADMAP P5 carve-out, SG-0 (b) append, census, brief note; integration test documents author attestation vs composed lenses. - Gate #48 program file aligned to staged witness source. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: R3 gate #46: auto loop parallelism provable independence emits parallel * fix(v3): align second-batch auto-loop fixture comments with staged harness Second-batch TestClaim source comments implied compiler-detected independence or dependence; gates #46–#48 only observe directive attestation + pending lens. Update inline .dag strings and the mirrored .v3 so downstream readers are not misled (ROADMAP auto-loop scaffold remains the authority). Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v3): restore structural fold in gate #48 free-consequences fixture Reintroduce std.list.fold (acc + x) in the dependence claim so lowering still walks a real loop body; staged lens Pass remains directive + pending-lens per ROADMAP. Add byte-for-byte ratchet: embedded TestClaim.source must match the .v3 authority via include_str (and ASCII hyphen in comments to avoid .dag embed mojibake). Co-authored-by: Cursor <cursoragent@cursor.com> * test(v3): assert gate #48 fold lowers to Behavior::Loop Review 8808: the pending-lens Pass path still reads staged lane2_workflow, but the claim program is no longer unverified text — integration now compiles the embedded gate #48 source and requires a Loop node so std.list.fold stays load-bearing on the lowering surface. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: R3 gate #46: auto loop parallelism provable independence emits parallel * WIP: R3 gate #46: auto loop parallelism provable independence emits parallel * fix(v3): repair CI fmt + lane2 witness test premise - Remove staged_directive_without_bind_shell_is_diagnostic: Dag::new() is bootstrapped with a Bind shell, so the test never exercised the no-Bind path. - Apply rustfmt to dag imports; drop unused test imports (super::*, Dag). - Assert pending-lens gate via ClaimResult::Fail(_) only, not prose substrings. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 10, 2026
briansrls
added a commit
that referenced
this pull request
May 10, 2026
…2648) * docs(r3): §1.8 ledger-receipt sync — 2026-05-10 batch (V Mgr lane) Flip §1.8 ledger Status from DECLARED/CONSUMER_LANDED to PASSING for V-Mgr lane gates whose CONSUMER_LANDED PRs landed in main as of 2026-05-10. Each row cites the merging PR per Director-ratified post-merge ledger-receipt sync discipline (gunbc#828 c#4415884211). Gates flipped (17): #9 (#2585), #10 (#2602), #11 (#2603), #12 (#2598), #14 (#2571), #31 (#2586), #43 (#2495), #44 (#2523), #45 (#2527), #46 (#2529), #47 (#2532), #48 (#2535), #49 (#2536), #50 (#2547), #51 (#2577), #52 (#2578), #69 (#2551). Skipped per discipline: #15 (PR #2604 not landed); #35 already PASSING. Doc-only; no code or test changes. Closes #2640. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): preserve corpus-quantified + canvas-deferral qualifiers on rows #9/#10/#11 Reviewer (claude-opus-4-7 on PR #2648) flagged that the prior status text on rows #9, #10, #11 carried Director/PM-ratified semantic qualifiers that must not be silently elided when citing a new slice receipt: - #9 `l4_emit_eval_match`: §1.7 corpus-quantified rule — slice receipts ≠ ledger closure; PASSING requires every certification-corpus program. Reverted to CONSUMER_LANDED; PR #2585 cited as additional slice evidence. - #10 `l7_algebraic_laws_witnessed`: PASSING requires exhaustive per-(algebra, inhabitant, law) §Acceptance coverage; distributivity / lattice absorption / non-AlgebraicLawKind laws remain substrate §P1. Reverted to CONSUMER_LANDED; PR #2602 cited as incremental advancement. - #11 `tc1_eta_equivalence_executable`: Director (a)-disposition 2026-05-09 held this canvas-deferred past R3 absent #1972 substrate canvas-tier work. Reverted to DECLARED-through-R3; PR #2603 cited as scaffold advancement but not retiring the canvas-deferral (which would require fresh Director ratification). Other 14 rows in the batch (#12, #14, #31, #43-52, #69) did not carry such qualifiers and stay flipped to PASSING. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Merge origin/main into ledger-receipt sync (preserve row #13 update from main) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.