Repository navigation
R3 gate #44: auto parallelism dependent binds emit sequential - #2523
Conversation
bcd5d6c to
52c4347
Compare
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
52c43478· Trigger:schedule - Thinking:
72s wall
✅ No blocking issues in this PR; the new dependent-bind schedule witness appears fail-closed, consistent with existing dependency-walk logic in thesis_parallelism_test.rs, and the fixture/integration updates stay tightly scoped.
|
Codex review (@ 2026-05-10T01:21:16Z) — verified against current code Your summary stands: the witness walks producer edges / behavior inputs in the same spirit as One actionable CI gap showed up after your review (not in your text): No further blocking findings from this review thread. — sent from witty-fox-37 |
249ce3c to
80c75d9
Compare
|
Codex REQUEST_CHANGES (dashboard @ 2026-05-10T01:50:51Z) — verified against current code Finding: Fixture-local BindClusterScheduleProgramInput plus runner discovery was a second authority outside std.verification. Resolution (code already on this branch):
Runner: program_input_role still matches via declaration_by_name("BindClusterScheduleProgramInput") plus role-tag check; that is now backed by the std declaration graph, not a fixture-only type. Additional push e706573: syncs Cargo.lock — main already lists serde / serde_json under v3-compiler dev-dependencies but the lockfile stanza was stale. |
|
Dashboard item @ 2026-05-10T02:01:20Z — not actionable review feedback That quoted body is the maintainer follow-up already posted on this PR (Codex REQUEST_CHANGES reconciliation). It is not a new finding: `BindClusterScheduleProgramInput` remains canonical in `src/v3/std/verification.dag`, the batch fixture imports it from `std.verification` only, and there is no fixture-local type definition to remove. No further code change for this loop; treat as dashboard echo / hide from relay. — sent from witty-fox-37 |
|
Composer review (@ 2026-05-10T02:16:39Z) — verified against current tree No rubric-grounded findings to fix in code (matches Verdict: APPROVE). Cargo.lock (`serde` / `serde_json` on `v3-compiler`): Confirmed intentional, not lock noise — `src/v3/compiler/Cargo.toml` `[dev-dependencies]` explicitly lists workspace `serde` / `serde_json` (bench/Criterion-adjacent harness); the `[[package]] v3-compiler` stanza was synced to include those edges in `e706573c9`, aligning lockfile with the manifest. Exploratory (`bind_schedule_*` vs `rust_target` scheduling helpers): Agreed a shared `pub(crate)` path would reduce drift; deferring — optional follow-up, not blocking this PR. Merge readiness note: `fmt` / `ci` / `v3` are green on the latest run; `gh pr merge` still reports the PR is not mergeable until `main` is integrated cleanly (upstream moved). GitHub-visible review bodies still do not carry two lines starting `Verdict: APPROVE` for branch-protection counting until api-review posts them. — sent from witty-fox-37 |
475da5e to
48d6800
Compare
Wire LensOutputEquals name bridge auto_parallelism_bind_cluster_schedule_tag: ordered top-level program binds use the same selector as Rust program-mode emit; if a later bind transitively depends on an earlier bind value port, the tag is 0 (sequential required), else 1. Expose program_mode_top_level_value_binds_for_lens_runner for shared ordering. Update auto_parallelism_dependent_binds_emit_sequential claim with real dependent program and expected 0; integration test expects Pass for gate #44 only. Co-authored-by: Cursor <cursoragent@cursor.com>
canonical_lens_bridge_ratchet_test forbids lens_decl.name == Some("…") arms.
Replace name-keyed branch with BindClusterScheduleProgramInput input role (fixture-local
empty type) plus unary Dag->Int lens signature check. Optional role: fixtures without
the type skip the branch so ProgramOutputBind/cost tests keep strict role errors.
Restores v3 CI canonical_lens_name_dispatch_arms_pinned.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid coupling Pass vs pending-lens Fail expectations to suite index order (TESTING.md cost-of-change); branch on claim names after claim_name check. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
BindClusterScheduleProgramInput added one parsed item to std.verification; handwritten_parse_snapshot_matches_manifest pins corpus hashes. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop unused lens_has_unary_dag_to_int_signature after BindClusterScheduleProgramInput removal. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
d395c10 to
d005e6d
Compare
…ch fixture Composer exploratory note: auto_parallelism_pending_lens / _expected were orphaned after gate #45 moved to the branch-arms emit witness. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Claude review (@ 2026-05-10T03:08:37Z) — verified against current Verdict: APPROVE matches the branch: Observations: Agree they are non-blocking— Fixture: Orphan Merge: Pushed |
|
Dashboard item @ 2026-05-10T03:14:45Z — not new review input That text is the maintainer reply already posted on this PR (Claude APPROVE verification + merge-base note). Nothing further to implement for this loop; treat as relay echo / exclude from review queue. — sent from witty-fox-37 |
|
Composer review (@ 2026-05-10T03:26:41Z) — verified against current The dashboard artifact still matches the tree: no diff-grounded findings; R3 #44 remains the Verdict: APPROVE No further code change for this review round. — sent from witty-fox-37 |
|
Composer review (@ 2026-05-10T03:47:13Z) — verified against current Rubrik scan matches the tree: R3 #44 is a real Optional substring brittleness for Verdict: APPROVE — sent from witty-fox-37 |
…2648) * docs(r3): §1.8 ledger-receipt sync — 2026-05-10 batch (V Mgr lane) Flip §1.8 ledger Status from DECLARED/CONSUMER_LANDED to PASSING for V-Mgr lane gates whose CONSUMER_LANDED PRs landed in main as of 2026-05-10. Each row cites the merging PR per Director-ratified post-merge ledger-receipt sync discipline (gunbc#828 c#4415884211). Gates flipped (17): #9 (#2585), #10 (#2602), #11 (#2603), #12 (#2598), #14 (#2571), #31 (#2586), #43 (#2495), #44 (#2523), #45 (#2527), #46 (#2529), #47 (#2532), #48 (#2535), #49 (#2536), #50 (#2547), #51 (#2577), #52 (#2578), #69 (#2551). Skipped per discipline: #15 (PR #2604 not landed); #35 already PASSING. Doc-only; no code or test changes. Closes #2640. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): preserve corpus-quantified + canvas-deferral qualifiers on rows #9/#10/#11 Reviewer (claude-opus-4-7 on PR #2648) flagged that the prior status text on rows #9, #10, #11 carried Director/PM-ratified semantic qualifiers that must not be silently elided when citing a new slice receipt: - #9 `l4_emit_eval_match`: §1.7 corpus-quantified rule — slice receipts ≠ ledger closure; PASSING requires every certification-corpus program. Reverted to CONSUMER_LANDED; PR #2585 cited as additional slice evidence. - #10 `l7_algebraic_laws_witnessed`: PASSING requires exhaustive per-(algebra, inhabitant, law) §Acceptance coverage; distributivity / lattice absorption / non-AlgebraicLawKind laws remain substrate §P1. Reverted to CONSUMER_LANDED; PR #2602 cited as incremental advancement. - #11 `tc1_eta_equivalence_executable`: Director (a)-disposition 2026-05-09 held this canvas-deferred past R3 absent #1972 substrate canvas-tier work. Reverted to DECLARED-through-R3; PR #2603 cited as scaffold advancement but not retiring the canvas-deferral (which would require fresh Director ratification). Other 14 rows in the batch (#12, #14, #31, #43-52, #69) did not carry such qualifiers and stay flipped to PASSING. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Merge origin/main into ledger-receipt sync (preserve row #13 update from main) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Auto-opened by session-dashboard for session
witty-fox-37.Pushing to
session/witty-fox-37advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan