Skip to content

Fail closed R3 rust dag isomorphism gate - #2571

Merged
briansrls merged 32 commits into
mainfrom
session/eager-wren-817
May 10, 2026
Merged

briansrls merged 32 commits into
mainfrom
session/eager-wren-817

Conversation

@briansrls

@briansrls briansrls commented May 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Removes the claim-specific BinaryDimensionReportEquals shortcut that returned Pass for rust_dag_isomorphism_executable after only validating carrier shape.
  • Restores the gate receipt to the existing shape-valid NotYetImplemented boundary until real DimensionReport<Dag> / DagShapeReport production and comparison exists.
  • Keeps the shared BinaryDimensionReportEquals structural validation behavior intact for same-carrier and structurally equivalent carrier refs.

Review Disposition

The blocking review was correct. The previous PR head treated DimensionReport<Dag> carrier agreement plus claim/declaration names as a passing Rust Dag isomorphism check. That did not compare report payloads or execute Dag-isomorphism logic, so it violated the gate acceptance. This update fails closed instead of claiming gate closure.

Verification

  • cargo fmt --check
  • cargo test -p v3-compiler --test integration rust_dag_isomorphism_executable_passes_dag_shape_report_gate
  • cargo test -p v3-compiler --test integration binary_dimension_report_equals

briansrls added 29 commits May 9, 2026 22:31
@briansrls
briansrls marked this pull request as ready for review May 10, 2026 05:06
@briansrls briansrls changed the title R3 gate #14: rust dag isomorphism executable Fail closed R3 rust dag isomorphism gate May 10, 2026
@briansrls

Copy link
Copy Markdown
Contributor Author

Verified the blocking review against current code and accepted it.

The prior PR head returned Pass for rust_dag_isomorphism_executable after only checking DimensionReport<Dag> carrier shape plus claim/declaration names. That was not a Dag-isomorphism check and could have passed mismatched reports.

Pushed corrective commit 9ba15325b:

  • removed the claim-specific Pass shortcut from BinaryDimensionReportEquals
  • removed the now-unused helper
  • restored the integration receipt to the shape-valid NotYetImplemented boundary
  • updated the PR body/title so it no longer claims gate closure or closes the dashboard work item

Verification after the fix:

  • cargo fmt --check
  • cargo test -p v3-compiler --test integration rust_dag_isomorphism_executable_passes_dag_shape_report_gate
  • cargo test -p v3-compiler --test integration binary_dimension_report_equals

Conclusion: the review finding is resolved by removing the false positive. The actual #14 PASSING implementation still needs a real DimensionReport<Dag> / DagShapeReport producer and payload comparison path.

@briansrls
briansrls marked this pull request as draft May 10, 2026 05:17
@briansrls

Copy link
Copy Markdown
Contributor Author

Dashboard relay item 1 is my own earlier disposition comment (viewerDidAuthor=true) for the blocking review. I verified current code and PR state again: corrective commit 9ba15325b is still the PR head, the worktree is clean, and no additional reviewer finding is present in this relay.

No additional code change is needed for this item. PR #2571 remains draft intentionally because it no longer claims #14 PASSING; it is a fail-closed correction pending a real DimensionReport<Dag> / DagShapeReport producer and payload comparison path.

— sent from eager-wren-817

@briansrls
briansrls marked this pull request as ready for review May 10, 2026 05:34
@briansrls

Copy link
Copy Markdown
Contributor Author

Verified the relayed codex/codex-default approval against the current PR head (9d359fc67). The current diff remains the narrow fail-closed correction: BinaryDimensionReportEquals helper rename only, with no claim-specific pass shortcut and no new hand-Rust predicate surface.

No code change is needed for this approval item. Rechecked merge readiness: currently waiting on CI v3 completion and a second distinct Verdict: APPROVE before merge can proceed.

— sent from eager-wren-817

@briansrls

Copy link
Copy Markdown
Contributor Author

Verified the relayed claude/claude-opus-4-7 approval against the current PR diff. The diff is still only the 2-line eval_binary_dimension_report_equals_shape -> eval_binary_dimension_report_equals rename in src/v3/compiler/src/test_runner.rs; behavior remains fail-closed after carrier-equivalence validation.

No code change is needed for this approval item. Merge readiness recheck: two distinct relayed approvals are now present (codex/codex-default and claude/claude-opus-4-7), no request-changes signal found, GitHub reports mergeable, and CI is waiting only on the v3 job at the time of this comment.

— sent from eager-wren-817

@briansrls
briansrls merged commit 756abc3 into main May 10, 2026
4 checks passed
@briansrls
briansrls deleted the session/eager-wren-817 branch May 10, 2026 06:03
briansrls added a commit that referenced this pull request May 10, 2026
…2648)

* docs(r3): §1.8 ledger-receipt sync — 2026-05-10 batch (V Mgr lane)

Flip §1.8 ledger Status from DECLARED/CONSUMER_LANDED to PASSING for V-Mgr
lane gates whose CONSUMER_LANDED PRs landed in main as of 2026-05-10. Each
row cites the merging PR per Director-ratified post-merge ledger-receipt
sync discipline (gunbc#828 c#4415884211).

Gates flipped (17): #9 (#2585), #10 (#2602), #11 (#2603), #12 (#2598),
#14 (#2571), #31 (#2586), #43 (#2495), #44 (#2523), #45 (#2527),
#46 (#2529), #47 (#2532), #48 (#2535), #49 (#2536), #50 (#2547),
#51 (#2577), #52 (#2578), #69 (#2551).

Skipped per discipline: #15 (PR #2604 not landed); #35 already PASSING.

Doc-only; no code or test changes. Closes #2640.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(r3): preserve corpus-quantified + canvas-deferral qualifiers on rows #9/#10/#11

Reviewer (claude-opus-4-7 on PR #2648) flagged that the prior status text
on rows #9, #10, #11 carried Director/PM-ratified semantic qualifiers that
must not be silently elided when citing a new slice receipt:

- #9 `l4_emit_eval_match`: §1.7 corpus-quantified rule — slice receipts ≠
  ledger closure; PASSING requires every certification-corpus program.
  Reverted to CONSUMER_LANDED; PR #2585 cited as additional slice evidence.
- #10 `l7_algebraic_laws_witnessed`: PASSING requires exhaustive per-(algebra,
  inhabitant, law) §Acceptance coverage; distributivity / lattice absorption /
  non-AlgebraicLawKind laws remain substrate §P1. Reverted to CONSUMER_LANDED;
  PR #2602 cited as incremental advancement.
- #11 `tc1_eta_equivalence_executable`: Director (a)-disposition 2026-05-09
  held this canvas-deferred past R3 absent #1972 substrate canvas-tier work.
  Reverted to DECLARED-through-R3; PR #2603 cited as scaffold advancement
  but not retiring the canvas-deferral (which would require fresh Director
  ratification).

Other 14 rows in the batch (#12, #14, #31, #43-52, #69) did not carry such
qualifiers and stay flipped to PASSING.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Merge origin/main into ledger-receipt sync (preserve row #13 update from main)

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant