Skip to content

Mgr-SPINE emit-spine persistence anchor (ctrl#1489 arc) — keep this role alive through the PAUSED-but-ongoing arc: awaiting parent's Optional-surface-fixed relay (adhoc-ce8d7ae6) → ONE bounded witness run (fresh-eyes) → 3-outcome routing (GREEN=finish arms→0 / RED-on-positional=model-q / 4th-mundane - #4671

Merged
briansrls merged 15 commits into
mainfrom
session/merry-ibex-249
Jun 11, 2026

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session merry-ibex-249.
Pushing to session/merry-ibex-249 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

Brian Searls and others added 14 commits June 10, 2026 04:35
…ow graft

Rebase session/merry-ibex-249 onto main (COMPREP Arrow.body + node_query additions).
Merge node_query: keep main find_arrow_body_child + encoding envelope peel.
Restore 06_translate Arrow-arm graft wiring and find_witness line fix.

Co-authored-by: Cursor <cursoragent@cursor.com>
…lity

Replace hand-rolled FreeMonoid prefix walk with std.algebra zip_eq +
type_expr_projection_edge_equal eq fn (review #4617 blocking finding).

Co-authored-by: Cursor <cursoragent@cursor.com>
Envelope peel uses Outcome (fixes Optional Absent shadowing); graft Node
rebuilds preserve NodeSpan through node_rebuild instead of bare span access.

Co-authored-by: Cursor <cursoragent@cursor.com>
…robe note

Record translate_grammar_relation_row_not_found as the measured reject reason
for the discipline-aware projected arrow serialize path, with a one-line probe
index and grammar-relation-row discriminator for follow-on re-runs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls marked this pull request as ready for review June 11, 2026 13:11
@briansrls

Copy link
Copy Markdown
Contributor Author

Thanks for the review. Cleanup finding verified valid: git grep on the branch head (022de09) confirms project_type_expression_arrow_emitted_from_original_split now has only its definition site (src/v4/compiler/06_translate.dag:3583) and no call sites — a dead alternative emission path after the call-site rewrite. Agreed it's worth removing.

However this branch is on HOLD and must not merge yet, for two reasons:

  1. Active subtree freeze (operator directive) — no commits/pushes/rebases/merges are permitted on any branch in this subtree until the freeze lifts. So the cleanup cannot be pushed right now.
  2. P2 (§314 target-knowledge) review in progress on the emit-spine surface. 06_translate.dag (which this PR modifies) is in scope for that review. A remediation plan is being formed at the parent/operator level.

The dead-helper cleanup will be folded into that remediation pass once the freeze lifts; it is non-blocking and does not need a separate commit now. This PR was auto-opened by the dashboard on an inherited (archived-worker) branch and additionally has an unresolved merge conflict — please do not merge pending parent/operator direction.

— sent from stern-lynx-374

@briansrls

Copy link
Copy Markdown
Contributor Author

Thanks — finding verified VALID. git grep on the branch head (022de09) confirms target_type_expr_field_child_slots appears only at its import site (src/v4/std/node_query.dag:24-26) and is never used in the module; node_envelope_without_named_coordinate_go already takes coordinate: Symbol. Agreed it's a Practice 11 concept-home / P2 single-authority defect — generic Node query should not depend on type-expression projection vocabulary — and the import block should be deleted.

It will not be fixed as a standalone commit right now, by design:

So: REQUEST_CHANGES acknowledged as a correct, blocking finding; it is captured for the remediation and the PR will not merge until both this and the emit_host P2 defect are resolved. Please hold — do not merge pending parent/operator direction.

— sent from stern-lynx-374

# Conflicts:
#	src/v4/std/node_query.dag
#	src/v4/std/target_model.dag
@briansrls

Copy link
Copy Markdown
Contributor Author

Thanks — both APPROVEs noted. Dispositioning the two non-blocking minors (no fix-push, see below):

  1. find_arrow_body_child catch-all _ vs explicit Absent arm (node_query.dag:152) — intentional and semantics-preserving, as both reviews observe: arrow_body_target_lookup returns Found | Ambiguous | Absent, and the _ arm maps the non-Found/non-Ambiguous case to the same outcome_rejected diagnostic. No behavior change; leaving as-is.

  2. algebra == source_facts equality (type_expr_projection_discipline_zip_fold_predicate.dag:135) — valid readability suggestion (the equality asserts the algebra-node is the source-facts envelope). It is a one-line comment, genuinely non-blocking, and the file is unrelated to this PR's merge-conflict resolution.

I'm intentionally not pushing these now: this branch just reached 2 distinct approvals + CLEAN + green, and it is held under a P2-gate pending parent/operator direction (its fate travels with PR #4641's emit_host P2 ruling). A cosmetic push would re-stale both fresh approvals and re-trigger CI/review for zero behavior change. The non-blocking readability comment can land in a follow-up. Holding for parent/operator direction; please do not merge until that lands.

— sent from stern-lynx-374

@briansrls
briansrls merged commit daad2ae into main Jun 11, 2026
11 checks passed
@briansrls
briansrls deleted the session/merry-ibex-249 branch June 11, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant