Skip to content

Mgr-SPINE emit-spine persistence anchor (ctrl#1489 arc) — keep this role alive through the PAUSED-but-ongoing arc: awaiting parent's Optional-surface-fixed relay (adhoc-ce8d7ae6) → ONE bounded witness run (fresh-eyes) → 3-outcome routing (GREEN=finish arms→0 / RED-on-positional=model-q / 4th-mundane - #4617

Closed
briansrls wants to merge 4 commits into
mainfrom
session/merry-ibex-249

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session merry-ibex-249.
Pushing to session/merry-ibex-249 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

Brian Searls and others added 2 commits June 10, 2026 04:35
…ow graft

Rebase session/merry-ibex-249 onto main (COMPREP Arrow.body + node_query additions).
Merge node_query: keep main find_arrow_body_child + encoding envelope peel.
Restore 06_translate Arrow-arm graft wiring and find_witness line fix.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls force-pushed the session/merry-ibex-249 branch from 8bb2565 to 1b04520 Compare June 10, 2026 04:36

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 1b045205 · Trigger: schedule
  • Thinking: 317s wall

BLOCKING (1)

Root Cause

  • src/v4/std/type_expr_projection_discipline_zip_fold_predicate.dag edge-list equality was modeled as a local walker instead of consuming the canonical FreeMonoid zip equality → import and use zip_eq with type_expr_projection_edge_equal as the equality function

⚠️ One blocking substrate duplicate-authority issue needs to be fixed before merge.

&& type_expr_projection_edges_prefix_equal(prefix: left, full: right)
}

fn type_expr_projection_edges_prefix_equal(

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified — finding is correct. Fixed in 1e7c57c:

  • Deleted hand-rolled type_expr_projection_edges_prefix_equal FreeMonoid walk
  • type_expr_projection_edges_exact_equal now delegates to std.algebra.zip_eq with type_expr_projection_edge_equal as the element eq fn (label + exact_structural_equality_zip_fold on targets)
  • Removed now-unused algebra imports

PR stays DRAFT per parent hold (#4606 gate before witness run); this is encoding-quality only, not merge-ready.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already addressed on current HEAD (1e7c57c): hand-rolled prefix walk removed; type_expr_projection_edges_exact_equal delegates to std.algebra.zip_eq with type_expr_projection_edge_equal as the element eq fn. Verified in working tree — no further code change for this finding.

PR intentionally remains DRAFT (parent hold: #4606 → compile=0 → encoded witness run).

— sent from merry-ibex-249

Brian Searls and others added 2 commits June 10, 2026 05:19
…lity

Replace hand-rolled FreeMonoid prefix walk with std.algebra zip_eq +
type_expr_projection_edge_equal eq fn (review #4617 blocking finding).

Co-authored-by: Cursor <cursoragent@cursor.com>

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 1e7c57c3 · Trigger: schedule
  • Thinking: 288s wall

Non-blocking — Strengths

  • src/v4/std/type_expr_projection_discipline_zip_fold_predicate.dag The new predicate consumes zip_eq and delegates child-slot legality to edges_conform, so I do not see a duplicate predicate authority in the changed lines.

✅ No blocking concerns in this PR.

@briansrls

Copy link
Copy Markdown
Contributor Author

Verified against HEAD 1e7c57c: codex non-blocking assessment matches current code — type_expr_projection_edges_exact_equal delegates to std.algebra.zip_eq with type_expr_projection_edge_equal; child-slot legality remains on edges_conform. No code change required for this review.

Merge readiness note: PR intentionally stays DRAFT per parent hold (#4606 → compile=0 with encoding → ONE encoded witness run). Dashboard approval count 0/2; not merge-ready by design until measurement gate clears.

— sent from merry-ibex-249

@briansrls

Copy link
Copy Markdown
Contributor Author

Parked-not-abandoned — closing to stop stale-draft nudge churn.

This PR staged the T3 discipline-aware encoding recovery (ed20544 carve-out delta re-reconciled on main):

  • type_expr_projection_discipline_zip_fold_predicate.dag
  • find_witness discipline rule dispatch
  • node_query envelope peel (+ main Arrow.body merge)
  • target_model graft functions + 06_translate Arrow-arm graft wiring

Blocked on #4606 (full Optional Present/Absent normalize) before compile=0 WITH encoding → ONE encoded witness_sg2_arrow_holds → 3-outcome report.

Reopens when #4606 lands: encoding bundle preserved on branch session/merry-ibex-249 (do not delete). Plan: reopen/fresh PR → re-reconcile onto post-#4606 main → compile gate → witness run.

— sent from merry-ibex-249

@briansrls briansrls closed this Jun 10, 2026
briansrls added a commit that referenced this pull request Jun 11, 2026
…ole alive through the PAUSED-but-ongoing arc: awaiting parent's Optional-surface-fixed relay (adhoc-ce8d7ae6) → ONE bounded witness run (fresh-eyes) → 3-outcome routing (GREEN=finish arms→0 / RED-on-positional=model-q / 4th-mundane (#4671)

* WIP: Mgr-SPINE emit-spine persistence anchor (ctrl#1489 arc) — keep this role

* fix(v4): re-reconcile encoding delta on main — node_query merge + Arrow graft

Rebase session/merry-ibex-249 onto main (COMPREP Arrow.body + node_query additions).
Merge node_query: keep main find_arrow_body_child + encoding envelope peel.
Restore 06_translate Arrow-arm graft wiring and find_witness line fix.

Co-authored-by: Cursor <cursoragent@cursor.com>

* WIP: Mgr-SPINE emit-spine persistence anchor (ctrl#1489 arc) — keep this role

* fix(v4): use zip_eq authority for discipline predicate edge-list equality

Replace hand-rolled FreeMonoid prefix walk with std.algebra zip_eq +
type_expr_projection_edge_equal eq fn (review #4617 blocking finding).

Co-authored-by: Cursor <cursoragent@cursor.com>

* WIP: Mgr-SPINE emit-spine persistence anchor (ctrl#1489 arc) — keep this role

* WIP: Mgr-SPINE emit-spine persistence anchor (ctrl#1489 arc) — keep this role

* fix(T3 encoding): post-#4606 reconcile + graft span via node_rebuild

Envelope peel uses Outcome (fixes Optional Absent shadowing); graft Node
rebuilds preserve NodeSpan through node_rebuild instead of bare span access.

Co-authored-by: Cursor <cursoragent@cursor.com>

* WIP: Mgr-SPINE emit-spine persistence anchor (ctrl#1489 arc) — keep this role

* test(T3): capture projected-serialize reject diagnostic + follow-on probe note

Record translate_grammar_relation_row_not_found as the measured reject reason
for the discipline-aware projected arrow serialize path, with a one-line probe
index and grammar-relation-row discriminator for follow-on re-runs.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Brian Searls <briansearls1@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant