Repository navigation
Fresh Dissolution closeout — refresh slug-only dissolution tags (post-#3289/#3277) - #3428
Conversation
Re-run refresh_v4_dissolution_tag_authority on cpp.dag and dag.dag so post-#3409 merges drop stale DECISIONS.md pointers. Fix the refresh script to preserve CP-1b parenthetical anchors when stripping ledger prefixes. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Verified the codex review against HEAD (
No additional code changes from this review. Pushing an empty commit to re-run — sent from eager-bat-105 |
No code change; prior ci job lost v2→v4 compile to runner shutdown after module resolve. Local discipline checks remain green. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
6fcb1c88· Trigger:schedule - Thinking:
86s wall
Non-blocking — Strengths
src/v4/extdeps/languages/cpp.dagThe refreshed C++ scalar coproduct tags keep the required green carrier classification while removing the retired DECISIONS.md ledger authority.src/v4/extdeps/languages/dag.dagThe CP-1b anchor and predicate-dissolution comments remain tied to the existing CP-1b/T-8 seam without adding a new prose ledger.scripts/refresh_v4_dissolution_tag_authority.pyThe script change narrowly preserves semicolon-delimited CP anchors while continuing to strip retired ledger prefixes.
✅ No blocking concerns in this mixed code/model tag-refresh diff.
|
Review metadata
1. Story of the diffThis PR is a closeout for stale dissolution-authority references after the ledger retirement work: it removes 2. Invariant categories1. LAYER MODEL — Compliant. The PR touches v4 extdeps language model files, but only comment/tag lines on existing declarations; it does not add or mutate Dag-resident substrate types, fields, variants, behavior nodes, or cross-pass authorities. 2. INVARIANTS.md + modeling-discipline.md — Finding. That does not cover one of the exact refreshed CP-1b forms in this PR: 3. CODING.md — Compliant. Apart from the functional regex gap above, the code change is a small local pure text transformation with no new hidden state, broad API surface, or large helper; the 4. TESTING.md — N/A. The changed 5. LOCKED DESIGN DECISIONS — Compliant. The PR does not alter a locked design decision; it removes references to the retired 6. TRACKED vs UNTRACKED DEBT — Compliant. The diff does not introduce a new scaffold, TODO, or temporary representation. The existing yellow predicate-dissolution marker in 2.5. Top-down PM intent reviewCompliant with the script fix required above. The file edits themselves preserve the PM-level intent of the closeout: retired ledger references move out of 3. VerdictREQUEST_CHANGES. The slug-only tag refresh is directionally correct, but the updated refresh helper cannot reproduce at least one checked-in CP-1b cleanup form. Fix the no-semicolon |
Summary
Follow-up to #3409 (post–
DECISIONS.mdnuke tag authority): re-runscripts/refresh_v4_dissolution_tag_authority.pyon files that picked up staleDECISIONS.mddissolution pointers after later merges (#3289 cpp de-prose, dag CP-1b anchors).cpp.dag: fourT29-CPP-SCALAR-FORWARDcoproduct marks → slug-only (·form).dag.dag: CP-1b anchor comments and predicate-dissolution mark → slug-only (no deleted ledger paths).refresh_v4_dissolution_tag_authority.py: preserve parenthetical CP-1b anchors when strippingDECISIONS.mdprefixes (avoids truncating// DECISIONS.md §CP-1b item 2 (…); …comments).Test plan
python3 scripts/refresh_v4_dissolution_tag_authority.py— idempotent; zeroDECISIONS.md/dissolution-inventoryinsrc/v4/**/*.dagpython3 scripts/strict_deprose_dag.py --checkpython3 scripts/test_strict_deprose_dag.pyscripts/check-banked-dissolutions.sh— cleanscripts/check-r4-carve-dissolution-discipline.sh— 33 citations OKMade with Cursor