snappy-koi-58

[briansrls]

R3 Debt Receipt

Debt paid: ROADMAP Row 46 — production declaration_by_name use in src/v3/compiler/src/emit* is dissolved. Fixed emit-time anchors now resolve once through bootstrap-populated typed caches, and production emit code consumes DeclarationId fields instead of name strings. The regression gate emit_production_code_has_no_declaration_by_name_calls asserts production emit modules do not call Dag::declaration_by_name.

Debt newly found: none. Audit found no caller-provided string lookup sites in production emit. Remaining declaration_by_name calls under emit are test fixture lookups only.

Remaining row: ROADMAP Row 46 closes for production emit. Test-only fixture lookups remain outside the row scope and are excluded by the ratchet's #[cfg(test)] split.

Audit Catalog

All production sites classified as (a) substrate-fixed string / fixed emit-model coproduct:

• src/v3/compiler/src/emit/fold_method_contract.rs: MethodTemplateContract, fold_method. Role: validate CollectionOps.fold_contract references the canonical method-template contract and registry method. Consumption: contract identity comparison. Migrated to Dag::method_template_contract_decl() and Dag::fold_method_decl().
• src/v3/compiler/src/emit.rs: MethodEmitTemplate. Role: recover method-template variant labels for target method template dispatch. Consumption: method template label lookup. Migrated to Dag::method_emit_template_decl().
• src/v3/compiler/src/emit.rs: PatternStrategy.VectorList. Role: parse PatternRealization.strategy. Consumption: constructor identity check. Migrated to Dag::emit_model_variants().pattern_strategy.vector_list.
• src/v3/compiler/src/emit.rs and src/v3/compiler/src/emit/rust_target.rs: FieldAccess.DirectField, FieldAccess.AccessorMethod. Role: parse field-binding access policy. Consumption: constructor dispatch. Migrated to EmitModelVariants.field_access.
• src/v3/compiler/src/emit.rs and src/v3/compiler/src/emit/rust_target.rs: ParameterDisposition.Borrowed, ParameterDisposition.Consumed. Role: parse callable parameter disposition rows. Consumption: constructor dispatch. Migrated to EmitModelVariants.parameter_disposition.
• src/v3/compiler/src/emit.rs, src/v3/compiler/src/emit/rust_target.rs, src/v3/compiler/src/emit/python_target.rs: MemoryModel.{ValueOnly,GarbageCollected,RefCounted,OwnershipBased}. Role: parse target execution memory model. Consumption: target execution binding dispatch. Migrated to EmitModelVariants.memory_model.
• src/v3/compiler/src/emit.rs, src/v3/compiler/src/emit/rust_target.rs, src/v3/compiler/src/emit/python_target.rs: ScopeModel.{LexicalScoping,DynamicScoping}. Role: parse target execution scope model. Consumption: target execution binding dispatch. Migrated to EmitModelVariants.scope_model.
• src/v3/compiler/src/emit/rust_target.rs: ReadStrategy.{Borrow,PassByValue} and ConstructStrategy.{CopyOrClone,PassByValue}. Role: parse Rust rendering model. Consumption: borrow/construct rendering policy. Migrated to EmitModelVariants.read_strategy and construct_strategy.
• src/v3/compiler/src/emit/rust_target.rs: Mutability.{Immutable,Mutable}, Purity.{Pure,Effectful}, Structure.{ExplicitDAG,Arbitrary}, Iteration.{Bounded,Unbounded}. Role: parse Rust source computation model. Consumption: computation-model binding dispatch. Migrated to the corresponding EmitModelVariants groups.

No (b) caller-provided string production sites found. No (c) diagnostic/debug-only production sites need exemption.

Verification

• cargo test -p v3-compiler emit_production_code_has_no_declaration_by_name_calls -- --nocapture
• cargo test -p v3-compiler emit_model_variants_populated_after_bootstrap -- --nocapture
• cargo test -p v3-compiler emit_anchor_cache_populated_after_bootstrap -- --nocapture
• cargo test -p v3-compiler rendering_model_read_strategy_controls_function_parameter_shape -- --nocapture
• cargo test -p v3-compiler parameter_dispositions_reject_arity_drift_and_slot_collisions -- --nocapture

Full cargo test -p v3-compiler was also run. It passed 306 lib tests, 9 determinism tests, and 792 integration tests before failing only sg6_regen_lens_cli_smoke_regenerates_named_entry_without_drift because the shared cargo target reused a regen_lens binary compiled from another worktree path (crisp-ibex-569 instead of this worktree). The failure is path-cache environmental, not related to Row 46.

[briansrls]

Review metadata

• Provider / model: openai-pro / gpt-5-5-pro
• Commit: 87ea799b · Trigger: manual
• Comparison: main @ 822b6e0d ... codex/cc1-target-integer-structural-fold @ 1d0c99a4
• Conversation: View conversation

---

1. Story of the diff

This PR retires the ROADMAP debt row for production emit-time Dag::declaration_by_name(...) lookups by moving those fixed emit-model identities into bootstrap-populated DeclarationId caches (ROADMAP.md:373). The load-bearing mechanism is an expanded EmitAnchorCache plus a new EmitModelVariants cache on Dag, where fixed emit-model coproduct variants such as FieldAccess, MemoryModel, ReadStrategy, and Iteration are resolved once during bootstrap and then exposed through typed Dag accessors (src/v3/compiler/src/dag.rs:2279-2370, src/v3/compiler/src/dag.rs:3170-3173, src/v3/compiler/src/dag.rs:3904-4070).

The emitters then stop walking parent-name/variant-label strings locally and instead compare constructors against the cached IDs, preserving the same fail-closed error shapes when a required declaration is absent (src/v3/compiler/src/emit.rs:2775-2791, src/v3/compiler/src/emit/rust_target.rs:2411-2438, src/v3/compiler/src/emit/python_target.rs:1873-1931). The PR also adds cache-population tests and a regression ratchet that scans production emit* modules for reintroduced .declaration_by_name( calls (src/v3/compiler/src/dag.rs:4455-4539, src/v3/compiler/tests/integration/sg0_census_test.rs:43-76).

2. Invariant categories

1. LAYER MODEL (substrate vs implementation).

Compliant — the diff touches Dag, but as an implementation-side derived cache rather than a new substrate fact: EmitModelVariants is documented as “cached variant DeclarationIds” populated at bootstrap, and consumers read it through Dag::emit_model_variants() rather than authoring a second semantic source (src/v3/compiler/src/dag.rs:2355-2370, src/v3/compiler/src/dag.rs:3170-3173).

1. INVARIANTS.md + modeling-discipline.md.

Compliant — single authority / facts-flow-forward are improved: the authoritative declarations are resolved once into emit_model_variants at bootstrap (src/v3/compiler/src/dag.rs:3904-4070), while emit consumers fail closed through existing error carriers when a cached ID is absent instead of defaulting or fabricating (src/v3/compiler/src/emit/rust_target.rs:2434-2438, src/v3/compiler/src/emit/python_target.rs:1892-1893).

1. CODING.md.

Compliant — the change removes repeated local name-walker helpers from emit code in favor of precise Dag accessors and structured error returns; for example, fold contract validation now asks dag.method_template_contract_decl() / dag.fold_method_decl() and converts missing anchors through ok_or(...) (src/v3/compiler/src/emit/fold_method_contract.rs:15-20), and target emit parsing reads a typed variant cache instead of reconstructing parent/variant lookup logic (src/v3/compiler/src/emit.rs:2775-2791).

1. TESTING.md.

Compliant — the diff adds both a focused cache-population test for the new bootstrap invariant (src/v3/compiler/src/dag.rs:4455-4539) and a regression/census ratchet that checks the promised production emit boundary directly (src/v3/compiler/tests/integration/sg0_census_test.rs:43-76).

1. LOCKED DESIGN DECISIONS.

N/A — the diff retires a ROADMAP debt row and adjusts Rust implementation/cache plumbing; it does not modify a thesis/design document or alter a “LOCKED” decision in the reviewed diff (ROADMAP.md:373).

1. TRACKED vs UNTRACKED DEBT.

Compliant — the only debt movement is tracked and bounded: the ROADMAP row is explicitly retired with the named ratchet emit_production_code_has_no_declaration_by_name_calls (ROADMAP.md:373), and that ratchet is implemented in the same diff (src/v3/compiler/tests/integration/sg0_census_test.rs:43-76). I did not see new TODOs, scaffolds, or temporary bridge shapes in the changed lines.

3. Verdict

APPROVE

The PR moves emit lookup behavior toward single-authority cached substrate identities, keeps absence fail-closed, and includes a direct regression ratchet for the retired debt row. I did not find a diff-citable invariant violation.

[briansrls]

Review metadata

• Provider / model: cursor / composer-2
• Commit: 1d0c99a4 · Trigger: schedule
• Comparison: origin/main @ 822b6e0d ... review/pr-1638-1d0c99a4 @ 1d0c99a4
• Thinking: 83s wall

---

Findings

None. The diff moves fixed emit-model resolution to bootstrap-filled caches on Dag, keeps missing-meta paths as structured emit errors, and adds a census ratchet so production emit*.rs does not call declaration_by_name again. That matches P2 (single resolution at bootstrap, consumers read one cache) and P3 (missing anchors still surface as errors, not silent defaults). New EmitModelVariants / *Variants types are implementation (Rust on Dag), not new substrate DAG types, so the “new enum needs 🟢/🟡/🔴” rule in docs/modeling-discipline.md does not apply to these record-shaped caches.

The new emit_production_code_has_no_declaration_by_name_calls test (src/v3/compiler/tests/integration/sg0_census_test.rs:43+) is source-scanning policy in an existing SG-0 census file; that is consistent with that module’s role and is not a TESTING.md “pin internal layout of the compiler under test” smell in the sense of lens unit tests.

Verdict

APPROVE — Scoped, aligns emit with cached declaration ids and a documented ROADMAP retirement, with a regression guard. No diff-grounded violations of INVARIANTS.md, docs/modeling-discipline.md, CODING.md, or TESTING.md identified.

[briansrls]

Ready to merge — reviewer sign-off

4 CI green, mergeable, ready-for-review, body has the full audit catalog + R3 debt receipt (4532 chars).

Substantive contributions:

• All 20+ production declaration_by_name sites in src/v3/compiler/src/emit* migrated to bootstrap-populated typed caches (EmitAnchorCache extensions + EmitModelVariants typed sub-struct grouping).
• Audit complete: every site classified (a) substrate-fixed; no caller-provided strings, no diagnostic-only sites needing exemption.
• Cross-validation gate emit_production_code_has_no_declaration_by_name_calls lands fail-closed on future production drift; #[cfg(test)] split correctly excludes test-only fixture lookups without weakening production constraint.
• Population witness ratchets (emit_model_variants_populated_after_bootstrap, emit_anchor_cache_populated_after_bootstrap) catch silent-empty-cache failures at bootstrap time, not emit time.
• ROADMAP:46 closes for production emit; test-only callers correctly excluded from row scope.

Cannot self-approve via API. Director / merge-cap holder may proceed.

— sent from silent-ant-322 (inbox #1133); reply at #1133

[briansrls]

Review metadata

• Provider / model: codex / unknown
• Commit: 1d0c99a4 · Trigger: schedule
• Thinking: 276s wall

---

✅ No blocking concerns found in the mixed code/docs changes.

[briansrls]

Review metadata

• Provider / model: codex / codex-default
• Commit: fb7a680e · Trigger: schedule
• Comparison: origin/main @ 5daa5bba ... review/pr-1638-fb7a680e @ fb7a680e
• Thinking: 62s wall

---

Verdict: APPROVE

No concrete violations found in the diff. The PR moves emit consumers from repeated declaration_by_name/variant-name walks to cached DeclarationId accessors, with fail-closed None/typed error handling at the call sites and a focused census ratchet for production emit code. I did not run builds or tests, per instruction.

[briansrls]

Review metadata

• Provider / model: codex / codex-default
• Commit: 680cee22 · Trigger: schedule
• Comparison: origin/main @ 266d28b3 ... review/pr-1638-680cee22 @ 680cee22
• Thinking: 88s wall

---

Verdict: APPROVE

The diff is narrowly aligned with the rubric: emit-time name lookups are moved behind bootstrap-populated typed DeclarationId caches, consumers continue to fail closed when required anchors are missing, and the new ratchet test guards production emit code against reintroducing Dag::declaration_by_name. No concrete invariant, coding, or testing violations observed in the changed lines.

[briansrls]

Review metadata

• Provider / model: cursor / composer-2
• Commit: d7a0aa70 · Trigger: schedule
• Comparison: origin/main @ b22b9280 ... review/pr-1638-d7a0aa70 @ d7a0aa70
• Thinking: 53s wall

---

Findings

None. The diff matches the intended direction in ROADMAP: emit stops doing production-time declaration_by_name for fixed anchors and instead reads bootstrap-filled caches (EmitAnchorCache / EmitModelVariants), which strengthens P2 (single resolution at bootstrap, consumers read one place) without adding parallel substrate authority. Failure paths still use typed EmitError / EmitPythonError / &'static str where they already did—no new P3 silent-success behavior. New types are implementation caches on Dag, not new Dag-carried substrate.

Verdict

APPROVE — Change is coherent, fail-closed behavior is preserved, and emit_production_code_has_no_declaration_by_name_calls in sg0_census_test.rs gives a clear ratchet for the emit tree layout you have today (flat emit/*.rs).

Exploratory observations (optional)

• dag.rs: emit_model_variants_populated_after_bootstrap asserts many variant slots in one test; TESTING.md prefers one claim per test—splitting would be polish, not a functional issue.
• Cache population still matches variant labels with string literals at bootstrap (same class of knowledge as before, just centralized once); fine for this PR’s scope.

[briansrls]

Review metadata

• Provider / model: openai-pro / gpt-5-5-pro
• Commit: d7a0aa70 · Trigger: manual
• Conversation: View conversation

---

1. Story of the diff

This PR retires the ROADMAP debt row for production emit-time declaration_by_name(...) lookups by moving those fixed emit/model anchors into bootstrap-populated Dag caches. The load-bearing change is in dag.rs: EmitAnchorCache grows method/template anchors, a new EmitModelVariants record caches fixed coproduct constructor DeclarationIds, and bootstrap population resolves the string names once at Dag initialization rather than at each emit parse site (src/v3/compiler/src/dag.rs:2279-2291, src/v3/compiler/src/dag.rs:2361-2376, src/v3/compiler/src/dag.rs:3792-3801, src/v3/compiler/src/dag.rs:3929-4095). The emitters then consume those cached typed IDs and preserve existing malformed-spec/realization errors when an expected anchor is absent, while local named_variant_id helpers disappear from emit modules.

The PR also updates generated bootstrap initializers so the new Dag field is present, adds a unit test proving the cache is populated after normal bootstrap, and adds an SG-0 ratchet that scans production emit* modules for reintroduced .declaration_by_name( calls (src/v3/compiler/src/dag.rs:4486-4570, src/v3/compiler/tests/integration/sg0_census_test.rs:43-77). The ROADMAP row is marked retired with the mechanism and ratchet named explicitly (ROADMAP.md:373).

2. Invariant categories

1. LAYER MODEL (substrate vs implementation) — Compliant. The diff is Dag-adjacent, but the new EmitModelVariants is explicitly a cached projection of existing declaration facts, not a new substrate authority: “Cached variant DeclarationIds for fixed emit-model coproducts” and “Populated once at bootstrap end” are stated at src/v3/compiler/src/dag.rs:2361-2363. Emit-side consumers read the cached IDs through dag.emit_model_variants() rather than re-resolving names in target code, for example src/v3/compiler/src/emit.rs:1271-1275 and src/v3/compiler/src/emit/rust_target.rs:1467-1487.
2. INVARIANTS.md + modeling-discipline.md — Compliant. This is a single-authority/facts-flow-forward improvement: fixed declaration facts are resolved once into Dag caches (src/v3/compiler/src/dag.rs:3929-4095) and then read by emit consumers. Fail-closed behavior is preserved where missing cache entries become existing typed errors rather than fabricated defaults, for example EmitError::MalformedRealization at src/v3/compiler/src/emit.rs:2780-2791 and EmitError::MalformedTargetSyntax at src/v3/compiler/src/emit/rust_target.rs:2255-2267.
3. CODING.md — Compliant. The new implementation follows the repo’s data-plus-functions direction: the cache is plain data (src/v3/compiler/src/dag.rs:2365-2376), Dag exposes narrow typed accessors such as emit_model_variants() (src/v3/compiler/src/dag.rs:3191-3194), and emit parsing remains in free functions that convert absent data into structured errors. The method-contract helper also now receives the cached declaration ID through method_template_contract_decl() instead of doing its own name lookup (src/v3/compiler/src/emit/collection_ops_method_contract.rs:16-18).
4. TESTING.md — Compliant. The diff adds the right two levels of tests for this change: a bootstrap/unit-style presence check that every new emit-model cache slot is populated by Dag::new() (src/v3/compiler/src/dag.rs:4486-4570), and an integration ratchet that scans production emit modules and fails if .declaration_by_name( returns there (src/v3/compiler/tests/integration/sg0_census_test.rs:43-77). Since the PR is a lookup-authority refactor rather than a new user-visible emit behavior, I do not see a missing behavior regression test.
5. LOCKED DESIGN DECISIONS — N/A. The diff retires a ROADMAP debt row and changes Rust implementation/cache plumbing; it does not reference or alter a locked thesis/design decision.
6. TRACKED vs UNTRACKED DEBT — Compliant. This closes tracked debt rather than adding an untracked bridge: ROADMAP.md:373 names the retired row, the mechanism (EmitAnchorCache / EmitModelVariants), and the ratchet (emit_production_code_has_no_declaration_by_name_calls). The ratchet is present in the diff and bounded to production src/v3/compiler/src/emit* code at src/v3/compiler/tests/integration/sg0_census_test.rs:43-77.

3. Verdict

APPROVE

The PR consistently moves distributed emit-time string lookup into a single bootstrap-populated Dag cache, preserves fail-closed error paths at use sites, and adds both population and reintroduction ratchets. I did not find a diff-line-backed invariant violation.