snappy-koi-58

ROADMAP.md

@@ -370,7 +370,7 @@ Per-row tagging is a scheduled follow-up sweep — **trigger:** post-merge of th
 
 ### P3 — modeling gaps
 
-- **`declaration_by_name(...)` pattern in emit** — 20 sites on `origin/main`, including `emit.rs`, `emit/rust_target.rs`, `emit/python_target.rs` looking up `"OrderedRing"`, `"SubstrateAccessorBinding"`, `"Dag"`, `"fold"`, `"id"`. Violates Layer Opacity / Semantic Authority (post-lowering). Dissolution: typed substrate access via cached declaration-id (`algebra_field_for_operator` pattern) at every call site.
+- **~~`declaration_by_name(...)` pattern in emit~~** — **RETIRED 2026-05-04 (PR #1638)**. Audit found the production emit callers were fixed substrate / emit-model anchors, not caller-provided program strings: `MethodEmitTemplate`, `MethodTemplateContract`, collection method anchors (`concat_method`, `length_method`, `fold_method`, `is_empty_method`), and fixed emit-model coproduct variants (`PatternStrategy`, `FieldAccess`, `ParameterDisposition`, `MemoryModel`, `ScopeModel`, Rust rendering/computation-model variants). Dissolved by extending the bootstrap-populated `Dag` typed caches (`EmitAnchorCache` / `EmitModelVariants`) and replacing emit-time string lookups with cached `DeclarationId` reads. Ratchet: `emit_production_code_has_no_declaration_by_name_calls` fails closed if production `src/v3/compiler/src/emit*` code reintroduces `Dag::declaration_by_name`; test-only fixture lookups remain outside the row scope.
 - **`pipeline_authority.rs` (case 2c):** runtime stage order is **structural** (`PipelineStageBinding` declaration order only). `fn compile` body vs binding drift check is **suspended** (PR #1171): `compile` stays `ArrowBody::Unparsed` — no lowered ordered stage list without a source-text channel; neither `include_str!` nor `read_to_string`+slice satisfies R3 for that reconcile. Dissolution: single typed carrier or structural compile body.
 - **LLM service flattening**: `dsl/extdeps/llm/llm.dag` declares `Role`, `ContentBlock`, `LlmMessage`, `StopReason`; Anthropic/OpenAI service operations still take `model: String`, `messages: Json`, and extract outputs by string path. Dissolution: service operations consume the typed carriers; outputs returned as typed responses. **Typed request JSON vs wire (e2e risk):** closure trigger identifier `rest_request_wire_serde_alignment` — Anthropic request payload coproducts carry source-level `CoproductWireContract` rows for message `role` and content-block `type` tagging, ratcheted by `anthropic_request_coproduct_wire_contracts_emit_targeted_serde` and `anthropic_messages_request_body_json_matches_messages_wire_tags`; `structural_coverage_gap_anthropic_messages_request_wire` is retired for those outer request coproduct discriminators. Nested Anthropic tool-result `content` still needs scalar-text vs content-block-array wire serde and remains tracked by `structural_coverage_gap_anthropic_tool_result_content_wire_shape`; additive document/search/tool-reference nested blocks remain tracked separately by `structural_coverage_gap_anthropic_tool_result_additive_blocks`. OpenAI Chat Completions narrow-row `messages[].role` for `OpenAiChatMessageRole` is ratcheted by pipeline test `openai_chat_message_role_wire_matches_llm_snake_contract` (`src/v2/tests/src/pipeline.rs`) against `data wire_contract: VariantEncoding = llm_snake_wire_contract` in `dsl/extdeps/llm/openai.dag` (same M2 pattern as Anthropic: module-local `wire_contract` names the single `llm_snake_wire_contract` authority in `extdeps.llm.llm`; emitter derefs `init.inferred` / `Resolved` per `resolve_wire_serde_policy_for_coproduct` in `05_emit_rust.dag`). `v2.compiler.emit_rust` authorizes coproduct serde from `CoproductWireContract` rows targeting local coproduct declarations, then module `wire_contract`, then the tagged-object default; stale local contract targets emit `compile_error!`. The old `structural_coverage_gap_openai_chat_request_messages_wire` row was removed when that receipt landed; tracker [#987](https://github.com/gunb-ai/gunbc/issues/987).
 - **GitHub auth model bypass**: `dsl/extdeps/github/github.dag:42-46` declares `GitHubAuthToken { token, scopes, expires_at }` but `dsl/extdeps/github/auth.dag:13-23` returns only `{ token: Secret }` and hardcodes GCP secret-manager policy. Dissolution: `github_token()` returns the full typed token; remove the hardcoded provider policy.

src/v3/compiler/src/bootstrap_generated.rs

@@ -21,6 +21,7 @@ pub(crate) fn bootstrapped_fixture_dag() -> Dag {
         ),
         verifier_output_policy_variants: VerifierOutputPolicyVariants::default(),
         callable_strategy_variants: CallableStrategyVariants::default(),
+        emit_model_variants: EmitModelVariants::default(),
         clusters: bootstrapped_fixture_dag_clusters(),
         optional_match_disjs: bootstrapped_fixture_dag_optional_match_disjs(),
         declaration_append_begin_after_bootstrap: 2317,

src/v3/compiler/src/bootstrap_generated_without_parse_surface.rs

@@ -21,6 +21,7 @@ pub(crate) fn bootstrapped_fixture_without_parse_surface_dag() -> Dag {
         ),
         verifier_output_policy_variants: VerifierOutputPolicyVariants::default(),
         callable_strategy_variants: CallableStrategyVariants::default(),
+        emit_model_variants: EmitModelVariants::default(),
         clusters: bootstrapped_fixture_without_parse_surface_dag_clusters(),
         optional_match_disjs: bootstrapped_fixture_without_parse_surface_dag_optional_match_disjs(),
         declaration_append_begin_after_bootstrap: 2234,

src/v3/compiler/src/bootstrap_std_generated.rs

@@ -21,6 +21,7 @@ pub(crate) fn bootstrapped_std_fixture_dag() -> Dag {
         ),
         verifier_output_policy_variants: VerifierOutputPolicyVariants::default(),
         callable_strategy_variants: CallableStrategyVariants::default(),
+        emit_model_variants: EmitModelVariants::default(),
         clusters: bootstrapped_std_fixture_dag_clusters(),
         optional_match_disjs: bootstrapped_std_fixture_dag_optional_match_disjs(),
         declaration_append_begin_after_bootstrap: 607,