Repository navigation
chore(template): per-PR debt-paydown receipt section - #1532
Merged
Merged
Conversation
This was referenced May 2, 2026
briansrls
added a commit
that referenced
this pull request
May 4, 2026
* docs(r3): narrow PR-E E6-G0 first-gate ordering Picks the first truly unblocked E6-G0 slice after `workflow_root_port` (Prereq-3a) landed: `lens_value_generic_conj_field_substitution_lands` (structural data-body checking substitutes instantiated generic Conj fields). Sequences the existing post-blocker gate packet's evaluator field/call API as E6-G0b and Prereq-X1.a static call-on-field-access as E6-G0c, and explains why parametric `fold_lens<C>` (E6-G2) waits on the Prereq-X1.b `TransformDispatch::Indirect` substrate collapse. Classifies `fold_lens<C>` in `.dag` as not authorable today: parser ratchet (`prereq_x_call_on_field_access_ratchet_test`), substrate substitution gap (lens-value-authoring-stop), and missing `TransformDispatch::Indirect` for the parametric body each block independently. Preserves `fold_lens_over_reflected_program` as the reflect→apply compatibility seam. Docs-only. No substrate, parser, lowerer, evaluator, or test_runner edits. Closes #1532 receipt: N/A — no hand Rust under `src/v3/` changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): swap exact-line citations to symbol anchors in E6-G0 brief Replaces `substrate.dag:585-616` and `lib.rs:556-561` with symbol anchors (`WorkflowRoot` / `workflow_root_port`, `evaluator::eval_transform_node`) so the brief survives source drift. The original ranges did match `origin/main` at review time; this is a forward-looking robustness change per reviewer suggestion. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks done
briansrls
added a commit
that referenced
this pull request
May 4, 2026
…#1657) * docs(r3): worker brief for E6-G0b Prereq-X1.a static field-call slice Decomposes the X1.a slice into one landable PR after Substrate G0a (#1640) merged. Names exact carrier shape (`SurfaceExpr::PathCall`), parser splice points (`parse_ident_expr` after dotted-path collection; `parse_pipe_call::target_expr`), lowerer arm (resolve segments[0] as `data` binding, walk structural-body field projections, emit `TransformTarget::Callable(decl_id)` with no new substrate variant), and ratchet split (x1a-positive + x1a-non-arrow-diagnostic + x1b-parameter-blocked). Pins x1b/X3/X2/parametric-fold blockers red. Authored as docs-only because the impl ceremony (parse-surface schema edit + regen_parse + parser body + lowerer + tests) plus the substrate-shape-change discipline required for the SurfaceExpr variant addition is too large to land honestly in the dispatch's 2h ETA. The brief is tight enough that the next worker can implement directly. Closes #1532 receipt: N/A — no hand Rust under `src/v3/` changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): require carrier-addition discipline in X1.a worker brief Manager review (#1657) flagged that the parse-surface SurfaceExpr variant addition needs explicit substrate-shape discipline in the implementation PR body, not implicit. Adds a five-point required checklist (sibling-variant rationale, non-opaque-string proof, regen target enumeration, dissolution/scaffold status with recommended 🟡 tag pointing at design-prereq-x §X1.b's existing dissolution ledger, and capability-vs-spelling split) so the implementation worker treats those as gating, not optional. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): add P5 paired-dispatch section to X1.a worker brief Acceptance Cursor review (#1657) flagged that the Acceptance section did not explicitly name the dissolution trigger, the relevant ROADMAP debt row, or the contributes-vs-defers split per INVARIANTS P5. Adds a "Paired-dispatch / dissolution discipline" subsection that: - Names PathCall's dissolution trigger (CalleeRef substrate carrier landing per design-prereq-x §X1.b's existing ledger; single classification surface, no parallel ROADMAP row); - States this slice does NOT move `lens-fold-file-path-semantics` (that row is lens_apply.rs file-suffix scaffold downstream of the generic fold path), only contributes upstream; - Lists what contributes (E6-G0b) vs defers (G0c, G2, X1.b, X2, X3, file-path-semantics cleanup). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/PULL_REQUEST_TEMPLATE.md.INVARIANTS.md §P5(c).No debt touched.Test plan
cargo fmt --all --check