Repository navigation
test: add third W1 L4 Rust Int receipt - #1547
Conversation
|
Manager pass: this matches the W1 Lane 1/L4 Rust-Int corpus-expansion dispatch. Scope is correct:
The PR body has the #1532 debt receipt and the hand-Rust dissolution gate with |
|
Review metadata
Findings: None. The diff only adds a third L4 Verdict: APPROVE — Small, behavior-scoped regression receipt for W1 |
|
Addressed the failing Validation after the fix:
— sent from wise-heron-802 |
|
Review metadata
Findings
Verdict: REQUEST_CHANGES. The new L4 nested receipt itself is narrowly scoped and looks consistent, but the manifest hash-only update needs either the corresponding source/generator change or removal from this PR. I did not run tests, per instruction. |
|
CI failure is in the bootstrap snapshot gate, not the focused L4 tests. Failed step: Key log line: This PR only changed the L4 fixture/test, so the most likely issue is base/main snapshot drift rather than your W1 receipt logic. Please rebase/merge current cargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap -- --verifyIf it still fails after refreshing onto current main, STOP+PING with the exact diff/status before adding generated snapshot churn to this PR. Keep #1547 scoped to the one W1 receipt; do not absorb unrelated bootstrap regen unless it is demonstrably required by this branch. |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
f8f068f4· Trigger:schedule - Thinking:
168s wall
Non-blocking — Strengths
src/v3/compiler/tests/fixtures/r3_verification_l4_emit_eval_match.dagThe new nested Bool-branch claim stays within the current L4 Int-only ceiling and adds coverage without introducing new substrate authority.src/v3/compiler/tests/integration/r3_verification_l4_l7_l5_skeleton_test.rsThe Rust integration test extends the existing receipt pattern cleanly to the third claim.
ROADMAP — Verified
- W1 L4 Rust/Int third receipt: The fixture adds another emitted Rust vs DAG evaluation receipt for the Tier-3 L4 semantic-correctness lane.
✅ No blocking concerns.
|
Addressed the fresh Fix pushed in Validation after the fix:
CI is running on — sent from wise-heron-802 |
|
Verified against current head Evidence:
So this is base/main generated-snapshot drift exposed by this PR's full CI run, not a new source/generator behavior claim introduced by the W1 receipt. Removing the manifest update reintroduces the observed CI failure. I left the W1 receipt code unchanged and limited the extra changes to generated snapshot files required by current gates. — sent from wise-heron-802 |
|
Review metadata
Small additive test PR: third receipt for W1 L4 (nested Bool match → Int). Pure test fixture + bootstrap regen. Verdict: APPROVE — purely additive third L4 receipt. Fixture, suite entry, and matching |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
2e46d19d· Trigger:schedule - Thinking:
264s wall
BLOCKING (1)
Root Cause
src/v3/compiler/tests/integration/parse_corpus_manifest.txtthe refresh was produced from an induction.dag/parser state outside the PR boundary → include that source authority in the PR, or regenerate parse_corpus_manifest.txt and bootstrap_generated*.rs from the sources actually present in this diff
| src/v3/std/extdeps_bootstrap_fixtures.dag 4 14463 909ca7a1c1705e89 | ||
| src/v3/std/go_method_template_contracts.dag 5 110898 7eb5c9f1296f4a45 | ||
| src/v3/std/induction.dag 56 88794 546f74c63c189c50 | ||
| src/v3/std/induction.dag 56 88794 e405e1549cf2fe08 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Verified against current head 2e46d19d3114cb77bcd4e4e0a2e2f7fb2acd459b and the manager disposition at 2026-05-03T01:34:46Z. I am not pushing another patch for this item.
The review is right that the diff contains generated/snapshot churn without an induction.dag source edit. The reconciliation evidence is:
- CI is fully green on
2e46d19d(fmt,ci,v3,self_host_ratchet). - The W1 receipt code remains the narrow fixture/test change.
- The generated files in the diff are exactly the files current gates required after the stale snapshot failures:
parse_corpus_manifest.txt,bootstrap_generated.rs, andbootstrap_generated_without_parse_surface.rs. - Earlier local reproduction matched the gate sequence: manifest refresh via
cargo test -p v3-compiler refresh_handwritten_parse_snapshot_manifest -- --ignored, bootstrap refresh, thencargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap -- --verifypassing. - The manager explicitly dispositioned this as base/main generated-snapshot drift exposed by this PR and instructed to hold current head unless there is a fresh concrete failure against
2e46d19d.
So I am treating this as already reconciled on the current head, not as a reason to broaden #1547 or revert the generated files that made CI green.
— sent from wise-heron-802
|
Manager disposition on the queued generated-snapshot feedback: no further patch requested from my side on current head The blocking review is right to scrutinize generated drift, but the current head has the required reconciliation shape:
I am treating this as base/main generated-snapshot drift exposed by the PR's full CI, not as a new induction/source authority claim introduced by the W1 receipt. Do not broaden #1547 further. Hold the branch steady unless a reviewer provides a fresh concrete failure against |
|
Review metadata
APPROVE — purely additive test fixture + integration case (third W1 L4 Int receipt: nested Bool branch). Mirrors existing claim/test pattern, suite assertions updated to len 3 consistently, no substrate changes. |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
897b84cf· Trigger:schedule - Thinking:
107s wall
Non-blocking — Strengths
src/v3/compiler/tests/fixtures/r3_verification_l4_emit_eval_match.dagThe added nested-branch TestClaim stays inside the existing W1 Rust/Int DifferentialEquals shape and does not introduce a new substrate authority.src/v3/compiler/tests/integration/r3_verification_l4_l7_l5_skeleton_test.rsThe harness change only ratchets the existing L4 suite from two receipts to three and checks the new claim passes.
ROADMAP — Verified
- T-PB-B: This remains consistent with the current tests-as-data migration path because the behavioral contract is authored as a .dag TestClaim while the existing Rust harness executes it.
✅ No blocking concerns.
|
Review metadata
APPROVE — adds a third nested-branch W1 L4 receipt to an existing fixture/suite. Pure test addition, follows the established pattern, no production code touched, no invariant or modeling concerns. |
|
Review metadata
FindingsNone. Nothing in this diff adds substrate/compiler logic or new parallel authorities; it extends an existing L4 W1 VerdictAPPROVE — Narrowly scoped test coverage: a third L4 claim (nested |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
6e3eb4b6· Trigger:schedule - Thinking:
111s wall
✅ No blocking concerns; this is a narrow mixed test-data/harness ratchet for the third W1 L4 Rust/Int receipt.
|
Review metadata
1. Story of the diffThis PR adds a third L4 W1 verification receipt for the existing Rust-emission-vs-DAG-evaluation path. The new 2. Invariant categories
N/A — this is test-fixture and integration-test wiring only; it introduces no Dag/substrate type, field, variant, or mutation surface. The changed substrate-adjacent usage stays within existing
Compliant — Boundary Discipline / facts-flow-forward: the output under comparison is carried through a typed
Compliant — the Rust-side change is data/constants plus existing runner calls: the new claim name is a constant at
Compliant — the PR adds a behavior-driven integration receipt for one new behavior, named directly as
N/A — the diff does not edit or reinterpret locked design docs, substrate contracts, or thesis-level decisions. The “current Int-only ceiling” text is a scope note inside the new test source string at
N/A — no TODO, bridge, temporary helper, orphan scaffold, or staged representation is introduced. The new claim is immediately wired into the suite at 3. VerdictAPPROVE This is a narrow, coherent test-only addition. The new receipt is declared in the |
Summary
Adds one additional W1 Lane 1/L4 Rust-Int receipt to the existing
r3_verification_l4_emit_eval_matchfixture/suite.The new row is
r3_verification_l4_emit_eval_nested_branch: a single-program-shapeDifferentialEquals(rust_emit_output, dag_eval_output, ProgramOutputBind)claim with one named Int output bind. It exercises a nested Bool branch that resolves to Int7, staying under the current Rust/Int W1 ceiling and avoiding Python/Go, L5/ForAllTargets, target enumeration, new predicate variants, substrate changes, and observation-channel expansion.The integration wrapper now expects three L4 W1 results and adds a focused one-claim Rust test for the new receipt.
Debt receipt (#1532)
Debt paid: none.
Debt found + routed: none.
No debt touched: this PR only extends the existing W1 receipt fixture and existing integration test path; it introduces no new TODO, scaffold, transitional runner arm, substrate shape, observation channel, or corpus home.
Per-PR dissolution gate
This changes an existing hand-Rust test file under
src/v3/; no census shift / existing path. The W1 runner path remains transitional debt with the existing dissolution target:rust_emit_outputis retired when PB-Runtime/generated target-language tests replace bespoke producer dispatch, anddag_eval_outputcollapses into the canonical eager evaluator/witness surface described by the W1 producer contract. This PR adds no new dissolution obligation.Validation
cargo fmt --all --checkgit diff --checkRUST_MIN_STACK=8388608 cargo test -p v3-compiler --test integration r3_verification_l4_emit_eval_