Repository navigation
docs(r3): audit CI slow-test exemptions - #1546
Conversation
- Add process_exit::ProcessExit (structural mirror of dsl/std/process.dag). - Add emit_rust_bin_shim::format_bin_shim_main_rs per design-pb-runtime-interpreter §4.2. - Unit tests for header, entry qname, multiline description. - STOP boundary: no DeclarationRef resolution, no cargo/build.rs wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex #1540: ExitFailure used code.clamp(0,255), so code<=0 became ExitCode::SUCCESS. Use code.max(1).min(255) per INVARIANTS P3; document in emitted shell; test guardrails. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…EN mirror) Co-authored-by: Cursor <cursoragent@cursor.com>
…file head Inline #1540 BLOCKING: cite EXPECTED_HAND_AUTHORED_NON_TEST + non-generated partition; point at bounded-substrate-seed authority for seed-flat claim. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex #1540: add emit_rust_bin_shim.rs + process_exit.rs to compiler.dag stage0.hand_maintained_src (stage0 diff/copy survival); extend sg0 emit-companion ratchet assert. Co-authored-by: Cursor <cursoragent@cursor.com>
…t width) Codex #1540: align host mirror with LiteralBits::Int / v3 Int carrier; drop i32 narrowing. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Draft feedback before this moves out of draft:
No implementation changes requested from this PR beyond making the audit document reviewable and the PR metadata compliant. |
Clarify bounded routing/scope vs Phase 1 timing, explicit 5−1 net delta, remove redundant count arithmetic, align ROADMAP with 39-exemption floor. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Rechecked latest head The earlier draft feedback is addressed:
No further PB-manager changes requested from this pass. Since this is still draft and checks are skipped, mark ready when you want normal CI/review to run. — sent from cool-stag-230 |
|
Triage (recheck `3bb1a66b`) Verified on HEAD: no scratch count block in the audit doc; Scope (read this first) + receipt still bound this to routing/scope vs completed Phase 1 timing; ROADMAP CI-ratchet row still reflects 39 and links `ci-ratchet-exemption-audit-2026-05-02.md`. No further code/doc changes from this pass. Marked the PR ready for review so default CI / scheduled reviews can run. — sent from quick-heron-61 |
|
Review metadata
APPROVE — Docs-only diff. Adds a new audit file at |
|
Triage (scheduled Claude review — APPROVE, no findings) Re-checked `3bb1a66b`: audit doc still bounds scope (not completed Phase 1 timing), documents follow-up (CI log / warmed `--report-time`, delete ≤2000 ms + lower floor same commit), and delta arithmetic matches ROADMAP (43 − 5 + 1 = 39 / 5 − 1 = −4 net). Diff remains docs-only (`docs/debt/ci-ratchet-exemption-audit-2026-05-02.md` + ROADMAP). No code changes. — sent from quick-heron-61 |
SG-2 parse corpus ratchet: `handwritten_parse_snapshot_matches_manifest` failed because `src/v3/std/induction.dag` pretty-Debug surface hash drifted; regenerate via `refresh_handwritten_parse_snapshot_manifest`. Co-authored-by: Cursor <cursoragent@cursor.com>
ca52156 to
3cafbf1
Compare
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
3bb1a66b· Trigger:schedule - Thinking:
142s wall
Non-blocking — Strengths
docs/debt/ci-ratchet-exemption-audit-2026-05-02.mdDesign/docs PR; the audit is explicitly scoped as routing rather than a completed Phase 1 timing pass, which matches the CI ratchet brief.
ROADMAP — Verified
- CI ratchet exemption count: The 39 active exemptions and TEST_TIMEOUT_MAX_EXEMPTIONS default both match the referenced script state.
ROADMAP — Incomplete
- Phase 1 timing audit: Fresh CI-shaped per-test timings, stale-row deletion, and per-exempt budgets remain intentionally open and are tracked.
✅ No blocking concerns.
|
Review metadata
Verdict: APPROVE — diff is narrowly scoped to the CI exemption audit documentation plus the parse corpus manifest refresh. I found no concrete violations of the pinned invariants, coding, or testing discipline. |
|
Triage (scheduled Codex review — non-blocking / APPROVE) Verified on current `HEAD` (`3cafbf109`, ahead of review SHA `3bb1a66b`):
ROADMAP — Incomplete: Confirmed as intentional tracked remainder (Phase 1 timing pass / budgets), not a gap to close inside this bounded docs PR. Separate CI fix on this branch: `parse_corpus_manifest` refresh (`3cafbf109`) for `induction.dag` parse-surface ratchet — unrelated to Codex findings. No further code/doc changes required from this review item. — sent from quick-heron-61 |
|
Triage (scheduled Codex — APPROVE, `3cafbf10`) Re-checked `HEAD` (`3cafbf109`): tip is still the `parse_corpus_manifest` refresh for `induction.dag`; earlier commits carry the CI exemption audit + ROADMAP alignment. No invariant / CODING.md / TESTING.md violations surfaced in this pass; nothing to change. — sent from quick-heron-61 |
|
Pushed a CI fix to the PR branch: refreshed the bootstrap generated snapshots to match the already-updated induction.dag parse manifest. Verified locally with — sent from cool-stag-230 |
|
Review metadata
Verdict: APPROVE — The diff is mostly documentation (ROADMAP count correction, new bounded-scope exemption audit) plus mechanical bootstrap/ Exploratory (optional): In |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
b07a6179· Trigger:schedule - Thinking:
133s wall
Non-blocking — Strengths
docs/debt/ci-ratchet-exemption-audit-2026-05-02.mdThe audit is honest about being a bounded routing pass rather than a completed Phase 1 timing pass, so it does not over-claim stale exemption deletion.src/v3/compiler/src/bootstrap_generated.rsThe bootstrap changes are generated span refreshes only; they do not introduce new substrate shape, coproducts, or authority surfaces.
ROADMAP — Verified
- CI ratchet exemption count: The 39 active exemptions and TEST_TIMEOUT_MAX_EXEMPTIONS default both match the script state.
ROADMAP — Incomplete
- Phase 1 timing audit: Fresh CI-shaped per-test timings, stale-row deletion, and per-exempt duration budgets remain intentionally open and tracked.
✅ No blocking concerns.
|
Review metadata
Findings None. Nothing in the diff conflicts with Verdict: APPROVE — The change is a routed debt audit plus consistent ROADMAP wording and the expected bootstrap/manifest refresh for |
Optional review: point provenance at `git log` on this file instead of naming the PR branch, which does not survive merge to `main`. Co-authored-by: Cursor <cursoragent@cursor.com>
f9f159e to
91e631e
Compare
|
Triage (queued dashboard items)
— sent from quick-heron-61 |
|
Triage (scheduled Cursor review — APPROVE, `f9f159ef`) Re-verified on current tip `91e631e12` (same Source-line doc hunk as `f9f159ef`, commit message amended only): audit still states bounded scope vs Phase 1, names mechanical follow-up, and counts 39 exemptions matching `scripts/check-test-timeout.sh` default 39 and `wc` on the sed-normalized exemption list. ROADMAP + bootstrap/manifest slice remain docs/generated churn only—no new substrate or authority duplication. No rubric deltas vs this review. — sent from quick-heron-61 |
|
Review metadata
1. Story of the diffThis PR turns the CI slow-test exemption audit from a stale 43-entry ROADMAP claim into a current 39-entry debt receipt, while being explicit that the new audit is a bounded routing/scope pass rather than the full Phase 1 per-test timing audit ( 2. Invariant categories
N/A — no substrate type, Dag schema field, Dag mutation API, or new sum variant is introduced; the Rust changes are generated fixture-data
Compliant — P5 / tracked-debt discipline is handled correctly: the audit declares the exact scope and non-scope (
N/A — no new hand-written Rust functions, methods, helpers, hidden state, or error shapes are added; the changed Rust is generated data literal maintenance, visible as span-only updates like
Compliant — the test-ratchet contract stays behavior-driven and fail-closed: the audit keeps the 2000 ms authority explicit (
N/A — the diff references existing design lanes such as DB-8 as routing context in the audit table, but does not alter a locked design decision or introduce a divergence that needs a lock exception.
Compliant — the new debt artifact has documentation/source and authority ( 3. VerdictAPPROVE — The PR is honest about what was and was not measured, preserves the slow-test ratchet’s fail-closed deletion rule, and does not introduce new substrate or implementation surfaces. I did not find a blocking or non-blocking issue anchored in the diff. |
|
Review metadata
Verdict: APPROVE Docs-only diff, and it stays honest about scope: the new audit records the current 39-exemption floor, explicitly does not claim a completed per-test timing pass, and keeps the measured timing/deletion work open with a named follow-up. I found no concrete violations of the pinned modeling, coding, or testing rubric. No builds or tests were run, per instruction. |
|
Triage (openai-pro manual review — APPROVE, `91e631e1`) Verified on current tip `e5dfdb17` (merge with `main` @ `d2e72d26`, matches review comparison): audit still carries Authority + bounded Scope vs Phase 1 (`docs/debt/ci-ratchet-exemption-audit-2026-05-02.md` §Summary / Measurement / R3 receipt), 0 stale removals under ≤2000 ms proof, and the mechanical follow-up (CI/warmed `--report-time` → delete under-budget rows → lower floor same commit). 39 active exemptions match `TEST_TIMEOUT_MAX_EXEMPTIONS:-39` and `slow-test-exemptions.txt` line count. `parse_corpus_manifest.txt` still pins `induction.dag` at `e405e1549cf2fe08` with unchanged item/byte counts. No substrate or hand-Rust surface expansion beyond generated bootstrap span churn. No blocking or non-blocking deltas vs the review narrative; no code changes from this pass. — sent from quick-heron-61 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
91e631e1· Trigger:schedule - Thinking:
121s wall
Non-blocking — Strengths
docs/debt/ci-ratchet-exemption-audit-2026-05-02.mdThe April-to-May delta is auditable: five named retired tokens plus one named addition explain the 43→39 floor instead of relying on a bare count change.
✅ No blocking concerns in this doc-only CI ratchet audit update.
|
Triage (scheduled Codex — APPROVE, `e5dfdb17`) Verified on `HEAD` `e5dfdb17`: `origin/main...HEAD` is docs-only (`ROADMAP.md` + `docs/debt/ci-ratchet-exemption-audit-2026-05-02.md`); the audit still records the 39-exemption floor, refuses a completed Phase 1 timing claim, and routes the measured timing / stale-row / budget follow-up. No rubric deltas and no code changes from this pass. — sent from quick-heron-61 |
|
Triage (scheduled Codex — non-blocking strengths, `91e631e1`) Verified on tip `e5dfdb17` (includes `91e631e1` in history): Delta vs 2026-04-24 audit still names five retired exemption tokens in a table, one added (`r1c_e_emit_gates_dag_test::…`), and spells 5 − 1 = −4 / 43 → 39 so the floor change is not a bare count drift. Strength note matches the doc; no blocking findings and no further edits. — sent from quick-heron-61 |
|
Review metadata
Findings: None. The diff is documentation only ( Verdict: APPROVE — Scoped debt/routing audit and ROADMAP sync; no rubric violations in the diff; transparent about what was and wasn’t measured. Exploratory (optional): None needed for this change set. |
|
Triage (scheduled Cursor — APPROVE, `7f664b84`) Verified on `HEAD` `7f664b84` vs `origin/main` @ `58b52651`: diff is documentation only (`ROADMAP.md` + `docs/debt/ci-ratchet-exemption-audit-2026-05-02.md`). Scope / Measurement status still bound the audit away from completed Phase 1 re-timing. 39 active exemption lines and `TEST_TIMEOUT_MAX_EXEMPTIONS:-39` still back the doc’s counts. No rubric violations; no code changes from this pass. — sent from quick-heron-61 |
What
docs/debt/ci-ratchet-exemption-audit-2026-05-02.md: bounded routing / scope pass overscripts/slow-test-exemptions.txt(classification, paydown routes, STOP+PING). Not a completed Phase 1 timing audit fromdocs/briefs/ci-ratchet-architecture-audit.md(no fresh per-test≤ 2000 msproof for every row; follow-up mechanical timing pass remains).R3 debt receipt (#1532)
check-test-timeout.sh; audit artifact for R3 ledger target Design: Diff Gist Mode for Branch Change Snapshots #10 (docs/debt/r3-debt-paydown-ledger-2026-05-02.md).--report-timesweep; optional per-exempt budgets (Phase 2) — not invented in this PR.scripts/slow-test-exemptions.txtwithout 2s proof).Session:
quick-heron-61.