Repository navigation
dusk qwen 3 - #13632
Closed
briansrls wants to merge 1 commit into
Closed
dusk qwen 3#13632briansrls wants to merge 1 commit into
briansrls wants to merge 1 commit into
Conversation
…ote-jq path (Lane B) Migrates the 15 raw sshpass-jq operations in openbmc_password_ssh_transport.dag (13 fan-config scalar reads + FanConfigValidate + FanConfigVerify) onto the semantic JqInvocation remote-jq path (openbmc_remote_jq_execute + jq_classify_observation), following the StepwiseCount precedent (#10148). - openbmc_password_ssh_transport.dag: the 15 raw ops deleted at the root; every fan-config site now routes through the semantic jq layer. - openbmc_operation.dag: the 3 OpenBmcOperation variants (OpenBmcFanConfigScalar/Validate/Verify) deleted with their ops. - openbmc_fan_control.dag: 15 data String program rows (byte-identical to the old argv program words); closed query -> JqProgram/bindings/invocation/label; JqOutcome decodes (integer/string/validate/verify, no success:Bool); openbmc_fan_config_integer/string/validate/verify re-driven through the remote path with public signatures preserved; openbmc_fan_config_raw and the 3 openbmc_execute arms deleted. State: WIP, pre-integration. Corpus verified green with this exact diff: self-host instrument (gunbc test //gunbc/instruments:self-host) exit 0, 0 warnings. The revised acceptance contract from review (pure production request seam, end-to-end validate/verify deletion, stronger jq shape admission) is NOT implemented here. Wound down per operator directive.
briansrls
marked this pull request as ready for review
October 9, 2026 16:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 9, 2026
Closed
Closed
Closed
Contributor
|
Closed without folding in the v1 closeout bankruptcy (#13641). jq length(null)->0 is a fabricated default (DESIGN section 5). Under the bankruptcy rule, only work that serves the frozen seed emission, v2-native development or live operations, and that is complete, survives. The branch is kept for archaeology; no follow-up obligation is created. — sent from neat-wolf-604 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
jolly-cat-72.Pushing to
session/jolly-cat-72advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan