Repository navigation
qwen babysitter - #13652
Closed
gunbai-bot[bot] wants to merge 4 commits into
Closed
qwen babysitter#13652gunbai-bot[bot] wants to merge 4 commits into
gunbai-bot[bot] wants to merge 4 commits into
Conversation
…s tool module, not hand-typed Replace the two hand argv literals in the fleet reach/identity probe with home-module builders, dissolving the last hand argv in that module (roadmap shell-dag-host-reach-identity-probe; Lane B of the transport-argv anemia dissolution). - extdeps.tools.id: id_user_name_argv() -> [id, -un] (login name, no operand: id(1) with no operand answers from the calling process's own credentials, which is exactly the account the SSH session IS). - extdeps.tools.hostname: hostname_read_argv() -> [hostname] (bare, full configured name). The -s decision the row's first_slice names resolves to the bare read: the probe compares its output for exact equality against the enrolled short slot label, so -s (first label) would re-derive a label. - host_reach_identity_probe: probe_reachable_with_principal and probe_ready_target_once now call id_user_name_argv() and hostname_read_argv() instead of the literal [id,-un] and [hostname]. - witness: the_probe_argv_is_spelled_by_its_tool_module_builders pins each builder's materialized argv to the exact words the probe has always executed, so the flags cannot drift out from under the builder.
…ote-jq path (Lane B) Migrates the 15 raw sshpass-jq operations in openbmc_password_ssh_transport.dag (13 fan-config scalar reads + FanConfigValidate + FanConfigVerify) onto the semantic JqInvocation remote-jq path (openbmc_remote_jq_execute + jq_classify_observation), following the StepwiseCount precedent (#10148). - openbmc_password_ssh_transport.dag: the 15 raw ops deleted at the root; every fan-config site now routes through the semantic jq layer. - openbmc_operation.dag: the 3 OpenBmcOperation variants (OpenBmcFanConfigScalar/Validate/Verify) deleted with their ops. - openbmc_fan_control.dag: 15 data String program rows (byte-identical to the old argv program words); closed query -> JqProgram/bindings/invocation/label; JqOutcome decodes (integer/string/validate/verify, no success:Bool); openbmc_fan_config_integer/string/validate/verify re-driven through the remote path with public signatures preserved; openbmc_fan_config_raw and the 3 openbmc_execute arms deleted. State: WIP, pre-integration. Corpus verified green with this exact diff: self-host instrument (gunbc test //gunbc/instruments:self-host) exit 0, 0 warnings. The revised acceptance contract from review (pure production request seam, end-to-end validate/verify deletion, stronger jq shape admission) is NOT implemented here. Wound down per operator directive.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
stern-boar-596.Pushing to
integration/qwen-argvadvances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan