Repository navigation
qwen babysitter - #13647
qwen babysitter#13647gunbai-bot[bot] wants to merge 4 commits into
Conversation
…s tool module, not hand-typed Replace the two hand argv literals in the fleet reach/identity probe with home-module builders, dissolving the last hand argv in that module (roadmap shell-dag-host-reach-identity-probe; Lane B of the transport-argv anemia dissolution). - extdeps.tools.id: id_user_name_argv() -> [id, -un] (login name, no operand: id(1) with no operand answers from the calling process's own credentials, which is exactly the account the SSH session IS). - extdeps.tools.hostname: hostname_read_argv() -> [hostname] (bare, full configured name). The -s decision the row's first_slice names resolves to the bare read: the probe compares its output for exact equality against the enrolled short slot label, so -s (first label) would re-derive a label. - host_reach_identity_probe: probe_reachable_with_principal and probe_ready_target_once now call id_user_name_argv() and hostname_read_argv() instead of the literal [id,-un] and [hostname]. - witness: the_probe_argv_is_spelled_by_its_tool_module_builders pins each builder's materialized argv to the exact words the probe has always executed, so the flags cannot drift out from under the builder.
…ote-jq path (Lane B) Migrates the 15 raw sshpass-jq operations in openbmc_password_ssh_transport.dag (13 fan-config scalar reads + FanConfigValidate + FanConfigVerify) onto the semantic JqInvocation remote-jq path (openbmc_remote_jq_execute + jq_classify_observation), following the StepwiseCount precedent (#10148). - openbmc_password_ssh_transport.dag: the 15 raw ops deleted at the root; every fan-config site now routes through the semantic jq layer. - openbmc_operation.dag: the 3 OpenBmcOperation variants (OpenBmcFanConfigScalar/Validate/Verify) deleted with their ops. - openbmc_fan_control.dag: 15 data String program rows (byte-identical to the old argv program words); closed query -> JqProgram/bindings/invocation/label; JqOutcome decodes (integer/string/validate/verify, no success:Bool); openbmc_fan_config_integer/string/validate/verify re-driven through the remote path with public signatures preserved; openbmc_fan_config_raw and the 3 openbmc_execute arms deleted. State: WIP, pre-integration. Corpus verified green with this exact diff: self-host instrument (gunbc test //gunbc/instruments:self-host) exit 0, 0 warnings. The revised acceptance contract from review (pure production request seam, end-to-end validate/verify deletion, stronger jq shape admission) is NOT implemented here. Wound down per operator directive.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closing in the v1 closeout. This branch adds only #13632 on top of #13626, and #13626 is already in the mega branch #13641. #13632 is left out: its lane checked against a real run that jq |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ec54ac94e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Rejected { diagnostics: _ } => | ||
| OpenBmcBoolRefused { reason: "OpenBMC fan config verification could not be lowered to a jq invocation" } | ||
| Accepted { value: plan, diagnostics: _ } => | ||
| match openbmc_remote_jq_execute(session: session, plan: plan) { |
There was a problem hiding this comment.
For every OpenBMC readback in the current repository, remote_exec_command_live_confirmation is fixed to RemoteExecCommandLiveConfirmationUnexecuted; openbmc_remote_jq_interpretation consequently returns Unknown, so this call returns OpenBmcRemoteJqRefused before PasswordSshTransport.RunCommand can execute. Because this commit also deletes the previous FanConfigVerify transport operation and openbmc_fan_converge_route names this function as its readback, even a healthy BMC can no longer complete post-write verification. Keep the working transport path until the confirmation is recorded, or otherwise provide a confirmed interpretation for this route.
Useful? React with 👍 / 👎.
Auto-opened by session-dashboard for session
stern-boar-596.Pushing to
integration/qwen-argvadvances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan