Repository navigation
feat(grounding): T-Ground-CrossTarget-Meta L6 cross-product scaffold (R2 closure-pre-pass) - #1271
Merged
Merged
Conversation
…(R2 closure-pre-pass) Per manager dispatch (#1133 inbox 4353412409) — R2 closure-pre-pass sibling-crate scaffold for the L6 cross-product walker. Lane brief authority at docs/briefs/t-ground-cross-target-meta.md (#1224 + substrate anchor #1229). New crate: src/v3/grounding_cross_target_meta/ - Cargo.toml (v3-compiler dep only; SG-0 ratchet preserved) - src/lib.rs — public entry check_l6_load_completeness; 3 tests (cross_product_walks_90_cells; current_coverage_is_zero_with_named_gaps; every_missing_cell_has_typed_diagnostic) - src/cells.rs — FormAxis (6 TypeConnective variants), BehaviorAxis (5 Behavior variants), ShapeATarget (3 targets), Cell::all() iterator enumerating the 90 cells - src/diagnostic.rs — lane-local EmissionDiagnostic mirror (#1216 substrate-carrier convergence target); MissingEmissionPath variant carries (connective, behavior, target) coordinates - src/walker.rs — pure-function walk_cross_product over the bootstrap Dag; reports per-cell present/missing coverage. Today's cell_covered_by_language_spec returns false for all cells (no LanguageSpec.emission_paths table yet — Phase 1.5+ Substrate slice); body grows when the table lands without changing public signature. Workspace member registration in root Cargo.toml. Discipline: - NOT a Lens<C> instance (runtime check; per brief + #1216) - No src/v3/compiler/ edits (SG-0) - PR-J cadence-confirmation is the formal acceptance gate per r2-grounding-manager.md:128 — separate substantive merge Test gate: 3 passed locally; cargo build clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Manager APPROVE. Clean R2-closure-pre-pass scaffold execution:
Mark ready and merge when CI green. R2 closure-pre-pass advance. |
This was referenced Apr 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
T-Ground-CrossTarget-Meta L6 cross-product walker scaffold per manager dispatch (#1133 inbox 4353412409). Sibling crate at
src/v3/grounding_cross_target_meta/; consumesv3-compiler::dagAPIs only (SG-0 ratchet preserved). Lane brief atdocs/briefs/t-ground-cross-target-meta.md(#1224 + substrate anchor #1229).Files:
src/v3/grounding_cross_target_meta/Cargo.toml— workspace member.src/v3/grounding_cross_target_meta/src/lib.rs— public entrycheck_l6_load_completeness; 3 tests.src/v3/grounding_cross_target_meta/src/cells.rs—FormAxis(6TypeConnectivediscriminants),BehaviorAxis(5Behaviorvariants),ShapeATarget(Rust/Python/Go),Cell::all()enumerating the 90 cells.src/v3/grounding_cross_target_meta/src/diagnostic.rs— lane-localEmissionDiagnostic::MissingEmissionPath { connective, behavior, target }(docs(briefs): author T-Ground-Diagnostic lane brief #1216 substrate-carrier convergence target).src/v3/grounding_cross_target_meta/src/walker.rs— pure-functionwalk_cross_productover the bootstrapDag; reports per-cell present/missing coverage.Cargo.toml.Cross-product axes: 6 connectives × 5 behaviors × 3 targets = 90 cells. Today's
LanguageSpechas noemission_pathstable populated (lands in T-Ground-LanguageSpec Phase 1.5+); walker reports 90/90MissingEmissionPathdiagnostics — every gap tracked, none silent.Discipline:
Lens<C>instance — runtime check (per brief +design-emission-model.md:958-959+:1107-1111).src/v3/compiler/edits (SG-0).cross_target_meta_l6_load_completeness_landedacceptance gate perr2-grounding-manager.md:128; this PR lands the walker only.Out of scope:
EmissionDiagnosticcarrier migration (T-Ground-Diagnostic; lane-local mirror staging-debt).Test plan
cargo build -p v3-grounding-cross-target-meta— cleancargo test -p v3-grounding-cross-target-meta— 3 passedcargo test --workspace --exclude v2-compiler-tests— CIcargo test -p v2-compiler-tests— CIcargo test -p v3-compiler --test integration lane2_stage_2d_symbolic_cost— CIcargo clippy --all-targets -- -D warnings— CIcargo fmt --all --check— CI🤖 Generated with Claude Code